February 2010 - coreboot - mail.coreboot.org

Adopt a patch
by Patrick Georgi Feb. 23, 2010

Feb. 23, 2010

Hi, I'm currently working on the backlog we have with patches and wanted to point out a nice tool we have for that. On http://patchwork.coreboot.org/project/coreboot/list/ you can find a patchwork installation which tracks our mailing list, keeping watch over submitted patches and the discussions related to them. Please feel encourage to look there for patches that seem to be forgotten, and review them, bring them alive again, and make sure, they can get in (or get improved on, if they need more work). Patches that are sufficiently processed (accepted/committed, rejected, superseded, etc) disappear from view, so as long as the default view on that page lists patches, there's still a patch that waits for someone to take care of it. It's also a good place to keep track of the patches you submitted over time, to see if they're in already. The patch list should be quite recent about which patches are in and which aren't. If you require additional privileges on patchwork, please tell me, and I'll set things up appropriately. Patrick

3 5

[PATCH]minor Kconfig cleanup: WAIT_BEFORE_CPUS_INIT
by Patrick Georgi Feb. 23, 2010

Feb. 23, 2010

Hi, attached patch removes Kconfig entries that disable WAIT_BEFORE_CPUS_INIT. It's disabled by default (see src/cpu/x86/Kconfig) Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de>

2 1

[PATCH] drivers vs. obj
by Myles Watson Feb. 23, 2010

Feb. 23, 2010

On Thu, Sep 24, 2009 at 12:52 AM, Stefan Reinauer <stepan(a)coresystems.de>wrote: Myles Watson wrote: > Are there other differences? Should I2C devices use objects, since > you can't scan for them? Some structures defined in the code are put in an extra section in the binary for enumeration. Those are: #define __console __attribute__((used, __section__(".rodata.console_drivers"))) #define __cpu_driver __attribute__((used,__section__(".rodata.cpu_driver"))) #define __pci_driver __attribute__((used,__section__(".rodata.pci_driver"))) All others don't need to be "drivers" Stefan --------------- Based on that, here's a patch that changes drivers that aren't console, pci, or cpu, to obj. The most common one was mainboard.c as a driver. Boot tested with Tyan s2895. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Thanks, Myles PS. It looks like the rtl8168 driver ought to go somewhere more general in the tree.

3 11

[PATCH] e7501 register pressure
by Stefan Reinauer Feb. 23, 2010

Feb. 23, 2010

See patch

3 4

[PATCH] (somewhat) clean up intel southbridge drivers
by Stefan Reinauer Feb. 23, 2010

Feb. 23, 2010

Hi there, the intel southbridge drivers are a mess. I suggest to do the following: cd coreboot/src/southbridge svn mv i82801ca i82801cx svn mv i82801dbm i82801dx svn mv i82801er i82801ex svn copy i82801xx i82801bx svn mv i82801xx i82801ax (plus, fixing up the filenames in these directories and the romstage.c and Kconfig files of the mainboards using those drivers) And then cleaning up all the code undermining the driver infrastructure in the 82801xx driver, so we can drop the spaghetti code that checks for PCI devices in actual init functions all over the place. Why? Because it is simply unmaintainable. The unified driver is not unified, it's rather incomplete enough so nobody noticed. The ICH4 and ICH4M are very similar. So are the ICH5 and ICH5M and ICH5R. It's a good idea to have a "unified" driver per chipset generation. But not across several generations of chipsets. In order to fix graphics output for the i830/ich4 combination I'd like to add an SMM handler and MBI interface to the ICH4 specific version of the code. But there's not much gain in trying to check ICH0 datasheets to see if what was never intended to be done on that chipset is possible. And if I go and add guards for PCI IDs in the code, I'll rather clean up the code to get it do the PCI ID matching that coreboot intended for such cases instead of spaghettiing them into runtime checks. I don't think that a shared driver like this is worth the ugliness that comes with it. It's fair to say that if you don't know if you have an ICH0 or ICH4, you can't do a coreboot port, because you will fail in so many other places before and after that. So folks, if you agree that we should clean up coreboot and make it easier for people, send me an Acked-by: for the above idea. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de>

4 6

[PATCH] simplify keyboard "API"
by Stefan Reinauer Feb. 23, 2010

Feb. 23, 2010

Not sure if this is such a good idea.. Opinions? See patch -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 drop runtime configuration checking layer from the code. Don't check for errors we can't handle gracefully anyways. It's always better to try initializing the keyboard controller when IO in the device tree is != 0x60/0x64 than to just drop out. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Index: src/mainboard/emulation/qemu-x86/mainboard.c =================================================================== --- src/mainboard/emulation/qemu-x86/mainboard.c (revision 4842) +++ src/mainboard/emulation/qemu-x86/mainboard.c (working copy) @@ -24,7 +24,7 @@ /* This sneaked in here, because Qemu does not * emulate a SuperIO chip */ - init_pc_keyboard(0x60, 0x64, 0); + pc_keyboard_init(0); /* The PIRQ table is not working well for interrupt routing purposes. * so we'll just set the IRQ directly. Index: src/superio/winbond/w83627thf/superio.c =================================================================== --- src/superio/winbond/w83627thf/superio.c (revision 4842) +++ src/superio/winbond/w83627thf/superio.c (working copy) @@ -49,7 +49,7 @@ case W83627THF_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/winbond/w83977tf/superio.c =================================================================== --- src/superio/winbond/w83977tf/superio.c (revision 4842) +++ src/superio/winbond/w83977tf/superio.c (working copy) @@ -56,7 +56,7 @@ case W83977TF_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/winbond/w83627dhg/superio.c =================================================================== --- src/superio/winbond/w83627dhg/superio.c (revision 4842) +++ src/superio/winbond/w83627dhg/superio.c (working copy) @@ -59,7 +59,7 @@ case W83627DHG_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/winbond/w83627thg/superio.c =================================================================== --- src/superio/winbond/w83627thg/superio.c (revision 4842) +++ src/superio/winbond/w83627thg/superio.c (working copy) @@ -48,7 +48,7 @@ case W83627THG_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/winbond/w83627ehg/superio.c =================================================================== --- src/superio/winbond/w83627ehg/superio.c (revision 4842) +++ src/superio/winbond/w83627ehg/superio.c (working copy) @@ -124,7 +124,7 @@ case W83627EHG_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; case W83627EHG_HWM: res0 = find_resource(dev, PNP_IDX_IO0); Index: src/superio/winbond/w83627uhg/superio.c =================================================================== --- src/superio/winbond/w83627uhg/superio.c (revision 4842) +++ src/superio/winbond/w83627uhg/superio.c (working copy) @@ -113,7 +113,7 @@ case W83627UHG_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/winbond/w83627hf/superio.c =================================================================== --- src/superio/winbond/w83627hf/superio.c (revision 4842) +++ src/superio/winbond/w83627hf/superio.c (working copy) @@ -116,7 +116,7 @@ case W83627HF_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; case W83627HF_HWM: res0 = find_resource(dev, PNP_IDX_IO0); Index: src/superio/winbond/w83977f/superio.c =================================================================== --- src/superio/winbond/w83977f/superio.c (revision 4842) +++ src/superio/winbond/w83977f/superio.c (working copy) @@ -61,7 +61,7 @@ case W83977F_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/ite/it8712f/superio.c =================================================================== --- src/superio/ite/it8712f/superio.c (revision 4842) +++ src/superio/ite/it8712f/superio.c (working copy) @@ -78,7 +78,7 @@ res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); set_kbc_ps2_mode(); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; case IT8712F_KBCM: /* TODO. */ break; Index: src/superio/ite/it8671f/superio.c =================================================================== --- src/superio/ite/it8671f/superio.c (revision 4842) +++ src/superio/ite/it8671f/superio.c (working copy) @@ -53,7 +53,7 @@ case IT8671F_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; case IT8671F_KBCM: /* TODO. */ break; Index: src/superio/ite/it8716f/superio.c =================================================================== --- src/superio/ite/it8716f/superio.c (revision 4842) +++ src/superio/ite/it8716f/superio.c (working copy) @@ -112,7 +112,7 @@ case IT8716F_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/ite/it8673f/superio.c =================================================================== --- src/superio/ite/it8673f/superio.c (revision 4842) +++ src/superio/ite/it8673f/superio.c (working copy) @@ -55,7 +55,7 @@ case IT8673F_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; case IT8673F_KBCM: /* TODO. */ break; Index: src/superio/ite/it8718f/superio.c =================================================================== --- src/superio/ite/it8718f/superio.c (revision 4842) +++ src/superio/ite/it8718f/superio.c (working copy) @@ -55,7 +55,7 @@ case IT8718F_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; case IT8718F_KBCM: /* TODO. */ break; Index: src/superio/nsc/pc87366/superio.c =================================================================== --- src/superio/nsc/pc87366/superio.c (revision 4842) +++ src/superio/nsc/pc87366/superio.c (working copy) @@ -37,7 +37,7 @@ case PC87366_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/nsc/pc8374/superio.c =================================================================== --- src/superio/nsc/pc8374/superio.c (revision 4842) +++ src/superio/nsc/pc8374/superio.c (working copy) @@ -37,7 +37,7 @@ case PC8374_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/nsc/pc87351/superio.c =================================================================== --- src/superio/nsc/pc87351/superio.c (revision 4842) +++ src/superio/nsc/pc87351/superio.c (working copy) @@ -43,7 +43,7 @@ case PC87351_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/nsc/pc87360/superio.c =================================================================== --- src/superio/nsc/pc87360/superio.c (revision 4842) +++ src/superio/nsc/pc87360/superio.c (working copy) @@ -37,7 +37,7 @@ case PC87360_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/nsc/pc97307/superio.c =================================================================== --- src/superio/nsc/pc97307/superio.c (revision 4842) +++ src/superio/nsc/pc97307/superio.c (working copy) @@ -38,7 +38,7 @@ res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; case PC97307_FDC: Index: src/superio/nsc/pc87309/superio.c =================================================================== --- src/superio/nsc/pc87309/superio.c (revision 4842) +++ src/superio/nsc/pc87309/superio.c (working copy) @@ -48,7 +48,7 @@ case PC87309_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/nsc/pc87417/superio.c =================================================================== --- src/superio/nsc/pc87417/superio.c (revision 4842) +++ src/superio/nsc/pc87417/superio.c (working copy) @@ -39,7 +39,7 @@ case PC87417_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/nsc/pc97317/superio.c =================================================================== --- src/superio/nsc/pc97317/superio.c (revision 4842) +++ src/superio/nsc/pc97317/superio.c (working copy) @@ -38,7 +38,7 @@ res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; #if 0 Index: src/superio/nsc/pc87427/superio.c =================================================================== --- src/superio/nsc/pc87427/superio.c (revision 4842) +++ src/superio/nsc/pc87427/superio.c (working copy) @@ -36,7 +36,7 @@ case PC87427_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/smsc/lpc47m10x/superio.c =================================================================== --- src/superio/smsc/lpc47m10x/superio.c (revision 4842) +++ src/superio/smsc/lpc47m10x/superio.c (working copy) @@ -152,7 +152,7 @@ case LPC47M10X2_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/smsc/fdc37m60x/superio.c =================================================================== --- src/superio/smsc/fdc37m60x/superio.c (revision 4842) +++ src/superio/smsc/fdc37m60x/superio.c (working copy) @@ -53,7 +53,7 @@ case FDC37M60X_KBCK: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; case FDC37M60X_AUX: /* TODO. */ break; Index: src/superio/smsc/lpc47b272/superio.c =================================================================== --- src/superio/smsc/lpc47b272/superio.c (revision 4842) +++ src/superio/smsc/lpc47b272/superio.c (working copy) @@ -154,7 +154,7 @@ case LPC47B272_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } } Index: src/superio/smsc/smscsuperio/superio.c =================================================================== --- src/superio/smsc/smscsuperio/superio.c (revision 4842) +++ src/superio/smsc/smscsuperio/superio.c (working copy) @@ -230,7 +230,7 @@ } else if (ld == logical_device_table[i].devs[LD_KBC]) { res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); } } Index: src/superio/smsc/lpc47b397/superio.c =================================================================== --- src/superio/smsc/lpc47b397/superio.c (revision 4842) +++ src/superio/smsc/lpc47b397/superio.c (working copy) @@ -68,7 +68,7 @@ case LPC47B397_KBC: res0 = find_resource(dev, PNP_IDX_IO0); res1 = find_resource(dev, PNP_IDX_IO1); - init_pc_keyboard(res0->base, res1->base, &conf->keyboard); + pc_keyboard_init(&conf->keyboard); break; } Index: src/northbridge/via/cx700/cx700_lpc.c =================================================================== --- src/northbridge/via/cx700/cx700_lpc.c (revision 4842) +++ src/northbridge/via/cx700/cx700_lpc.c (working copy) @@ -384,7 +384,7 @@ isa_dma_init(); /* Initialize keyboard controller */ - init_pc_keyboard(0x60, 0x64, 0); + pc_keyboard_init(0); } static struct device_operations cx700_lpc_ops = { Index: src/northbridge/via/vx800/vx800_lpc.c =================================================================== --- src/northbridge/via/vx800/vx800_lpc.c (revision 4842) +++ src/northbridge/via/vx800/vx800_lpc.c (working copy) @@ -342,7 +342,7 @@ setup_i8259(); // make sure interupt controller is configured before keyboard init /* turn on keyboard and RTC, no need to visit this reg twice */ - init_pc_keyboard(0x60, 0x64, 0); + pc_keyboard_init(0); printk_debug ("ps2 usb lid, you set who can wakeup system from s3 sleep\n"); S3_ps2_kb_ms_wakeup(dev); Index: src/southbridge/via/vt8237r/vt8237r_lpc.c =================================================================== --- src/southbridge/via/vt8237r/vt8237r_lpc.c (revision 4842) +++ src/southbridge/via/vt8237r/vt8237r_lpc.c (working copy) @@ -615,7 +615,7 @@ { u8 regval = pci_read_config8(dev, 0x51); if (regval & 0x1) - init_pc_keyboard(0x60, 0x64, 0); + pc_keyboard_init(0); } static void southbridge_init_common(struct device *dev) Index: src/southbridge/via/vt8231/vt8231.c =================================================================== --- src/southbridge/via/vt8231/vt8231.c (revision 4842) +++ src/southbridge/via/vt8231/vt8231.c (working copy) @@ -26,7 +26,7 @@ regval |= 0x0f; pci_write_config8(lpc_dev, 0x51, regval); } - init_pc_keyboard(0x60, 0x64, 0); + pc_keyboard_init(0); } static void com_port_on(void) Index: src/southbridge/via/vt8235/vt8235.c =================================================================== --- src/southbridge/via/vt8235/vt8235.c (revision 4842) +++ src/southbridge/via/vt8235/vt8235.c (working copy) @@ -26,7 +26,7 @@ regval &= 0xfd; pci_write_config8(dev, 0x51, regval); - init_pc_keyboard(0x60, 0x64, 0); + pc_keyboard_init(0); } void dump_south(device_t dev0) Index: src/southbridge/sis/sis966/sis966_lpc.c =================================================================== --- src/southbridge/sis/sis966/sis966_lpc.c (revision 4842) +++ src/southbridge/sis/sis966/sis966_lpc.c (working copy) @@ -171,7 +171,7 @@ int nmi_option; printk_debug("LPC_INIT -------->\n"); - init_pc_keyboard(0x60, 0x64, 0); + pc_keyboard_init(0); lpc_usb_legacy_init(dev); lpc_common_init(dev); Index: src/pc80/keyboard.c =================================================================== --- src/pc80/keyboard.c (revision 4842) +++ src/pc80/keyboard.c (working copy) @@ -159,7 +159,7 @@ return regval; } -static void pc_keyboard_init(struct pc_keyboard *keyboard) +void pc_keyboard_init(struct pc_keyboard *keyboard) { u8 regval; printk_debug("Keyboard init...\n"); @@ -242,16 +242,6 @@ } } - -void init_pc_keyboard(unsigned port0, unsigned port1, struct pc_keyboard *kbd) -{ - if ((port0 == 0x60) && (port1 == 0x64)) { - pc_keyboard_init(kbd); - } else { - printk_warning("Unsupported keyboard controller.\n"); - } -} - /* * Support PS/2 mode - oddball SIOs(KBC) need this setup * Not well documented. Google - 0xcb keyboard controller Index: src/include/pc80/keyboard.h =================================================================== --- src/include/pc80/keyboard.h (revision 4842) +++ src/include/pc80/keyboard.h (working copy) @@ -5,7 +5,7 @@ /* No initialization parameters for now */ }; -void init_pc_keyboard(unsigned port0, unsigned port1, struct pc_keyboard *kbd); +void pc_keyboard_init(struct pc_keyboard *keyboard); void set_kbc_ps2_mode(void); #endif /* PC80_KEYBOARD_H */

2 1

[PATCH]: Report svnversion in Kconfig mode
by Bao, Zheng Feb. 23, 2010

Feb. 23, 2010

Finding out the svnversion we are working on is quite important, I think. The whole string is copied from original newconfig. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Index: Makefile =================================================================== --- Makefile (revision 5133) +++ Makefile (working copy) @@ -253,7 +253,7 @@ printf "/* build system definitions (autogenerated) */\n" > $(obj)/build.ht printf "#ifndef __BUILD_H\n" >> $(obj)/build.ht printf "#define __BUILD_H\n\n" >> $(obj)/build.ht - printf "#define COREBOOT_VERSION \"$(KERNELVERSION)\"\n" >> $(obj)/build.ht + printf "#define COREBOOT_VERSION \"$(KERNELVERSION)-r$(shell if [ -d $(top)/.svn -a -f `which svnversion` ]; then svnversion $(top); else if [ -d $(top)/.git -a -f `which git` ]; then git --git-dir=/$(top)/.git log|grep git-svn-id|cut -f 2 -d@|cut -f 1 -d' '|sort -g|tail -1; fi; fi)\"\n" >> $(obj)/build.ht printf "#define COREBOOT_EXTRA_VERSION \"$(COREBOOT_EXTRA_VERSION)\"\n" >> $(obj)/build.ht printf "#define COREBOOT_BUILD \"`LANG= date`\"\n" >> $(obj)/build.ht printf "\n" >> $(obj)/build.ht

2 1

[PATCH] remove support for the S3 on M2V-MX SE
by Rudolf Marek Feb. 23, 2010

Feb. 23, 2010

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, I still did not find time to fix the cbmem stuff to work on K8, making resume always fail. It is broken since stephan checked in the cbmem stuff. Also, because kconfig has RAMBASE and RAMTOP on 1M - 2M adding the e820 reserved region when HAVE_ACPI_RESUME is there forces the grub to fail with "inconsistent filesystem" - it took me 3hours to find this out. It was 31M-32M hole for suspend/resume without memory backup. But for some reason this change was not correctly copied to kconfig, maybe the HAVE_MOTHERBOARD_RESOURCES was missing too making the mistake hard to find ;) Anyway, disabling the suspend/resume now. Its broken. Either cbmem stuff needs to be fixed, or old functionality for suspend/resume with hole must be restored, and for this board a hole must reside on 31MB or above. Signed-off-by: Rudolf Marek <r.marek(a)assembler.cz> Thanks Rudolf -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkuBrsYACgkQ3J9wPJqZRNXv6wCfecF+E2awc7q8RqqcHfJhVlxp IdMAoLFlcDrrVbgvpmQA95KPhOwZ5ccx =P+SA -----END PGP SIGNATURE-----

3 2

[commit] r5148 - trunk/src/mainboard/asus/m2v-mx_se
by repository service Feb. 23, 2010

Feb. 23, 2010

Author: oxygene Date: Tue Feb 23 11:22:37 2010 New Revision: 5148 URL: http://tracker.coreboot.org/trac/coreboot/changeset/5148 Log: Disable ACPI Resume on asus/m2v-mx_se, it's broken since cbmem Signed-off-by: Rudolf Marek <r.marek(a)assembler.cz> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/src/mainboard/asus/m2v-mx_se/Kconfig Modified: trunk/src/mainboard/asus/m2v-mx_se/Kconfig ============================================================================== --- trunk/src/mainboard/asus/m2v-mx_se/Kconfig Tue Feb 23 11:18:43 2010 (r5147) +++ trunk/src/mainboard/asus/m2v-mx_se/Kconfig Tue Feb 23 11:22:37 2010 (r5148) @@ -32,7 +32,6 @@ select HAVE_HARD_RESET select HAVE_OPTION_TABLE select HAVE_ACPI_TABLES - select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 select VGA select TINY_BOOTBLOCK

1 0

[patch] ms7135 fixes, updates
by Jonathan A. Kollasch Feb. 23, 2010

Feb. 23, 2010

Adjust msi/ms7135 DCACHE_RAM_* config to previous 32KiB values, 4KiB is not enough to work. Additionally, modify the device tree so that the undocumented LDN 6 is ignored by the resource allocator, and while here, assign the parallel port DRQ, hardware monitor IRQ and drop NIC MAC address on SMBus EEPROM hint, the ms7135 doesn't have such hardware. Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> ---

2 1