coreboot April 2009

coreboot@coreboot.org

69 participants
583 discussions

build service results for r4079
by coreboot information 07 Apr '09

07 Apr '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "rminnich" checked in revision 4079 to the coreboot repository. This caused the following changes: Change Log: This fixes a bug in romfs code; see comment. If we add the pci rom to romfs for qemu,we get this: Check pci1013,00b8.rom found it, @ fff99698, first word is e946aa55 In cbfs, rom address for PCI: 00:02.0 = 0 On mainboard, rom address for PCI: 00:02.0 = fff99698 copying VGA ROM Image from fff99698 to 0xc0000, 0x8c00 bytes This is sort of OK, excpet that when it gets to payload time, the system explodes. I suspect that copy is kind of a problem. But this is a pretty important bug fix so in it goes. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Build Log: Compilation of embeddedplanet:ep405pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4079&device=ep405pc&vendor… Configuration of motorola:sandpoint is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4079&device=sandpoint&vend… Compilation of motorola:sandpointx3_altimus_mpc7410 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4079&device=sandpointx3_al… Compilation of technexion:tim8690 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4079&device=tim8690&vendor… Compilation of totalimpact:briq is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4079&device=briq&vendor=to… If something broke during this checkin please be a pain in rminnich's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[v2] r4079 - trunk/coreboot-v2/src/lib
by svn＠coreboot.org 07 Apr '09

07 Apr '09

Author: rminnich Date: 2009-04-07 01:28:22 +0200 (Tue, 07 Apr 2009) New Revision: 4079 Modified: trunk/coreboot-v2/src/lib/romfs.c Log: This fixes a bug in romfs code; see comment. If we add the pci rom to romfs for qemu,we get this: Check pci1013,00b8.rom found it, @ fff99698, first word is e946aa55 In cbfs, rom address for PCI: 00:02.0 = 0 On mainboard, rom address for PCI: 00:02.0 = fff99698 copying VGA ROM Image from fff99698 to 0xc0000, 0x8c00 bytes This is sort of OK, excpet that when it gets to payload time, the system explodes. I suspect that copy is kind of a problem. But this is a pretty important bug fix so in it goes. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Modified: trunk/coreboot-v2/src/lib/romfs.c =================================================================== --- trunk/coreboot-v2/src/lib/romfs.c 2009-04-06 20:38:34 UTC (rev 4078) +++ trunk/coreboot-v2/src/lib/romfs.c 2009-04-06 23:28:22 UTC (rev 4079) @@ -151,7 +151,8 @@ * return a pointer to it. */ - src = ((unsigned char *) orom) + sizeof(struct romfs_optionrom); + /* BUG: the romtool is (not yet) including a romfs_optionrom header */ + src = ((unsigned char *) orom); // + sizeof(struct romfs_optionrom); if (! dest) return src;

1 0

[PATCH] Build fix: switch from "git-foo" to "git foo" for git 1.6
by Bernie Innocenti 06 Apr '09

06 Apr '09

Signed-off-by: Bernie Innocenti <bernie(a)codewiz.org> Index: bin/fetchgit.sh =================================================================== --- bin/fetchgit.sh (revision 261) +++ bin/fetchgit.sh (working copy) @@ -11,7 +11,7 @@ if [ ! -d $DIR/.git ]; then echo "Cloning $URL..." - git-clone $URL $DIR + git clone $URL $DIR if [ $? -ne 0 ]; then echo "Couldn't clone $URL." exit 1 @@ -22,10 +22,10 @@ export GIT_DIR=$DIR/.git -git-fetch $URL -git-fetch --tags $URL -git-prune-packed -git-pack-redundant --all | xargs -r rm +git fetch $URL +git fetch --tags $URL +git prune-packed +git pack-redundant --all | xargs -r rm # Make the tarball -git-tar-tree $TAG $NAME-$TAG | bzip2 > $TARBALL +git tar-tree $TAG $NAME-$TAG | bzip2 > $TARBALL -- // Bernie Innocenti - http://www.codewiz.org/ \X/ Sugar Labs - http://www.sugarlabs.org/

2 1

[BuildROM] r262 - buildrom-devel/bin
by svn＠coreboot.org 06 Apr '09

06 Apr '09

Author: ward Date: 2009-04-06 23:01:57 +0200 (Mon, 06 Apr 2009) New Revision: 262 Modified: buildrom-devel/bin/fetchgit.sh Log: Build fix: switch from "git-foo" to "git foo" for git 1.6 Signed-off-by: Bernie Innocenti <bernie(a)codewiz.org> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: buildrom-devel/bin/fetchgit.sh =================================================================== --- buildrom-devel/bin/fetchgit.sh 2009-03-20 18:56:52 UTC (rev 261) +++ buildrom-devel/bin/fetchgit.sh 2009-04-06 21:01:57 UTC (rev 262) @@ -11,7 +11,7 @@ if [ ! -d $DIR/.git ]; then echo "Cloning $URL..." - git-clone $URL $DIR + git clone $URL $DIR if [ $? -ne 0 ]; then echo "Couldn't clone $URL." exit 1 @@ -22,10 +22,10 @@ export GIT_DIR=$DIR/.git -git-fetch $URL -git-fetch --tags $URL -git-prune-packed -git-pack-redundant --all | xargs -r rm +git fetch $URL +git fetch --tags $URL +git prune-packed +git pack-redundant --all | xargs -r rm # Make the tarball -git-tar-tree $TAG $NAME-$TAG | bzip2 > $TARBALL +git tar-tree $TAG $NAME-$TAG | bzip2 > $TARBALL

1 0

build service results for r4078
by coreboot information 06 Apr '09

06 Apr '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "rminnich" checked in revision 4078 to the coreboot repository. This caused the following changes: Change Log: Some changes for option roms: - don't make users pick the name. Names for option roms are in the v3-defined format of pci%04x,%04x.rom with the vendor and device id filling in the %04x. - users pass in vendor and device id. - users pass in a dest. If the dest is 0, the address of the ROM image in FLASH is returned. If the address is non-zero, then the decmpressor is called, and it will make sure the ROM image is copied to the destination (even in the uncompressed case). move qemu over to always using ROMFS Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Build Log: Compilation of embeddedplanet:ep405pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4078&device=ep405pc&vendor… Configuration of motorola:sandpoint is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4078&device=sandpoint&vend… Compilation of motorola:sandpointx3_altimus_mpc7410 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4078&device=sandpointx3_al… Compilation of technexion:tim8690 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4078&device=tim8690&vendor… Compilation of totalimpact:briq is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4078&device=briq&vendor=to… If something broke during this checkin please be a pain in rminnich's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

final romfs patch for pci_rom.c
by ron minnich 06 Apr '09

06 Apr '09

build and boot tested on qemu. Backwards-compatible, I have not even tested with a rom in romfs yet :-) ron

3 4

[v2] r4078 - in trunk/coreboot-v2: src/devices src/mainboard/emulation/qemu-x86 targets/emulation/qemu-x86
by svn＠coreboot.org 06 Apr '09

06 Apr '09

Author: rminnich Date: 2009-04-06 22:38:34 +0200 (Mon, 06 Apr 2009) New Revision: 4078 Modified: trunk/coreboot-v2/src/devices/pci_rom.c trunk/coreboot-v2/src/mainboard/emulation/qemu-x86/Options.lb trunk/coreboot-v2/targets/emulation/qemu-x86/Config.lb Log: Some changes for option roms: - don't make users pick the name. Names for option roms are in the v3-defined format of pci%04x,%04x.rom with the vendor and device id filling in the %04x. - users pass in vendor and device id. - users pass in a dest. If the dest is 0, the address of the ROM image in FLASH is returned. If the address is non-zero, then the decmpressor is called, and it will make sure the ROM image is copied to the destination (even in the uncompressed case). move qemu over to always using ROMFS Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Modified: trunk/coreboot-v2/src/devices/pci_rom.c =================================================================== --- trunk/coreboot-v2/src/devices/pci_rom.c 2009-04-06 16:03:53 UTC (rev 4077) +++ trunk/coreboot-v2/src/devices/pci_rom.c 2009-04-06 20:38:34 UTC (rev 4078) @@ -31,32 +31,40 @@ struct rom_header * pci_rom_probe(struct device *dev) { - unsigned long rom_address; + unsigned long rom_address = 0; struct rom_header *rom_header; struct pci_data *rom_data; if (CONFIG_ROMFS) { - rom_address = (unsigned long) romfs_load_optionrom(dev->vendor, dev->device, NULL); + void *v; /* if it's in FLASH, then it's as if dev->on_mainboard was true */ - dev->on_mainboard = 1; - /* and we might as well set the address correctly */ - dev->rom_address = rom_address; - } else if (dev->on_mainboard) { + v = romfs_load_optionrom(dev->vendor, dev->device, NULL); + printk_debug("In cbfs, rom address for %s = %lx\n", + dev_path(dev), rom_address); + if (v) { + dev->rom_address = v; + dev->on_mainboard = 1; + } + } + + if (dev->on_mainboard) { /* this is here as a legacy path. We hope it goes away soon. Users should not have to * compute the ROM address at build time! */ // in case some device PCI_ROM_ADDRESS can not be set or readonly rom_address = dev->rom_address; + printk_debug("On mainboard, rom address for %s = %lx\n", + dev_path(dev), rom_address); } else { rom_address = pci_read_config32(dev, PCI_ROM_ADDRESS); + printk_debug("On card, rom address for %s = %lx\n", + dev_path(dev), rom_address); } if (rom_address == 0x00000000 || rom_address == 0xffffffff) { return NULL; } - printk_debug("rom address for %s = %lx\n", dev_path(dev), rom_address); - if(!dev->on_mainboard) { /* enable expansion ROM address decoding */ pci_write_config32(dev, PCI_ROM_ADDRESS, Modified: trunk/coreboot-v2/src/mainboard/emulation/qemu-x86/Options.lb =================================================================== --- trunk/coreboot-v2/src/mainboard/emulation/qemu-x86/Options.lb 2009-04-06 16:03:53 UTC (rev 4077) +++ trunk/coreboot-v2/src/mainboard/emulation/qemu-x86/Options.lb 2009-04-06 20:38:34 UTC (rev 4078) @@ -49,7 +49,7 @@ default CONFIG_CONSOLE_SERIAL8250=1 default DEFAULT_CONSOLE_LOGLEVEL=8 default MAXIMUM_CONSOLE_LOGLEVEL=8 -default CONFIG_ROMFS=0 +default CONFIG_ROMFS=1 ## ROM_SIZE is the size of boot ROM that this board will use. default ROM_SIZE = 256*1024 Modified: trunk/coreboot-v2/targets/emulation/qemu-x86/Config.lb =================================================================== --- trunk/coreboot-v2/targets/emulation/qemu-x86/Config.lb 2009-04-06 16:03:53 UTC (rev 4077) +++ trunk/coreboot-v2/targets/emulation/qemu-x86/Config.lb 2009-04-06 20:38:34 UTC (rev 4078) @@ -10,12 +10,12 @@ option HAVE_PIRQ_TABLE=1 option IRQ_SLOT_COUNT=6 -romimage "image" +romimage "normal" option ROM_IMAGE_SIZE=0x10000 option COREBOOT_EXTRA_VERSION="-GRUB2" # payload /home/stepan/core.img payload ../payload.elf end -buildrom ./coreboot.rom ROM_SIZE "image" +buildrom ./coreboot.rom ROM_SIZE "normal"

1 0

[PATCH] Build fix: add a fallback for systems where tempfile is missing
by Bernie Innocenti 06 Apr '09

06 Apr '09

Signed-off-by: Bernie Innocenti <bernie(a)codewiz.org> Index: bin/show-instructions.sh =================================================================== --- bin/show-instructions.sh (revision 261) +++ bin/show-instructions.sh (working copy) @@ -1,6 +1,6 @@ #!/bin/sh -tmp=`tempfile` +tmp=`tempfile 2>/dev/null || echo /tmp/show-instructions.$$` cat $1 | sed -e "s:%DESTFILE%:$2:" > $tmp if [ -x `dirname $0`/../scripts/kconfig/lxdialog/lxdialog ]; then -- // Bernie Innocenti - http://www.codewiz.org/ \X/ Sugar Labs - http://www.sugarlabs.org/

1 0

[PATCH] Build fixes for buildrom
by Bernie Innocenti 06 Apr '09

06 Apr '09

Build fixes for buildrom - switch from "git-foo" to "git foo" for git 1.6 - add a fallback for when tempfile is missing Signed-off-by: Bernie Innocenti <bernie(a)codewiz.org> Index: bin/fetchgit.sh =================================================================== --- bin/fetchgit.sh (revision 261) +++ bin/fetchgit.sh (working copy) @@ -11,7 +11,7 @@ if [ ! -d $DIR/.git ]; then echo "Cloning $URL..." - git-clone $URL $DIR + git clone $URL $DIR if [ $? -ne 0 ]; then echo "Couldn't clone $URL." exit 1 @@ -22,10 +22,10 @@ export GIT_DIR=$DIR/.git -git-fetch $URL -git-fetch --tags $URL -git-prune-packed -git-pack-redundant --all | xargs -r rm +git fetch $URL +git fetch --tags $URL +git prune-packed +git pack-redundant --all | xargs -r rm # Make the tarball -git-tar-tree $TAG $NAME-$TAG | bzip2 > $TARBALL +git tar-tree $TAG $NAME-$TAG | bzip2 > $TARBALL Index: bin/show-instructions.sh =================================================================== --- bin/show-instructions.sh (revision 261) +++ bin/show-instructions.sh (working copy) @@ -1,6 +1,6 @@ #!/bin/sh -tmp=`tempfile` +tmp=`tempfile 2>/dev/null | echo /tmp/show-instructions.$$` cat $1 | sed -e "s:%DESTFILE%:$2:" > $tmp if [ -x `dirname $0`/../scripts/kconfig/lxdialog/lxdialog ]; then -- // Bernie Innocenti - http://www.codewiz.org/ \X/ Sugar Labs - http://www.sugarlabs.org/

2 2

build service results for r4077
by coreboot information 06 Apr '09

06 Apr '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 4077 to the coreboot repository. This caused the following changes: Change Log: Add support for romfs to option rom loading. Pretty simple: Find the rom in the romfs, if found, set dev properties so that the rest of the code works. At some point, we can remove some of the other code, i.e. the first else, and stop requiring people to do math. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Build Log: Compilation of embeddedplanet:ep405pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4077&device=ep405pc&vendor… Configuration of motorola:sandpoint is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4077&device=sandpoint&vend… Compilation of motorola:sandpointx3_altimus_mpc7410 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4077&device=sandpointx3_al… Compilation of technexion:tim8690 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4077&device=tim8690&vendor… Compilation of totalimpact:briq is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4077&device=briq&vendor=to… If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

← Newer
1
...
45
46
47
48
49
50
51
...
59
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot April 2009