[PATCH] Serengeti failover fix

[Myles Watson]

Simplify targets/amd/serengeti_cheetah/Config.lb.  There were too many
variables being set incorrectly.

Boot tested on SimNOW.

Signed-off-by: Myles Watson

It is also abuild-tested, but abuild doesn't use this Config file.
That's why the broken build wasn't caught before this.

Thanks,
Myles

[Peter Stuge]

Myles Watson wrote:
> Simplify targets/amd/serengeti_cheetah/Config.lb.  There were too many
> variables being set incorrectly.
>
> Boot tested on SimNOW.
>
> Signed-off-by: Myles Watson

Acked-by: Peter Stuge
> It is also abuild-tested, but abuild doesn't use this Config file.
> That's why the broken build wasn't caught before this.

I think it would be nice to not have a special config for build
testing with Kconfig, to try to avoid that. If something is broken we
should try to fix it.

//Peter

[Patrick Georgi]

Am Donnerstag, den 08.10.2009, 19:21 +0200 schrieb Peter Stuge:
> I think it would be nice to not have a special config for build
> testing with Kconfig, to try to avoid that. If something is broken we
> should try to fix it.

kbuildall should be the same as selecting the vendor+board and leaving
everything else to defaults.

Patrick

[Myles Watson]

On Thu, Oct 8, 2009 at 11:44 AM, Patrick Georgi  wrote:
> Am Donnerstag, den 08.10.2009, 19:21 +0200 schrieb Peter Stuge:
> > I think it would be nice to not have a special config for build
> > testing with Kconfig, to try to avoid that. If something is broken we
> > should try to fix it.
>
> kbuildall should be the same as selecting the vendor+board and leaving
> everything else to defaults.

Yes.  It's very nice.  The only thing that's missing is mailing list
integration.

Thanks,
Myles

[Peter Stuge]

Patrick Georgi wrote:
> > I think it would be nice to not have a special config for build
> > testing with Kconfig,
>
> kbuildall should be the same as selecting the vendor+board and
> leaving everything else to defaults.

Fantastic!

I am really excited about these improvements to coreboot thanks to
Kconfig and cbfs! It may seem trivial when familiar with the code
already but it is a HUGE improvement in usability for aspiring
coreboot developers! :)

//Peter

[Myles Watson]

On Thu, Oct 8, 2009 at 11:21 AM, Peter Stuge  wrote:
> Myles Watson wrote:
> > Simplify targets/amd/serengeti_cheetah/Config.lb.  There were too many
> > variables being set incorrectly.
> >
> > Boot tested on SimNOW.
> >
> > Signed-off-by: Myles Watson
>
> Acked-by: Peter Stuge

Rev 4747.

Thanks,
Myles