Re: [coreboot] r3463 - trunk/coreboot-v2/src/cpu/x86/car

[Uwe Hermann]

On Sat, Aug 02, 2008 at 05:09:13PM +0200, [e-mail] wrote:
> #if CONFIG_USE_INIT
> printk_debug("linxbios_ram.bin length = %08x\r\n", olen);
> printk_spew("linxbios_ram.bin length = %08x\r\n", olen);
>
> #else
> print_debug("linxbios_ram.bin length = "); print_debug_hex32(olen); print_debug("\r\n");
> print_spew("linxbios_ram.bin length = "); print_spew_hex32(olen); print_spew("\r\n");

Should we also fix this while we're at it? "linx" -> "linux", or even
better "linxbios" -> "coreboot"?

Uwe.

r3463 - trunk/coreboot-v2/src/cpu/x86/car

[Peter Stuge]

On Sat, Aug 02, 2008 at 07:05:19PM +0200, Uwe Hermann wrote:
> On Sat, Aug 02, 2008 at 05:09:13PM +0200, [e-mail] wrote:
> > #if CONFIG_USE_INIT
> > printk_debug("linxbios_ram.bin length = %08x\r\n", olen);
> > printk_spew("linxbios_ram.bin length = %08x\r\n", olen);
> >
> > #else
> > print_debug("linxbios_ram.bin length = "); print_debug_hex32(olen); print_debug("\r\n");
> > print_spew("linxbios_ram.bin length = "); print_spew_hex32(olen); print_spew("\r\n");
>
> Should we also fix this while we're at it? "linx" -> "linux", or even
> better "linxbios" -> "coreboot"?

That would be great.

//Peter

r3463 - trunk/coreboot-v2/src/cpu/x86/car

[Uwe Hermann]

On Sat, Aug 02, 2008 at 07:21:17PM +0200, Peter Stuge wrote:
> On Sat, Aug 02, 2008 at 07:05:19PM +0200, Uwe Hermann wrote:
> > On Sat, Aug 02, 2008 at 05:09:13PM +0200, [e-mail] wrote:
> > > #if CONFIG_USE_INIT
> > > printk_debug("linxbios_ram.bin length = %08x\r\n", olen);
> > > printk_spew("linxbios_ram.bin length = %08x\r\n", olen);
> > >
> > > #else
> > > print_debug("linxbios_ram.bin length = "); print_debug_hex32(olen); print_debug("\r\n");
> > > print_spew("linxbios_ram.bin length = "); print_spew_hex32(olen); print_spew("\r\n");
> >
> > Should we also fix this while we're at it? "linx" -> "linux", or even
> > better "linxbios" -> "coreboot"?
>
> That would be great.

Done in r3466.

Uwe.