Re: [coreboot] Patch to add MSI MS-9652 support to CoreBoot

Attached is a replacement MSI MS-9652 support patch with KConfig fixed and
tested as working.

Newconfig has been removed.

Audio and 1394 have now been tested and work properly.

Status of PCI/PCIe slot IRQ routing is unknown at this time, but presumed
broken.

Signed-off-by: Timothy Pearson <[e-mail]>

---

Timothy Pearson
Raptor Engineering
> Attached is a patch to add support for the MSI MS-9652 board to CoreBoot.
>
> The PCI routing tables and ACPI implementation are incomplete; I have all
> the functionality I need at this time so I will probably not be fixing
> them.
>
> The board boots and the following items work under the newconfig build
> system
>  * Two quad core Opteron Barcelona processors (with previously sent patch)
>  * ECC DDR2 memory, all DIMM slots are functional
>  * Both on-board NIC cards, with factory MAC addresses being read properly
>  * Serial port
>  * PS2 keyboard/mouse
>  * All four on-board USB ports
>  * The flashrom utility, all functions
>
> What does not work
>  * PCI/PCIe slot IRQs
>  * ACPI
>  * SMP, without previously sent patch
>
> SeaBIOS/gPXE load properly and Linux boots up over PXE with no problems.
>
> An attempt was made to port the board to KConfig, however this port is
> untested and may or may not function correctly.
>
> Signed-off-by: Timothy Pearson <[e-mail]>
>
> ---
>
> Re-sending as requested, this time WITH the patch attached! ;-)
>
> Timothy Pearson
> Raptor Engineering

Patch to add MSI MS-9652 support to CoreBoot

[ron minnich]

This looks fine to me, with a few nits which you might want to consider.

ms9652_fam10/cache_as_ram_auto.c

I would love to see that "cache_as_ram_auto.c" name go away. It has no
meaning. A common new name is
romstage.c

If you could consider this it would be better.

You might want to look at the cmos options file and make sure it makes
sense for your board. We've all gotten in the habit of copying other
boards --this file goes back 9 years :-)

Anyway, this stuff is fixable after a commit, so as far as I'm concerned this is

Acked-by: Ronald G. Minnich <[e-mail]>

If you are using this for a product, would you be willing to write a
little about your use of coreboot for the wiki? I'd like to start
highlighting "design wins" for coreboot. I had a discussion with a
vendor and I realized that we need to start making a more "business
oriented" presence on the web page, with providers and users of
coreboot highlighted. In other words, we need some shameless promotion
:-)

Thanks for the port!

ron

Patch to add MSI MS-9652 support to CoreBoot

[Patrick Georgi]

Am 12.02.2010 01:42, schrieb [e-mail]:
> Signed-off-by: Timothy Pearson <[e-mail]>
> Committed in r5180, with changes to make it fit with recent changes in
> the repository.

I'd be grateful if you could test the board with these changes and
report back (here, or IRC), so we know that this didn't break anything.

Thank you for sharing your work, it's much appreciated! (and for
listening to our complaints, newconfig/kconfig and all :-) )

Patrick