Re: [coreboot] r1056 - in coreboot-v3/arch/x86: . intel/core2

[Carl-Daniel Hailfinger]

On 26.11.2008 00:10, [e-mail] wrote:
> Author: stepan
> Date: 2008-11-26 00:10:24 +0100 (Wed, 26 Nov 2008)
> New Revision: 1056
>
> Modified:
>    coreboot-v3/arch/x86/Kconfig
>    coreboot-v3/arch/x86/intel/core2/stage0.S
> Log:
> hack to make v3 rom access a lot faster.
> Signed-off-by: Stefan Reinauer 
> Acked-by: Stefan Reinauer

This commit likely breaks support for some Core 2 processors (it will
make CAR fail due to random eviction of cache lines) and I believe it
was the reason why the tree didn't work anymore for Stefan.

Detailed explanation:
CAR is 32k cache. (unchanged)
XIP is 1024k cache. (new)
Cache types for both are the same. On a processor with 1024k cache (Core
2 Solo), this will cause CAR and XIP not to fit into the cache together.

Regards,
Carl-Daniel

r1056 - in coreboot-v3/arch/x86: . intel/core2

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> On 26.11.2008 00:10, [e-mail] wrote:
> > Author: stepan
> > Date: 2008-11-26 00:10:24 +0100 (Wed, 26 Nov 2008)
> > New Revision: 1056
> >
> > Modified:
> >    coreboot-v3/arch/x86/Kconfig
> >    coreboot-v3/arch/x86/intel/core2/stage0.S
> > Log:
> > hack to make v3 rom access a lot faster.
> > Signed-off-by: Stefan Reinauer 
> > Acked-by: Stefan Reinauer
>
> This commit likely breaks support for some Core 2 processors (it will
> make CAR fail due to random eviction of cache lines) and I believe it
> was the reason why the tree didn't work anymore for Stefan.

Interesting opinion, but that's not the case for me.