Re: [coreboot] r3536 - in trunk/coreboot-v2/src: include/device northbridge/intel/i3100 southbridge/intel/i3100

[Uwe Hermann]

On Mon, Aug 25, 2008 at 07:02:10PM +0200, [e-mail] wrote:
> Author: eswierk
> Date: 2008-08-25 19:02:09 +0200 (Mon, 25 Aug 2008)
> New Revision: 3536
>
> Modified:
>    trunk/coreboot-v2/src/include/device/pci_ids.h
>    trunk/coreboot-v2/src/northbridge/intel/i3100/pciexp_porta.c
>    trunk/coreboot-v2/src/southbridge/intel/i3100/i3100_sata.c
>    trunk/coreboot-v2/src/southbridge/intel/i3100/i3100_uhci.c
> Log:
> This patch adds PCI device IDs for the Intel EP80579 Integrated Processor,
> and renames some existing macros for clarity.
>
> Signed-off-by: Ed Swierk 
> Acked-by: Carl-Daniel Hailfinger
> Modified: trunk/coreboot-v2/src/southbridge/intel/i3100/i3100_sata.c
>
> --- trunk/coreboot-v2/src/southbridge/intel/i3100/i3100_sata.c	2008-08-25 14:45:00 UTC (rev 3535)
> +++ trunk/coreboot-v2/src/southbridge/intel/i3100/i3100_sata.c	2008-08-25 17:02:09 UTC (rev 3536)
> @@ -79,23 +79,23 @@
>  static struct pci_driver sata_driver __pci_driver = {

^^^^
   maybe make this ide_driver then?
> .ops    = &sata_ops,
>    .vendor = PCI_VENDOR_ID_INTEL,
> .device = PCI_DEVICE_ID_INTEL_3100_SATA,
> .device = PCI_DEVICE_ID_INTEL_3100_IDE,
>
> };
>
> static struct pci_driver sata_driver_nr __pci_driver = {

^^^^
             sata or ahci? I guess sata is fine though.
> .ops    = &sata_ops,
>    .vendor = PCI_VENDOR_ID_INTEL,
> .device = PCI_DEVICE_ID_INTEL_3100_SATA_R,
> .device = PCI_DEVICE_ID_INTEL_3100_AHCI,
>
> };
>
> static struct pci_driver sata_driver_ep80579 __pci_driver = {

^^^^
                            ide?
> .ops    = &sata_ops,
>    .vendor = PCI_VENDOR_ID_INTEL,
> .device = PCI_DEVICE_ID_INTEL_EP80579_SATA,
> .device = PCI_DEVICE_ID_INTEL_EP80579_IDE,
>
> };
>
> static struct pci_driver sata_driver_nr_ep80579 __pci_driver = {
>    .ops    = &sata_ops,
>    .vendor = PCI_VENDOR_ID_INTEL,
> .device = PCI_DEVICE_ID_INTEL_EP80579_SATA_R,
> .device = PCI_DEVICE_ID_INTEL_EP80579_AHCI,
>
> };
> Modified: trunk/coreboot-v2/src/southbridge/intel/i3100/i3100_uhci.c
>
> --- trunk/coreboot-v2/src/southbridge/intel/i3100/i3100_uhci.c	2008-08-25 14:45:00 UTC (rev 3535)
> +++ trunk/coreboot-v2/src/southbridge/intel/i3100/i3100_uhci.c	2008-08-25 17:02:09 UTC (rev 3536)
> @@ -52,17 +52,17 @@
>  static struct pci_driver uhci_driver __pci_driver = {
>    .ops    = &uhci_ops,
>    .vendor = PCI_VENDOR_ID_INTEL,
> .device = PCI_DEVICE_ID_INTEL_3100_USB,
> .device = PCI_DEVICE_ID_INTEL_3100_UHCI,
>
> };
>
> static struct pci_driver usb2_driver __pci_driver = {

^^^^
                     uhci2 for consistency?
> .ops    = &uhci_ops,
>    .vendor = PCI_VENDOR_ID_INTEL,
> .device = PCI_DEVICE_ID_INTEL_3100_USB2,
> .device = PCI_DEVICE_ID_INTEL_3100_UHCI2,
>
> };
>
> static struct pci_driver uhci_driver_ep80579 __pci_driver = {
>    .ops    = &uhci_ops,
>    .vendor = PCI_VENDOR_ID_INTEL,
> .device = PCI_DEVICE_ID_INTEL_EP80579_USB,
> .device = PCI_DEVICE_ID_INTEL_EP80579_UHCI,
>
> };

Uwe.