this is much closer. There are more functions to bring in before it will work at all.
ron
On 02.08.2008 23:04, ron minnich wrote:
this is much closer. There are more functions to bring in before it will work at all.
mcp55.c compiles. stage1.c does not. Nevertheless this is worth getting committed for others to see Signed-off-by: Ronald G. Minnich rminnich@gmail.com
I'm not entirely happy about the quality of the underlying code, but your patch is a real improvement.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel
On Sat, Aug 02, 2008 at 02:04:51PM -0700, ron minnich wrote:
Index: southbridge/nvidia/mcp55/stage1.c
--- southbridge/nvidia/mcp55/stage1.c (revision 713) +++ southbridge/nvidia/mcp55/stage1.c (working copy) @@ -19,6 +19,17 @@
- Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
+#include <console.h> +#include <io.h> +#include <device/device.h> +#include <device/pci.h>
+#include <device/pci_ids.h> +#include <device/pci_ops.h>
These two are not needed, pci.h already includes them.
-static uint32_t final_reg; +static u32 final_reg;
Is the static really needed or a romcc artifact?
Uwe.
On Sun, Aug 3, 2008 at 10:03 AM, Uwe Hermann uwe@hermann-uwe.de wrote:
On Sat, Aug 02, 2008 at 02:04:51PM -0700, ron minnich wrote:
Index: southbridge/nvidia/mcp55/stage1.c
--- southbridge/nvidia/mcp55/stage1.c (revision 713) +++ southbridge/nvidia/mcp55/stage1.c (working copy) @@ -19,6 +19,17 @@
- Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
+#include <console.h> +#include <io.h> +#include <device/device.h> +#include <device/pci.h>
+#include <device/pci_ids.h> +#include <device/pci_ops.h>
These two are not needed, pci.h already includes them.
fixed.
-static uint32_t final_reg; +static u32 final_reg;
Is the static really needed or a romcc artifact?
not needed, but a good idea in general.
Committed revision 716.
ron