Hi,
Please find the latest report on new defect(s) introduced to coreboot found with Coverity
Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build
analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1367555: Integer handling issues (INCOMPATIBLE_CAST)
________________________________________________________________________________________________________
*** CID 1367555: Integer handling issues (INCOMPATIBLE_CAST)
/dev/cb-build/coreboot-coverity.0/AMD_GARDENIA/agesa/PspBaseLib.c: 326 in
UpdataPspDirCheckSum()
320
321 VOID
322 UpdataPspDirCheckSum (
323 IN OUT PSP_DIRECTORY *PspDir
324 )
325 {
>> CID 1367555: Integer handling issues
(INCOMPATIBLE_CAST)
>> Pointer "&PspDir->Header.TotalEntries" points to an object
whose effective type is "unsigned long" (32 bits, unsigned) but is dereferenced
as a narrower "unsigned short" (16 bits, unsigned). This may lead to unexpected
results depending on machine endianness.
326 PspDir->Header.Checksum =
Fletcher32 ((UINT16 *) &PspDir->Header.TotalEntries, \
327 (sizeof (PSP_DIRECTORY_HEADER) - OFFSET_OF (PSP_DIRECTORY_HEADER,
TotalEntries) + PspDir->Header.TotalEntries * sizeof (PSP_DIRECTORY_ENTRY)) / 2);
328 }
329
330 /**
331 Check if PSP device is present
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…
To manage Coverity Scan email notifications for "coreboot(a)coreboot.org".org", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…