[PATCHes]more kconfig stuff

[Patrick Georgi]

Hi,

more kconfig patches:

20091007-2-kconfig-amd-socket-754
implements Kconfig support for AMDs Socket 754

20091007-3-kconfig-mcp55-romstrap
adds the romstrap include for MCP55 boards

20091007-4-kconfig-msi-boards
implements the remaining MSI boards.

Signed-off-by: Patrick Georgi

[Myles Watson]

On Wed, Oct 7, 2009 at 9:04 AM, Patrick Georgi  wrote:
> Hi,
>
> more kconfig patches:
>
> 20091007-2-kconfig-amd-socket-754
> implements Kconfig support for AMDs Socket 754
>
> 20091007-3-kconfig-mcp55-romstrap
> adds the romstrap include for MCP55 boards

Good find.
> 20091007-4-kconfig-msi-boards
> implements the remaining MSI boards.

===================================================================
--- src/mainboard/msi/ms7135/Makefile.inc	(Revision 0)
+++ src/mainboard/msi/ms7135/Makefile.inc	(Revision 0)
@@ -0,0 +1 @@
+include $(src)/mainboard/tyan/Makefile.s289x.inc

I like the reuse.  Maybe it's time to rename that file and move it
somewhere more general.
> Signed-off-by: Patrick Georgi

Acked-by: Myles Watson

Thanks,
Myles

[Peter Stuge]

Myles Watson wrote:
> +++ src/mainboard/msi/ms7135/Makefile.inc	(Revision 0)
> @@ -0,0 +1 @@
> +include $(src)/mainboard/tyan/Makefile.s289x.inc
>
> I like the reuse.

Indeed.
> Maybe it's time to rename that file and move it somewhere more
> general.

Makes sense. Now where to put it might be more tricky. It depends on
how generic the file is.

Maybe just add a top level mainboard_includes and use good filenames
in there?

//Peter

[Patrick Georgi]

Am Mittwoch, den 07.10.2009, 19:55 +0200 schrieb Peter Stuge:
> Makes sense. Now where to put it might be more tricky. It depends on
> how generic the file is.

The file is - strictly speaking - only suitable for ck804 boards.
There's a simple trick to clean this up, so I didn't bother too much
about it.
> Maybe just add a top level mainboard_includes and use good filenames
> in there?

Please don't put too much effort into placing these files
(Makefile.romccboard.inc, too) at the "right" location. If everything
works out, their content ends up - much more generic - in the top-level
Makefile.

I recorded some notes on the Kconfig wiki page.

Thanks,
Patrick

[Peter Stuge]

Patrick Georgi wrote:
> +++ src/mainboard/msi/ms7135/Kconfig	(Revision 0)
> @@ -0,0 +1,137 @@
> +config BOARD_MSI_MS7135
> bool "MS7135"

Do these board names have a dash? "MS-7135" ?
> +config MAINBOARD_DIR
> string
> default msi/ms7135
> depends on BOARD_MSI_MS7135

This is really sad. The directory name is already known, it's the one
where this Kconfig file is stored. It would be nice to just generate
this rather than risk humans introducing errors.
(And, the value might need quotes.)
> +++ src/mainboard/msi/ms9185/Kconfig	(Revision 0)
> @@ -0,0 +1,123 @@
> +config BOARD_MSI_MS9185
> bool "MS9185"

..
> +config MAINBOARD_PART_NUMBER
> string
> default "ultra40"
> depends on BOARD_MSI_MS9185

Oops.

Acked-by: Peter Stuge

[Patrick Georgi]

Am Mittwoch, den 07.10.2009, 19:53 +0200 schrieb Peter Stuge:
> > +config MAINBOARD_DIR
> > string
> > default msi/ms7135
> > depends on BOARD_MSI_MS7135
>
> This is really sad. The directory name is already known, it's the one
> where this Kconfig file is stored. It would be nice to just generate
> this rather than risk humans introducing errors.

Fortunately, it happens only once per board. But yes, I ran into it.

Unfortunately, it would be much more complicated to work without this
variable - we'd need a Makefile.inc per vendor that we can live without
for now, with lines like
subdir-$(CONFIG_BOARD_MSI_MS7135) += ms7135

So it really doesn't matter too much in my opinion.
> (And, the value might need quotes.)

Actually, if we strip the quotes everywhere, we can get rid of a shell
invocation in the top level Makefile.
> > +config MAINBOARD_PART_NUMBER
> > string
> > default "ultra40"
> > depends on BOARD_MSI_MS9185
>
> Oops.

Oops indeed. Fixed in r4737

[Uwe Hermann]

On Wed, Oct 07, 2009 at 08:08:15PM +0200, Patrick Georgi wrote:
> So it really doesn't matter too much in my opinion.

Yeah, I think it's not a big problem.
> > (And, the value might need quotes.)
>
> Actually, if we strip the quotes everywhere, we can get rid of a shell
> invocation in the top level Makefile.

I'm not sure we can or should strip them from all strings, some board
names contain spaces which would likely require using quotes.
I'd rather put _all_ strings in quotes for clarity and consistency.
And it's not like that one shell invokation will kill us.

Uwe.

[Peter Stuge]

Uwe Hermann wrote:
> > So it really doesn't matter too much in my opinion.
>
> Yeah, I think it's not a big problem.

I think it causes confusion and the duplication is really unneccessary.
I was hoping for info about how it is used (only in Kconfig, or also
in source?) to figure out where it would be best generated.
> > > (And, the value might need quotes.)
> >
> > Actually, if we strip the quotes everywhere, we can get rid of a
> > shell invocation in the top level Makefile.

How come?
> And it's not like that one shell invokation will kill us.

It's a nice optimization if doable.

//Peter