Re: [coreboot] ASUS KGPE-D16 Automated Test Failure [master]

[Kyösti Mälkki]

On Tue, Jul 19, 2016 at 8:55 PM, Aaron Durbin  wrote:
> Kyosti, this looks in the area of your recent patches.
>
> <snip>
> amdmct_cbmem_store_info: Storing AMDMCT configuration in CBMEM
> CBFS: 'Master Header Locator' located CBFS at [100100:1fffc0)
> CBFS: Locating 'cmos_layout.bin'
> CBFS: Checking offset 0
> CBFS: File @ offset 0 size 20
> CBFS:  Unmatched 'cbfs master header' at 0
> CBFS: Checking offset 80
> CBFS: File @ offset 80 size 297fc
> CBFS:  Unmatched 'normal/romstage' at 80
> CBFS: Checking offset 29900
> CBFS: File @ offset 29900 size 280
> CBFS:  Unmatched 'config' at 29900
> CBFS: Checking offset 29bc0
> CBFS: File @ offset 29bc0 size 24e
> CBFS:  Unmatched 'revision' at 29bc0
> CBFS: Checking offset 29e80
> CBFS: File @ offset 29e80 size 100
> CBFS:  Unmatched 'cmos.default' at 29e80
> CBFS: Checking offset 29fc0
> CBFS: File @ offset 29fc0 size e84
> CBFS: Found @ offset 29fc0 size e84
> disable_spd()
> prepare_romstage_ramstack: Prepare CAR migration and stack
> regions...memset_:  Fill [003f5400-003fffff]
> ...prepare_romstage_ramstack:  Done
> post_cache_as_ram: Copying data from cache to RAM...memcpy_:  Copy
> [000c2c00-000cd2bf] to [003f5940 - 003fffff] ...post_cache_as_ram:
> Done
> post_cache_as_ram: Verifying data integrity in RAM...memcmp_:  Compare
> [000c2c00-000cd2bf] with [003f5940 - 003fffff] ...post_cache_as_ram:
> Done
> post_cache_as_ram: Switching to use RAM as
> stack...cache_as_ram_new_stack: Disabling cache as ram now
> prepare_ramstage_region: Prepare ramstage memory region...memset_:
> Fill [00000000-003f53ff] ...

Thanks

The EARLY_CBMEM_INIT implementation for fam10 is borked. While it does
CAR migration, it forgets about doing so by resetting the flag later
on in romstage.
Details in review: https://review.coreboot.org/#/c/15752/

Kyösti