[PATCH] Inefficient test in buildtarget script

[Mats Erik Andersson]

Capture output from  'ld --help', in order that the test
becomes meaningful. The linker puts help texts on stderr.

Signed-off-by: Mats Erik Andersson 
---

Index: targets/buildtarget
===================================================================
--- targets/buildtarget	(revision 3531)
+++ targets/buildtarget	(arbetskopia)
@@ -69,7 +69,7 @@

rm -rf .$$.tmp

-if $CC -Wl,--help | grep -q build-id; then
+if $CC -Wl,--help 2>&1 | grep -q build-id; then
    EXTRA_LFLAGS="$EXTRA_LFLAGS -Wl,--build-id=none"
 fi

[Carl-Daniel Hailfinger]

Hi Mats,

I would commit this right away, but on my machine, the gcc/linker
combination doesn't output anything on stderr. Could you tell us the
output of
gcc -Wl,--version
gcc --version

I'll add that info to the script and commit.

On 27.08.2008 14:23, Mats Erik Andersson wrote:
> Capture output from  'ld --help', in order that the test
> becomes meaningful. The linker puts help texts on stderr.
>
> Signed-off-by: Mats Erik Andersson

Regards,
Carl-Daniel

[Stefan Reinauer]

I think think I saw this before.. Does the patch work with those  
versions of GCC/binutils that don't output to stderr?

Stefan

On 27.08.2008, at 14:50, Carl-Daniel Hailfinger <[e-mail]
> wrote:
> Hi Mats,
>
> I would commit this right away, but on my machine, the gcc/linker
> combination doesn't output anything on stderr. Could you tell us the
> output of
> gcc -Wl,--version
> gcc --version
>
> I'll add that info to the script and commit.
>
> On 27.08.2008 14:23, Mats Erik Andersson wrote:
> > Capture output from  'ld --help', in order that the test
> > becomes meaningful. The linker puts help texts on stderr.
> >
> > Signed-off-by: Mats Erik Andersson
>
> Regards,
> Carl-Daniel

[Carl-Daniel Hailfinger]

On 27.08.2008 14:59, Stefan Reinauer wrote:
> I think think I saw this before.. Does the patch work with those
> versions of GCC/binutils that don't output to stderr?

AFAICS yes. That's why I want to commit it.
However, someone may in the future see this line and ask why the stderr
redirection is there. For that, a comment will help tremendously.

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

On 27.08.2008 14:50, Carl-Daniel Hailfinger wrote:
> I would commit this right away, but on my machine, the gcc/linker
> combination doesn't output anything on stderr. Could you tell us the
> output of
> gcc -Wl,--version
> gcc --version
>
> I'll add that info to the script and commit.

Thanks for providing that info.
> On 27.08.2008 14:23, Mats Erik Andersson wrote:
> > Capture output from  'ld --help', in order that the test
> > becomes meaningful. The linker puts help texts on stderr.
> >
> > Signed-off-by: Mats Erik Andersson

Acked-by: Carl-Daniel Hailfinger

and committed in r3543.

Regards,
Carl-Daniel