Re: [coreboot] Patch set updated for coreboot: b0cd5ca Add AMD Family 10h PH-EO support

[Paul Menzel]

Am Mittwoch, den 14.09.2011, 14:12 +0800 schrieb QingPei Wang:
> the content of 010000bf.c comes from
>
> src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x10/RevE/F10MicrocodePatch010000bf.c
>
> but F10MicrocodePatch010000bf.c is used by amd agesa, could not be used
> directly. i
> port the code. just mentioned in the commit message that where is comes from

Thank you for the explanation. Please add such elaborate explanations to
the commit message. Mark Brown has a nice blog post about this [1].

Thanks,

Paul

[1] http://www.sirena.org.uk/log/2011/09/09/making-patches-easy-to-review/

Patch set updated for coreboot: b0cd5ca Add AMD Family 10h PH-EO support

[QingPei Wang]

thanks for your kindly suggestion.
the blog post is really useful for me.

Best wishes
QingPei Wang
Phone: 86+018930528086

On Wed, Sep 14, 2011 at 2:47 PM, Paul Menzel <
[e-mail]> wrote:
> Am Mittwoch, den 14.09.2011, 14:12 +0800 schrieb QingPei Wang:
> > the content of 010000bf.c comes from
>
> src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x10/RevE/F10MicrocodePatch010000bf.c
> > but F10MicrocodePatch010000bf.c is used by amd agesa, could not be used
> > directly. i
> > port the code. just mentioned in the commit message that where is comes
>
> from
>
> Thank you for the explanation. Please add such elaborate explanations to
> the commit message. Mark Brown has a nice blog post about this [1].
>
> Thanks,
>
> Paul
>
> [1] http://www.sirena.org.uk/log/2011/09/09/making-patches-easy-to-review/