Re: [LinuxBIOS] r2930 - in trunk/LinuxBIOSv2: src/mainboard/iwill/dk8s2 src/mainboard/iwill/dk8x targets/iwill targets/iwill/dk8x

[Peter Stuge]

On Fri, Nov 02, 2007 at 01:54:49PM +0100, [e-mail] wrote:
> fix up iwill board compilation. Untested, trivial

Great! :) Lovely to see all boards build again.
> From a quick look it seems the changes needed on these boards were

similar. Could you write a few lines about it? Like a changelog
message.. "fix" is not very informative. :\ (Yes, I could try to
understand the code.)

//Peter

[LinuxBIOS] r2930 - in trunk/LinuxBIOSv2: src/mainboard/iwill/dk8s2 src/mainboard/iwill/dk8x targets/iwill targets/iwill/dk8x

[Stefan Reinauer]

* Peter Stuge  [071103 02:38]:
> On Fri, Nov 02, 2007 at 01:54:49PM +0100, [e-mail] wrote:
> > fix up iwill board compilation. Untested, trivial
>
> Great! :) Lovely to see all boards build again.
>
> From a quick look it seems the changes needed on these boards were
> similar. Could you write a few lines about it? Like a changelog
> message.. "fix" is not very informative. :\ (Yes, I could try to
> understand the code.)

I will gladly take the time if someone is actually using those boards ;-)

Here's what I did:

I switched all those boards to use Cache As Ram. I copied the
cache_as_ram_auto.c (what a name!) from another board and adjusted 
the following settings:

* number of CPUs and
 * Addresses of SPD on i2c
 * SuperIO 
 * memreset functions

As a side note this was an interesting practice for v3. The above
settings are what distinguishes the K8 autobuilds.

So if we can abstract those properly, we can drop the requirement for
writing code to support a mainboard. (amongst other things that come
later, ACPI/PIRQ etc which should go to DTS anyways)

Stefan