Re: [coreboot] pci device memory allocation problem
On 25.04.2008 04:03, joe@settoplinux.org wrote:
I noticed this problem, if certian devices are disabled (like onboard vga for example). The other enabled devices try to use 0xfec00000 for memory allocation, causing APIC to fail.
You just need to add a Signed-Off-By as stated in the development guidelines. In the mean time I will test it and if all goes well you'll
get
my Acked-by, and then it can be commited.
Oh, I see.
Signed-off-by: Aaron Lwe <aaron.lwe@gmail.com>
Acked-by: Joseph Smith <joe@settoplinux.org>
Great job Aaron! Works great, attached is the bootlog with vga (device 2.0) completly disabled, and coreboot is not trying to allocate the 0xfec00000 range.
commited in r3265
Can you check whether this should be applied to the v3 code as well?
Assuming, device.c has the same functions as v2 it probibly should be applied. Can someone running v3 test the patch? -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org
I will try to test tomorrow night but be sure to remind me if I forget. ron
On Sun, 27 Apr 2008 21:55:35 -0700, "ron minnich" <rminnich@gmail.com> wrote:
I will try to test tomorrow night but be sure to remind me if I forget.
ron
You mean for v3 right? v2 was commited in r3265. -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org
On Mon, Apr 28, 2008 at 4:48 AM, Joe <joe@settoplinux.org> wrote:
On Sun, 27 Apr 2008 21:55:35 -0700, "ron minnich" <rminnich@gmail.com> wrote:
I will try to test tomorrow night but be sure to remind me if I forget.
ron
You mean for v3 right? v2 was commited in r3265.
yep, I hardly do v2 at all any more. ron
On Mon, Apr 28, 2008 at 4:48 AM, Joe <joe@settoplinux.org> wrote:
On Sun, 27 Apr 2008 21:55:35 -0700, "ron minnich" <rminnich@gmail.com> wrote:
I will try to test tomorrow night but be sure to remind me if I forget.
ron
You mean for v3 right? v2 was commited in r3265.
Tested on v3 and Committed revision 669.
On Mon, 28 Apr 2008 20:54:13 -0700, "ron minnich" <rminnich@gmail.com> wrote:
On Mon, Apr 28, 2008 at 4:48 AM, Joe <joe@settoplinux.org> wrote:
On Sun, 27 Apr 2008 21:55:35 -0700, "ron minnich" <rminnich@gmail.com> wrote:
I will try to test tomorrow night but be sure to remind me if I
forget.
ron
You mean for v3 right? v2 was commited in r3265.
Tested on v3 and Committed revision 669.
Good to hear :-) -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org
participants (3)
-
Joe -
joe@settoplinux.org -
ron minnich