Re: [LinuxBIOS] r2703 - in trunk/LinuxBIOSv2/src: include/device southbridge/intel/i82371eb

[Stefan Reinauer]

* [e-mail]  [070529 12:37]:
> #define PCI_DEVICE_ID_INTEL_82371AB	0x7111
>  #define PCI_DEVICE_ID_INTEL_82371AB_2	0x7112
>  #define PCI_DEVICE_ID_INTEL_82371AB_3	0x7113
> +#define PCI_DEVICE_ID_INTEL_82371AB_ISA		0x7110
> +#define PCI_DEVICE_ID_INTEL_82371AB_IDE		0x7111
> +#define PCI_DEVICE_ID_INTEL_82371AB_USB		0x7112
> +#define PCI_DEVICE_ID_INTEL_82371AB_ACPI	0x7113 /* Same as SMB */
> +#define PCI_DEVICE_ID_INTEL_82371AB_SMB		0x7113 /* Same as ACPI */

Can we drop the _2 and _3 above?

Also, we should start trying to stay in sync with v3 on such changes.

Stefan

[LinuxBIOS] r2703 - in trunk/LinuxBIOSv2/src: include/device southbridge/intel/i82371eb

[Uwe Hermann]

On Tue, May 29, 2007 at 05:39:20PM +0200, Stefan Reinauer wrote:
> [e-mail]  [070529 12:37]:
> > #define PCI_DEVICE_ID_INTEL_82371AB	0x7111
> >  #define PCI_DEVICE_ID_INTEL_82371AB_2	0x7112
> >  #define PCI_DEVICE_ID_INTEL_82371AB_3	0x7113
> > +#define PCI_DEVICE_ID_INTEL_82371AB_ISA		0x7110
> > +#define PCI_DEVICE_ID_INTEL_82371AB_IDE		0x7111
> > +#define PCI_DEVICE_ID_INTEL_82371AB_USB		0x7112
> > +#define PCI_DEVICE_ID_INTEL_82371AB_ACPI	0x7113 /* Same as SMB */
> > +#define PCI_DEVICE_ID_INTEL_82371AB_SMB		0x7113 /* Same as ACPI */
>
> Can we drop the _2 and _3 above?

Yep, done. They were not used anywhere, so trivial.
> Also, we should start trying to stay in sync with v3 on such changes.

As we don't track the full pci_ids.h from Linux in v3, but rather keep
our own small list of IDs, I think we should -- in general -- just copy over
those IDs which are really needed in v3.

For the 82371EB I'll post a patch which basically copies/merges the v2
code into the v3 version, together with the required IDs.

Another issue: in v3 we currently have i82371eb.c, a single file which
contains all init functions (IDE, USB, SMBus, etc). Do we want to keep
it that way, or split all of them up into extra files as in v2?
I sort of like the "one file" approach; as long as the file doesn't get
horribly large, I think it's ok.

Also, we should rename the southbridge to i82371xx, as it can (will) handle
the 82371AB/EB/MB with little or no changes; even the PCI IDs are the same.

Uwe.