[superiotool][PATCH] : fix W83977TF CR index value in ACPI LDN v3

[Noone Nowhere]

From: Ioannis Barkas  and Nikos Barkas

Index: util/superiotool/winbond.c
===================================================================
--- util/superiotool/winbond.c	(revision 4354)
+++ util/superiotool/winbond.c	(working copy)
@@ -285,7 +285,7 @@
    		 0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x00,EOT}},
    	{0xa, "ACPI",
    		{0x30,0x60,0x61,0x62,0x63,0x64,0x65,0x70,0xe0,0xe1,
-			 0x02,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
+			 0xe2,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
    		 0xf7,0xfe,0xff,EOT},
    		{0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
    		 NANA,MISC,RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,

Signed-off-by: Ioannis Barkas 
Signed-off-by: Nikos Barkas

---
More interesting things will be posted soon...
...but we will need at least one wiki account for sure this time at coreboot.org
(we have already contacted Stefan Reinauer and Ronald Minnich for an
account but got nothing after 2 e-mails quite some time ago...).

The patching procedure is undocumented:
How do you receive patches, from svn, from the mailiing list, or by
any other means?
How do we get an svn account or something similar.
If patches are received from the list, why on earth do we need to subscribe
to the list in order to contribute?

[Stefan Reinauer]

Hi, Noone,

On 12.06.2009 10:44 Uhr, Noone Nowhere wrote:
> The patching procedure is undocumented:
> How do you receive patches, from svn, from the mailiing list, or by
> any other means?

Before you ask for a Wiki account, you should make yourself familiar
with what is there:
http://www.coreboot.org/Development_Guidelines#How_to_contribute
> How do we get an svn account or something similar.

You "earn" it through permanent contributions. :-)
> If patches are received from the list, why on earth do we need to subscribe
> to the list in order to contribute?

You don't. But it helps.

Stefan

[superiotool][PATCH] : fix W83977TF CR index value in ACPI LDN v3

[ron minnich]

On Fri, Jun 12, 2009 at 1:44 AM, Noone Nowhere wrote:
> From: Ioannis Barkas  and Nikos Barkas
> Index: util/superiotool/winbond.c
>
> --- util/superiotool/winbond.c  (revision 4354)
> +++ util/superiotool/winbond.c  (working copy)
> @@ -285,7 +285,7 @@
>                         0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x00,EOT}},
>                {0xa, "ACPI",
>                        {0x30,0x60,0x61,0x62,0x63,0x64,0x65,0x70,0xe0,0xe1,
> 0x02,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
> 0xe2,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
>
> 0xf7,0xfe,0xff,EOT},
>                        {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
>                         NANA,MISC,RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
>
> Signed-off-by: Ioannis Barkas 
> Signed-off-by: Nikos Barkas  

anybody tested this patch?

It's a shame we could not help those guys in their search for validation :-)

ron

[superiotool][PATCH] : fix W83977TF CR index value in ACPI LDN v3

[Uwe Hermann]

On Mon, Jun 15, 2009 at 01:50:21PM -0700, ron minnich wrote:
> On Fri, Jun 12, 2009 at 1:44 AM, Noone Nowhere wrote:
> > From: Ioannis Barkas  and Nikos Barkas
> > Index: util/superiotool/winbond.c
> >
> > --- util/superiotool/winbond.c  (revision 4354)
> > +++ util/superiotool/winbond.c  (working copy)
> > @@ -285,7 +285,7 @@
> >                         0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x00,EOT}},
> >                {0xa, "ACPI",
> >                        {0x30,0x60,0x61,0x62,0x63,0x64,0x65,0x70,0xe0,0xe1,
> > 0x02,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
> > 0xe2,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
> >
> > 0xf7,0xfe,0xff,EOT},
> >                        {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
> >                         NANA,MISC,RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
> >
> > Signed-off-by: Ioannis Barkas 
> > Signed-off-by: Nikos Barkas  
>
> anybody tested this patch?

The patch is correct and I committed it. It's a simple typo.

Uwe.