patch: k8 support in v3.

[ron minnich]

I want to move fast on this. I have a few hours today and I want to
put them to getting code in. Let's make sure we get this in.

IF there are copyright issues, note it for the log and commit a patch
later. If there are formatting issues, ditto.

This almost builds. dts is not built, any idea why?  I could use help.
Anybody want to do the superio? Should be quick.

Let's get going. I will try to do at least one file per day until
we're there. But today, I ought to be able to get pretty far pretty
fast. Your support will help this happen.

ron

[Peter Stuge]

On Fri, Aug 01, 2008 at 09:07:26AM -0700, ron minnich wrote:
> This almost builds. dts is not built, any idea why?  I could use
> help.

Looking at it.
> Anybody want to do the superio? Should be quick.

What's needed here specifically?
> Your support will help this happen.

What about amdk8 vs amdfam10 ? Can we already do something clever?
(Yes, yes, let's get it working first. :p)

//Peter

[ron minnich]

On Fri, Aug 1, 2008 at 9:40 AM, Peter Stuge  wrote:
> On Fri, Aug 01, 2008 at 09:07:26AM -0700, ron minnich wrote:
> > This almost builds. dts is not built, any idea why?  I could use
> > help.
>
> Looking at it.
> > Anybody want to do the superio? Should be quick.
>
> What's needed here specifically?

This;

superio/ite/it8716f
> What about amdk8 vs amdfam10 ? Can we already do something clever?
> (Yes, yes, let's get it working first. :p)

note that the stage0.S is in arch/x86/amd, not amdk8. It supports fam10 and k8
ron

[Peter Stuge]

On Fri, Aug 01, 2008 at 09:07:26AM -0700, ron minnich wrote:
> This almost builds. dts is not built, any idea why?  I could use
> help.

Patch missing mainboard/gigabyte/Kconfig

//Peter

[Marc Jones]

ron minnich wrote:
...
> OK, this is it, beginnings of K8 support
>
> and some geode cleanup.
> fix some includes on geode.
>
> Index: arch/x86/geodelx/stage1.c
> Index: southbridge/amd/cs5536/stage1.c
> 2. add amd_k8.h include.

Seperate out the geode stuff. I think you can selfack it. They are 
trivial IMO. Here's an ack for the geode stuff anyway.

Acked-by: Marc Jones
> Index: arch/x86/Makefile
> Add K8 clauses
> Index: arch/x86/mtrr.h
> Index: include/arch/x86/amd_k8.h
> mv this to include, it is needed in several places now.
>
> K8 files: 
> Index: arch/x86/amdk8/stage1.c
> Index: arch/x86/amd/stage0.S
> Index: arch/x86/Kconfig
> Index: mainboard/gigabyte/m57sli/Makefile
> Index: mainboard/gigabyte/m57sli/dts
> Index: mainboard/gigabyte/m57sli/stage1.c
> Index: mainboard/gigabyte/m57sli/initram.c
> Index: mainboard/gigabyte/m57sli/Kconfig
> Index: mainboard/Kconfig
>
> The m57sli almost builds. It's pretty empty. The dtc is not run .
>
> Signed-off-by: Ronald G. Minnich

...
> -#endif				/* ARCH_X86_MTRR_H */
> Index: arch/x86/Makefile
> ===================================================================
> --- arch/x86/Makefile	(revision 699)
> +++ arch/x86/Makefile	(working copy)
> @@ -124,9 +124,12 @@
>    STAGE0_ARCH_X86_OBJ += geodelx/stage1.o
>    STAGE0_ARCH_X86_OBJ += ../../northbridge/amd/geodelx/geodelxinit.o
>  else
> STAGE0_CAR_OBJ = stage0_i586.o
>
> +ifeq ($(CONFIG_CPU_AMD_K8),y)
> STAGE0_CAR_OBJ = amd/stage0.o
> STAGE0_ARCH_X86_OBJ += amdk8/stage1.o
>
> endif
>  endif
> +endif

Add else and put the stage0_i586 on the end?

I agree with getting the pieces in place as we go.
The files looked fine to me but I didn't try to build it.....

Acked-by: Marc Jones

[Peter Stuge]

On Fri, Aug 01, 2008 at 10:50:28AM -0600, Marc Jones wrote:
> > OK, this is it, beginnings of K8 support
> >
> > and some geode cleanup.
> > fix some includes on geode.
> >
> > Index: arch/x86/geodelx/stage1.c
> > Index: southbridge/amd/cs5536/stage1.c
> > 2. add amd_k8.h include.
>
> Seperate out the geode stuff. I think you can selfack it. They are 
> trivial IMO.

I second this. Please commit this separately right away Ron.
> Here's an ack for the geode stuff anyway.
>
> Acked-by: Marc Jones

Acked-by: Peter Stuge

[ron minnich]

geode bits done rev 701

Committed revision 701.

[ron minnich]

On Fri, Aug 1, 2008 at 9:50 AM, Marc Jones  wrote:
> > -#endif                         /* ARCH_X86_MTRR_H */
> > Index: arch/x86/Makefile
> > ===================================================================
> > --- arch/x86/Makefile   (revision 699)
> > +++ arch/x86/Makefile   (working copy)
> > @@ -124,9 +124,12 @@
> >        STAGE0_ARCH_X86_OBJ += geodelx/stage1.o
> >        STAGE0_ARCH_X86_OBJ += ../../northbridge/amd/geodelx/geodelxinit.o
> >  else
> >   STAGE0_CAR_OBJ = stage0_i586.o
> >
> > +ifeq ($(CONFIG_CPU_AMD_K8),y)
> >   STAGE0_CAR_OBJ = amd/stage0.o
> >   STAGE0_ARCH_X86_OBJ += amdk8/stage1.o
> >
> > endif
> >  endif
> > +endif
>
> Add else and put the stage0_i586 on the end?

I took it out. There should be a valid value for the CPU. anything
else is an error. This mistake bit me so I don't want it getting
anyone else.
> I agree with getting the pieces in place as we go.
> The files looked fine to me but I didn't try to build it.....
>
> Acked-by: Marc Jones

Committed revision 702.

I added gigabyte/Kconfig per peter's note.

ron

[Peter Stuge]

On Fri, Aug 01, 2008 at 09:07:26AM -0700, ron minnich wrote:
> This almost builds.

I need the attached patch (sans the trivial cleanup hunk) in order to
build up to missing statictree.
> dts is not built, any idea why?

On it.

//Peter

[ron minnich]

On Fri, Aug 1, 2008 at 10:12 AM, Peter Stuge  wrote:
> On Fri, Aug 01, 2008 at 09:07:26AM -0700, ron minnich wrote:
> > This almost builds.
>
> I need the attached patch (sans the trivial cleanup hunk) in order to
> build up to missing statictree.

Acked-by: Ronald G. Minnich

Committed revision 703.