Re: [LinuxBIOS] s2881 build broken

[Lu, Yinghai]

I commit the fix up, please check it...

Thanks

Yinghai Lu

-----Original Message-----
From: [e-mail]
[mailto:[e-mail]] On Behalf Of Ward Vandewege
Sent: Wednesday, May 03, 2006 5:10 PM
To: Stefan Reinauer
Cc: [e-mail]
Subject: Re: [LinuxBIOS] s2881 build broken

On Thu, May 04, 2006 at 01:12:08AM +0200, Stefan Reinauer wrote:
> Ward Vandewege  [060504 00:39]:
> > Hi all,
> >
> > It seems that revision 2288 broke something in the tyan/s2881 build;

2289 and
> > 2290 are also bad. 2287 is ok.
> >
> > Boot log attached; it just keeps rebooting after the 'Jumping to

LinuxBIOS'
> > line. This is gcc 3.4.
> >
> > Suggestions?
>
> Yes, I suggest I owe you a beer next time we meet and you try 2291.

:) all right, will do so on Friday; not in the office tomorrow. I'll put
a
note on the s2881 build page that 2288 through 2290 are known bad.
> Yinghai Lu has sent a patch that is more complete but also more
> intrusive, which will go in later I guess. Until then this should work
> fine.
>
> This one is a good reason for automated testing on hardware.. 8)

Yes. I was thinking about that today while trying different revisions to
see
which one was the culprit. Would there be an easier way to do automated
testing than having lots of boxes with some sort of software switchable
BIOSsavior (actually, that would be a nice thing to have in any case)?
Emulation, perhaps?

Ward.

[LinuxBIOS] s2881 build broken

[Stefan Reinauer]

* Lu, Yinghai  [060504 03:06]:
> I commit the fix up, please check it...
>
> Thanks

Hey Yinghai!

Congratulations, after I broke operation, you broke compilation of the
complete tree ;-))

http://snapshots.linuxbios.org/stats/abuild-LinuxBIOSv2-2292.log

I fixed this in r2296 again.

For everyone who is doing checkins, as every one of us makes this
mistake one time or the other:

Please

- DO RUN abuild.sh BEFORE CHECKING IN! This will find the most stupid
    typos.

- If you change something in the cpu/amd/ tree that breaks compilation
    of the rest, do change it in the cpu/x86 part as well.

- Please check http://snapshots.linuxbios.org/ after checking in,
    whether your checkin is correct and flawless.

- If you make a commit, and it breaks compilation of _any_ mainboard
    that you are not explicitly working on _at the moment_, fix it
    within 2h. If this is not possible, revert the patch. 
    We might also set up a script that enforces this revertion, if
    people feel this helps.

Stefan

[LinuxBIOS] s2881 build broken

[yhlu]

You revert the ilen print out?

if you nrv2b one zelf image, you will get more bigger ilen instead...

YH

[LinuxBIOS] s2881 build broken

[Stefan Reinauer]

* yhlu  [060504 13:12]:
> You revert the ilen print out?

we could add that into the unrv2b() function, but I think we should not
change the API for debugging only.
> if you nrv2b one zelf image, you will get more bigger ilen instead...

Can we detect whether we're decompressing a zelf image and print a
message instead? or cause that the uncompressed version is used?

Stefan

[LinuxBIOS] s2881 build broken

[yhlu]

that will need another 4 byte header before the stream.

YH

On 5/4/06, Stefan Reinauer  wrote:
> yhlu  [060504 13:12]:
> > You revert the ilen print out?
>
> we could add that into the unrv2b() function, but I think we should not
> change the API for debugging only.
> > if you nrv2b one zelf image, you will get more bigger ilen instead...
>
> Can we detect whether we're decompressing a zelf image and print a
> message instead? or cause that the uncompressed version is used?
>
> Stefan