Re: [coreboot] [RFH] Please test current code on your devices before coreboot 4.6 release
Hi Persmule, I did some tests on thinkpad T430. I disabled SeaBios CONFIG_TCGBIOS and was able to communicate with TPM in GNU Linux, did a self test and took ownership. It doesn't report as temporarily deactivated any more.
It looks like SeaBIOS' TPM driver is broken, possible related to this fix: https://patchwork.kernel.org/patch/9191647/
Regards, Patrick
On Thu, 27 Apr 2017 21:53:07 +0800 persmule persmule@gmail.com wrote:
Hi Paul,
Today I found that on my thinkpad x230 (https://review.coreboot.org/cgit/board-status.git/tree/lenovo/x230/4.5-1640-...), TPM remains in deactivated state after boot, and there is no config menu item in seabios' menu, while my t420's (https://review.coreboot.org/cgit/board-status.git/tree/lenovo/t420/4.5-1640-...) TPM works fine. Their TPM Kconfig seem same.
Besides, I have also tried an OEM bios with ME cleansed just like my coreboot build on my x230, and TPM works fine on it.
It seems TPM init and activate code breaks a little on x230.
Persmule
在 2017年04月14日 07:48, Paul Menzel via coreboot 写道:
Dear coreboot folks,
coreboot 4.6 is planned to be released on Monday, so please take ten minutes, and build the current master branch for your board, flash it, boot it, and upload the status to the board status repository.
And if you notice a regression, please send a message to the list or create an issue in the issue tracker [1].
Currently it’s unknown if on Lenovo laptops [2], the TPM is still works, when TPM support is selected in Kconfig. Please note, that there were two regressions in the Linux Kernel, so that you should not use Linux 4.9 or the Linux 4.11 release candidates for testing.
If somebody tested the different QEMU targets that’d be great too.
Thanks,
Paul
[1] https://ticket.coreboot.org/ [2] https://review.coreboot.org/10411
Thanks Patrick,
Currently I have resolved this by using grub payload directly.
Persmule
在 2017年04月28日 00:54, Patrick Rudolph 写道:
Hi Persmule, I did some tests on thinkpad T430. I disabled SeaBios CONFIG_TCGBIOS and was able to communicate with TPM in GNU Linux, did a self test and took ownership. It doesn't report as temporarily deactivated any more.
It looks like SeaBIOS' TPM driver is broken, possible related to this fix: https://patchwork.kernel.org/patch/9191647/
Regards, Patrick
On Thu, 27 Apr 2017 21:53:07 +0800 persmule persmule@gmail.com wrote:
Hi Paul,
Today I found that on my thinkpad x230 (https://review.coreboot.org/cgit/board-status.git/tree/lenovo/x230/4.5-1640-...), TPM remains in deactivated state after boot, and there is no config menu item in seabios' menu, while my t420's (https://review.coreboot.org/cgit/board-status.git/tree/lenovo/t420/4.5-1640-...) TPM works fine. Their TPM Kconfig seem same.
Besides, I have also tried an OEM bios with ME cleansed just like my coreboot build on my x230, and TPM works fine on it.
It seems TPM init and activate code breaks a little on x230.
Persmule
在 2017年04月14日 07:48, Paul Menzel via coreboot 写道:
Dear coreboot folks,
coreboot 4.6 is planned to be released on Monday, so please take ten minutes, and build the current master branch for your board, flash it, boot it, and upload the status to the board status repository.
And if you notice a regression, please send a message to the list or create an issue in the issue tracker [1].
Currently it’s unknown if on Lenovo laptops [2], the TPM is still works, when TPM support is selected in Kconfig. Please note, that there were two regressions in the Linux Kernel, so that you should not use Linux 4.9 or the Linux 4.11 release candidates for testing.
If somebody tested the different QEMU targets that’d be great too.
Thanks,
Paul
[1] https://ticket.coreboot.org/ [2] https://review.coreboot.org/10411
-
Patrick Rudolph -
Persmule