New subject: Who can send Acked-by?

22 Sep 2008

This patch allows the dbm690t SIO to work. The changes affect the Asus 
a8n_e. Can someone with a a8n_e test this?
Thanks,
Marc
-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones@amd.com
http://www.amd.com/embeddedprocessors

The AMD dbm690t mainboard uses the it8712f SIO with the
default 48MHz clock input. The Asus a8n_e uses the it8712f
with a 24MHz clock input. The it8712f early init code was
setting a 24MHz input clock. Since 48Mhz is the default I added
a function to set 24MHz input clock to the a8n_e.

Signed-off-by: Marc Jones marc.jones@amd.com


Index: coreboot-v2/src/superio/ite/it8712f/it8712f_early_serial.c
===================================================================

--- coreboot-v2.orig/src/superio/ite/it8712f/it8712f_early_serial.c	2008-09-22 08:46:12.000000000 -0600
+++ coreboot-v2/src/superio/ite/it8712f/it8712f_early_serial.c	2008-09-22 14:17:44.000000000 -0600
@@ -45,10 +45,10 @@
    outb(value, SIO_DATA);
 }

-/* Enable the peripheral devices on the IT8712F Super I/O chip. */
-static void it8712f_enable_serial(device_t dev, unsigned iobase)
+
+static void it8712f_enter_conf(void)
 {
-	/* (1) Enter the configuration state (MB PnP mode). */
+	/*  Enter the configuration state (MB PnP mode). */

    /* Perform MB PnP setup to put the SIO chip at 0x2e. */
    /* Base address 0x2e: 0x87 0x01 0x55 0x55. */
@@ -57,6 +57,32 @@
    outb(0x01, IT8712F_CONFIGURATION_PORT);
    outb(0x55, IT8712F_CONFIGURATION_PORT);
    outb(0x55, IT8712F_CONFIGURATION_PORT);
+}
+
+static void it8712f_exit_conf(void)
+{
+	/* Exit the configuration state (MB PnP mode). */
+	it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CC, 0x02);
+}
+
+
+static void it8712f_24mhz_clkin(void)
+{
+	it8712f_enter_conf();
+
+	/* Select 24MHz CLKIN (48MHZ default)*/
+	it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x1);
+
+	it8712f_exit_conf();
+
+}
+
+/* Enable the peripheral devices on the IT8712F Super I/O chip. */
+static void it8712f_enable_serial(device_t dev, unsigned iobase)
+{
+
+	/* (1) Enter the configuration state (MB PnP mode). */
+	it8712f_enter_conf();

    /* (2) Modify the data of configuration registers. */

@@ -69,13 +95,9 @@
    it8712f_sio_write(IT8712F_SP1,  0x30, 0x1); /* Serial port 1 */
    it8712f_sio_write(IT8712F_SP2,  0x30, 0x1); /* Serial port 2 */

-	/* Select 24MHz CLKIN (set bit 0). */
-	it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01);
-
    /* Clear software suspend mode (clear bit 0). TODO: Needed? */
    /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */

    /* (3) Exit the configuration state (MB PnP mode). */
-	it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CC, 0x02);
+	it8712f_exit_conf();
 }
-
Index: coreboot-v2/src/mainboard/asus/a8n_e/cache_as_ram_auto.c
===================================================================
--- coreboot-v2.orig/src/mainboard/asus/a8n_e/cache_as_ram_auto.c	2008-09-22 09:28:13.000000000 -0600
+++ coreboot-v2/src/mainboard/asus/a8n_e/cache_as_ram_auto.c	2008-09-22 14:14:57.000000000 -0600
@@ -221,6 +221,7 @@
    	bsp_apicid = init_cpus(cpu_init_detectedx);
    }

+	it8712f_24mhz_clkin();
    it8712f_enable_serial(SERIAL_DEV, TTYS0_BASE);
    uart_init();
    console_init();

    

it8712f patch