[PATCH] flashrom: Enable SST49* protection register debug

[Uwe Hermann]

See patch.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

[PATCH] flashrom: Enable SST49* protection register debug

[Myles Watson]

On Thu, Jun 4, 2009 at 4:47 PM, Uwe Hermann <[e-mail]> wrote:
> See patch.
-		//printf("lockbits at address=0x%08lx is 0x%01x\n", (unsigned
long)0xFFC00000 - size + (i * 65536) + 2, *(bios + (i * 65536) + 2) );
+		printf("lockbits at address=%p is 0x%01x\n", (void *)(0xFFC00000 -
size + (i * 65536) + 2), chip_readb(bios + (i * 65536) + 2) );

You probably meant printf_debug there too.

-	//printf("lockbits at address=0x%08lx is 0x%01x\n", (unsigned
long)0xFFc00000 - size + address + 2, *(bios + address + 2) );
+	printf_debug("lockbits at address=%p is 0x%01x\n", (void
*)(0xFFc00000 - size + address + 2), chip_readb(bios + address + 2) );

I'd prefer 0xffc000 or 0xFFC000...

Acked-by: Myles Watson<[e-mail]>

Thanks,
Myles

[PATCH] flashrom: Enable SST49* protection register debug

[Uwe Hermann]

On Thu, Jun 04, 2009 at 04:56:07PM -0600, Myles Watson wrote:
> On Thu, Jun 4, 2009 at 4:47 PM, Uwe Hermann <[e-mail]> wrote:
> > See patch.
> -		//printf("lockbits at address=0x%08lx is 0x%01x\n", (unsigned
> long)0xFFC00000 - size + (i * 65536) + 2, *(bios + (i * 65536) + 2) );
> +		printf("lockbits at address=%p is 0x%01x\n", (void *)(0xFFC00000 -
> size + (i * 65536) + 2), chip_readb(bios + (i * 65536) + 2) );
> 
> You probably meant printf_debug there too.

True, fixed.

 
> -	//printf("lockbits at address=0x%08lx is 0x%01x\n", (unsigned
> long)0xFFc00000 - size + address + 2, *(bios + address + 2) );
> +	printf_debug("lockbits at address=%p is 0x%01x\n", (void
> *)(0xFFc00000 - size + address + 2), chip_readb(bios + address + 2) );
> 
> I'd prefer 0xffc000 or 0xFFC000...

Yep, fixed.

 
> Acked-by: Myles Watson<[e-mail]>

Thanks, r573 with some additional whitespace fixes.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org