Obvious bug in mcp55/pci.c

[Ronald Hoogenboom]

Hi,

I stumbled on an obvious error in a piece of code (v3) conditional on
CONFIG_PCI_64BIT_PREF_MEM. What is the exact purpose of this config and
why is it obviously never used? (doesn't even compile)

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Ronald Hoogenboom
> Sent: Tuesday, February 10, 2009 2:36 PM
> To: [e-mail]
> Subject: [coreboot] Obvious bug in mcp55/pci.c
>
> Hi,
>
> I stumbled on an obvious error in a piece of code (v3) conditional on
> CONFIG_PCI_64BIT_PREF_MEM. What is the exact purpose of this config and
> why is it obviously never used? (doesn't even compile)

It lets you allocate prefetchable memory resources above 4GB.  In v3 it
isn't used, but it has worked in v2, at least for some Tyan boards.  You can
compare the two.

v3 mcp55 support is a WIP.

Myles

[Carl-Daniel Hailfinger]

Hi Ronald,

if you add your Signed-off-by tag, I can commit this patch. While that
code may have other bugs to fix, your patch fixes at least one of them.

Regards,
Carl-Daniel

[Ronald Hoogenboom]

OK,

Signed-off-by: Ronald Hoogenboom

On Wed, 2009-02-11 at 12:58 +0100, Carl-Daniel Hailfinger wrote:
> Hi Ronald,
>
> if you add your Signed-off-by tag, I can commit this patch. While that
> code may have other bugs to fix, your patch fixes at least one of them.
>
> Regards,
> Carl-Daniel

[Carl-Daniel Hailfinger]

On 12.02.2009 21:54, Ronald Hoogenboom wrote:
> OK,
>
> Signed-off-by: Ronald Hoogenboom

Acked-by: Carl-Daniel Hailfinger

Thanks, r1132.

Regards,
Carl-Daniel