Can we please remove the FSP TempRamInit option (where applicable)

[Nico Huber]

Hi coreboot fellows,

I have always been confused that we have the option to use FSP's
TempRamInit (CAR setup) even when a native coreboot implementation is
available. Now, what I'm really concerned about is the low quality of
the code in coreboot surrounding it. There are often Kconfig prompts
that don't add up, and about every related, merged commit I've been
looking at today seemed somehow flawed.

So if we can't keep the quality we are used to when trying to maintain
two (or even more) CAR options, why not focus on a single one? After
all, coreboot is a firmware framework, not an FSP testing framework.

Here's just one weird example of what I was confronted with today:

default USE_CANNONLAKE_CAR_NEM_ENHANCED if
MAINBOARD_HAS_CHROMEOS

I don't understand it, but somehow feel offended. Does that mean I have
to work with ChromeOS now to get reasonable defaults?

Nico

[Lance Zhao]

Yes, I believe we should let mainboard to select CAR implementation instead
of force selection in soc Kconfig. I will suggest to remove that line.

On Tue, Nov 6, 2018 at 10:12 AM Nico Huber  wrote:
> Hi coreboot fellows,
>
> I have always been confused that we have the option to use FSP's
> TempRamInit (CAR setup) even when a native coreboot implementation is
> available. Now, what I'm really concerned about is the low quality of
> the code in coreboot surrounding it. There are often Kconfig prompts
> that don't add up, and about every related, merged commit I've been
> looking at today seemed somehow flawed.
>
> So if we can't keep the quality we are used to when trying to maintain
> two (or even more) CAR options, why not focus on a single one? After
> all, coreboot is a firmware framework, not an FSP testing framework.
>
> Here's just one weird example of what I was confronted with today:
>     default USE_CANNONLAKE_CAR_NEM_ENHANCED if
>
> MAINBOARD_HAS_CHROMEOS
>
> I don't understand it, but somehow feel offended. Does that mean I have
> to work with ChromeOS now to get reasonable defaults?
>
> Nico