See patch.
This also changes libpayload to put all *.o files into build/ as our other stuff also does (i.e. not have *.o files in the src dir).
On a related note, here's a quick overview of all our kconfig copies:
- coreinfo: RECENT (03/2008) - buildrom: RECENT (03/2008) - coreboot-v3: OLD (02/2006) - libpayload: OLD (???) (but this patch brings it to the state of 03/2008)
I'll prepare a patch for v3 also, then we have all our kconfigs at a reasonably up-to-date state and at the _same_ state for all our projects.
Did I forget some other kconfig copy we use?
Uwe.
Update against latest libpayload so there aren't conflicts.
On Thu, Aug 07, 2008 at 06:11:06PM +0200, Uwe Hermann wrote:
See patch.
This also changes libpayload to put all *.o files into build/ as our other stuff also does (i.e. not have *.o files in the src dir).
On a related note, here's a quick overview of all our kconfig copies:
- coreinfo: RECENT (03/2008)
- buildrom: RECENT (03/2008)
- coreboot-v3: OLD (02/2006)
- libpayload: OLD (???) (but this patch brings it to the state of 03/2008)
I'll prepare a patch for v3 also, then we have all our kconfigs at a reasonably up-to-date state and at the _same_ state for all our projects.
Did I forget some other kconfig copy we use?
Uwe.
Uwe Hermann wrote:
See patch.
This also changes libpayload to put all *.o files into build/ as our other stuff also does (i.e. not have *.o files in the src dir).
On a related note, here's a quick overview of all our kconfig copies:
- coreinfo: RECENT (03/2008)
- buildrom: RECENT (03/2008)
- coreboot-v3: OLD (02/2006)
- libpayload: OLD (???) (but this patch brings it to the state of 03/2008)
I'll prepare a patch for v3 also, then we have all our kconfigs at a reasonably up-to-date state and at the _same_ state for all our projects.
The v3 version was heavily adapted and it does work nice in cross compile environments already. Are you sure there is a benefit of updating it? Anything reproducable?
For your libpayload patch: Acked-by: Stefan Reinauer stepan@coresystems.de
Stefan
The v3 version was heavily adapted and it does work nice in cross compile environments already. Are you sure there is a benefit of updating it?
The benefit of frequently updating to new versions of foreign code is that when you don't, you will have a really hard time updating later when you _do_ want some new feature. If you do update, you also get bug fixes for bugs that you do not (yet!) run into yourself, etc. It saves a lot of work. Frequent back-merges are easy, trying to do one after a few years can often be almost impossible.
If you don't keep track of foreign code, you'll find yourself maintaining a fork of that foreign code, at which point it might have been better to just write the whole code from scratch.
Segher
On Thu, Aug 07, 2008 at 07:52:08PM +0200, Stefan Reinauer wrote:
Uwe Hermann wrote:
See patch.
This also changes libpayload to put all *.o files into build/ as our other stuff also does (i.e. not have *.o files in the src dir).
On a related note, here's a quick overview of all our kconfig copies:
- coreinfo: RECENT (03/2008)
- buildrom: RECENT (03/2008)
- coreboot-v3: OLD (02/2006)
- libpayload: OLD (???) (but this patch brings it to the state of 03/2008)
I'll prepare a patch for v3 also, then we have all our kconfigs at a reasonably up-to-date state and at the _same_ state for all our projects.
The v3 version was heavily adapted and it does work nice in cross compile environments already. Are you sure there is a benefit of updating it? Anything reproducable?
Nothing major that I personally have run into, but I'm with Segher here, we want a recent snapshot of kconfig (and equally important: I think we also want all out subprojects to at least use the _same_ snapshot, so if we need to modify/fix one of our kcofigs we can easily port the fix to all our copies).
I'll be careful to preserve all customizations in v3's kconfig, and I'll post the patch for review/testing of course...
For your libpayload patch: Acked-by: Stefan Reinauer stepan@coresystems.de
Thanks, r3482.
Uwe.
On Fri, Aug 08, 2008 at 10:03:25AM +0200, Uwe Hermann wrote:
preserve all customizations in v3's kconfig
What are these? It would be interesting to see a diff.
//Peter
Peter Stuge wrote:
On Fri, Aug 08, 2008 at 10:03:25AM +0200, Uwe Hermann wrote:
preserve all customizations in v3's kconfig
What are these? It would be interesting to see a diff.
The code is the same. But the makefile has been rewritten from scratch
Stefan
-
Peter Stuge -
Segher Boessenkool -
Stefan Reinauer -
Uwe Hermann