Dear coreboot readers!
This is the automatic build system of coreboot.
The developer "hailfinger" checked in revision 4341 to the coreboot repository. This caused the following changes:
Change Log: K8 RAM init debug messages are pretty short and sometimes cryptic. Make them a bit more verbose and hopefully more understandable.
Old messages for my machine with 5 GB: RAM: 0x00400000 kB Ram3 [...] Initializing memory: done RAM: 0x00500000 kB
New messages: RAM end at 0x00400000 kB Adjusting lower RAM end Lower RAM end at 0x003f0000 kB Ram3 [...] Initializing memory: done Handling memory hole at 0x00300000 (default) RAM end at 0x00500000 kB Handling memory mapped above 4 GB Upper RAM end at 0x00500000 kB Correcting memory amount mapped below 4 GB Adjusting lower RAM end Lower RAM end at 0x00300000 kB
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net Acked-by: Myles Watson mylesgw@gmail.com
Build Log: Compilation of arima:hdama has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=hdama&v... Compilation of asus:a8n_e has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=a8n_e&v... Compilation of asus:a8v-e_se has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=a8v-e_se&am... Compilation of broadcom:blast has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=blast&v... Compilation of ibm:e325 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=e325&ve... Compilation of ibm:e326 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=e326&ve... Compilation of iwill:dk8_htx has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=dk8_htx&... Compilation of iwill:dk8s2 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=dk8s2&v... Compilation of iwill:dk8x has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=dk8x&ve... Compilation of msi:ms7135 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=ms7135&... Compilation of newisys:khepri has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=khepri&... Compilation of sunw:ultra40 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=ultra40&... Compilation of tyan:s2850 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2850&v... Compilation of tyan:s2875 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2875&v... Compilation of tyan:s2880 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2880&v... Compilation of tyan:s2881 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2881&v... Compilation of tyan:s2882 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2882&v... Compilation of tyan:s2885 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2885&v... Compilation of tyan:s2891 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2891&v... Compilation of tyan:s2892 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2892&v... Compilation of tyan:s2895 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s2895&v... Compilation of tyan:s4880 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s4880&v... Compilation of tyan:s4882 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4341&device=s4882&v...
If something broke during this checkin please be a pain in hailfinger's neck until the issue is fixed.
If this issue is not fixed within 24h the revision should be backed out.
Best regards, coreboot automatic build system
On 05.06.2009 22:57, coreboot information wrote:
The developer "hailfinger" checked in revision 4341
Change Log: K8 RAM init debug messages are pretty short and sometimes cryptic. Make them a bit more verbose and hopefully more understandable.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net Acked-by: Myles Watson mylesgw@gmail.com
[Broken compilation] arima:hdama asus:a8n_e asus:a8v-e_se broadcom:blast ibm:e325 ibm:e326 iwill:dk8_htx iwill:dk8s2 iwill:dk8x msi:ms7135 newisys:khepri sunw:ultra40 tyan:s2850 tyan:s2875 tyan:s2880 tyan:s2881 tyan:s2882 tyan:s2885 tyan:s2891 tyan:s2892 tyan:s2895 tyan:s4880 tyan:s4882
Sorry. It seems I overlooked these during my abuild run. Basically, all non-revF K8 are broken because printk_raminit is not defined. I'll send a fixup.
Regards, Carl-Daniel
On 05.06.2009 23:06, Carl-Daniel Hailfinger wrote:
Sorry. It seems I overlooked these during my abuild run. Basically, all non-revF K8 are broken because printk_raminit is not defined.
Fix non-revF K8 ram init compilation which was broken in r4341.
abuild tested on affected targets.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Index: LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c =================================================================== --- LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c (Revision 4341) +++ LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c (Arbeitskopie) @@ -19,6 +19,14 @@ #define QRANK_DIMM_SUPPORT 0 #endif
+#define RAM_TIMING_DEBUG 0 + +#if RAM_TIMING_DEBUG == 1 +#define printk_raminit printk_debug +#else +#define printk_raminit(fmt, arg...) +#endif + #if defined (__GNUC__) static void hard_reset(void); #endif @@ -2106,7 +2114,7 @@ return; hw_spd_err: /* Unrecoverable error reading SPD data */ - print_err("SPD error - reset\n"); + printk_err("SPD error - reset\n"); hard_reset(); return; }
On Fri, Jun 5, 2009 at 3:54 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
On 05.06.2009 23:06, Carl-Daniel Hailfinger wrote:
Sorry. It seems I overlooked these during my abuild run. Basically, all non-revF K8 are broken because printk_raminit is not defined.
Fix non-revF K8 ram init compilation which was broken in r4341.
I'd prefer to fix it by changing all printk_raminit -> printk_spew. I'm sorry I didn't catch that.
I don't like the idea of adding more #defines and #if segments.
Thanks, Myles
On 06.06.2009 00:03, Myles Watson wrote:
On Fri, Jun 5, 2009 at 3:54 PM, Carl-Daniel Hailfinger wrote:
Fix non-revF K8 ram init compilation which was broken in r4341.
I'd prefer to fix it by changing all printk_raminit -> printk_spew.
Done.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Index: LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c =================================================================== --- LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c (Revision 4341) +++ LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c (Arbeitskopie) @@ -855,12 +855,12 @@ /* Now set top of memory */ msr_t msr; if (tom_k > (4*1024*1024)) { - printk_raminit("Handling memory mapped above 4 GB\n"); - printk_raminit("Upper RAM end at 0x%08x kB\n", tom_k); + printk_spew("Handling memory mapped above 4 GB\n"); + printk_spew("Upper RAM end at 0x%08x kB\n", tom_k); msr.lo = (tom_k & 0x003fffff) << 10; msr.hi = (tom_k & 0xffc00000) >> 22; wrmsr(TOP_MEM2, msr); - printk_raminit("Correcting memory amount mapped below 4 GB\n"); + printk_spew("Correcting memory amount mapped below 4 GB\n"); }
/* Leave a 64M hole between TOP_MEM and TOP_MEM2 @@ -873,9 +873,9 @@ } else #endif tom_k = 0x3f0000; - printk_raminit("Adjusting lower RAM end\n"); + printk_spew("Adjusting lower RAM end\n"); } - printk_raminit("Lower RAM end at 0x%08x kB\n", tom_k); + printk_spew("Lower RAM end at 0x%08x kB\n", tom_k); msr.lo = (tom_k & 0x003fffff) << 10; msr.hi = (tom_k & 0xffc00000) >> 22; wrmsr(TOP_MEM, msr); @@ -2106,7 +2106,7 @@ return; hw_spd_err: /* Unrecoverable error reading SPD data */ - print_err("SPD error - reset\n"); + printk_err("SPD error - reset\n"); hard_reset(); return; } @@ -2172,7 +2172,7 @@
hole_startk = 4*1024*1024 - HW_MEM_HOLE_SIZEK;
- printk_raminit("Handling memory hole at 0x%08x (default)\n", hole_startk); + printk_spew("Handling memory hole at 0x%08x (default)\n", hole_startk); #if HW_MEM_HOLE_SIZE_AUTO_INC == 1 /* We need to double check if hole_startk is valid. * If it is equal to the dram base address in K (base_k), @@ -2197,7 +2197,7 @@ basek_pri = base_k; }
- printk_raminit("Handling memory hole at 0x%08x (adjusted)\n", hole_startk); + printk_spew("Handling memory hole at 0x%08x (adjusted)\n", hole_startk); #endif /* Find node number that needs the memory hole configured */ for (i=0; i<controllers; i++) {
-----Original Message----- From: Carl-Daniel Hailfinger [mailto:c-d.hailfinger.devel.2006@gmx.net] Sent: Friday, June 05, 2009 5:06 PM To: Myles Watson Cc: coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] Fix non-revF K8 ram init compilation
On 06.06.2009 00:03, Myles Watson wrote:
On Fri, Jun 5, 2009 at 3:54 PM, Carl-Daniel Hailfinger wrote:
Fix non-revF K8 ram init compilation which was broken in r4341.
I'd prefer to fix it by changing all printk_raminit -> printk_spew.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Acked-by: Myles Watson mylesgw@gmail.com
Thanks, Myles
On 06.06.2009 01:35, Myles Watson wrote:
Carl-Daniel Hailfinger wrote:
On 06.06.2009 00:03, Myles Watson wrote:
On Fri, Jun 5, 2009 at 3:54 PM, Carl-Daniel Hailfinger wrote:
Fix non-revF K8 ram init compilation which was broken in r4341.
I'd prefer to fix it by changing all printk_raminit -> printk_spew.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Acked-by: Myles Watson mylesgw@gmail.com
Thanks, committed in r4343.
Regards, Carl-Daniel
-
Carl-Daniel Hailfinger -
coreboot information -
Myles Watson