[LinuxBIOS] #40: Decide on common header #ifndef names or standards for usage

[LinuxBIOS]

      #40: Decide on common header #ifndef names or standards for usage
-----------------------------+----------------------------------------------
     Reporter:  uwe          |          Owner:  uwe              
         Type:  enhancement  |         Status:  new              
     Priority:  minor        |      Milestone:  Cosmetic fixes   
    Component:  code         |        Version:  v2               
     Keywords:               |      Due_close:  MM/DD/YYYY       
Include_gantt:  0            |   Dependencies:                   
   Due_assign:  MM/DD/YYYY   |    Patchstatus:  there is no patch
-----------------------------+----------------------------------------------
 We have lots of variations for "include guards" in the code:

 {{{
 _FOO
 _FOO_H
 __FOO_H
 __FOO_H__
 _FOO_H_
 __FOO_DEFINED
 ...
 }}}

 Is there a special convention or agreement on when to use which? If yes,
 it should be documented. If no, we should standardize on one format and
 use it consistently.

-- 
Ticket URL: <http://tracker.linuxbios.org/trac/LinuxBIOS/ticket/40>
LinuxBIOS <http://www.linuxbios.org/>

[LinuxBIOS]

      #40: Decide on common header #ifndef names or standards for usage
----------------------------+-----------------------------------------------
    Reporter:  uwe          |         Owner:  uwe              
        Type:  enhancement  |        Status:  new              
    Priority:  minor        |     Milestone:  Cosmetic fixes   
   Component:  code         |       Version:  v2               
  Resolution:               |      Keywords:                   
Dependencies:               |   Patchstatus:  there is no patch
----------------------------+-----------------------------------------------
Comment (by Jon Dufresne <jon.dufresne(a)gmail.com>):

 If someone with some authority decides on the convention I'd be happy to
 submit a patch to fix it.

-- 
Ticket URL: <http://tracker.linuxbios.org/trac/LinuxBIOS/ticket/40#comment:1>
LinuxBIOS <http://www.linuxbios.org/>

[LinuxBIOS]

      #40: Decide on common header #ifndef names or standards for usage
----------------------------+-----------------------------------------------
    Reporter:  uwe          |         Owner:  uwe              
        Type:  enhancement  |        Status:  new              
    Priority:  minor        |     Milestone:  Cosmetic fixes   
   Component:  code         |       Version:  v2               
  Resolution:               |      Keywords:                   
Dependencies:               |   Patchstatus:  there is no patch
----------------------------+-----------------------------------------------
Comment (by anonymous):

 [http://www.makegamegold.com World Of Warcraftwow
 gold][http://www.makegamegold.com/article.asp?id=82 gold
 wow][http://www.makegamegold.com/default.asp?cateid=6 wow gold]

-- 
Ticket URL: <http://tracker.linuxbios.org/trac/LinuxBIOS/ticket/40#comment:2>
LinuxBIOS <http://www.linuxbios.org/>

[LinuxBIOS]

      #40: Decide on common header #ifndef names or standards for usage
----------------------------+-----------------------------------------------
    Reporter:  uwe          |         Owner:  uwe                     
        Type:  enhancement  |        Status:  closed                  
    Priority:  minor        |     Milestone:  Cosmetic fixes          
   Component:  code         |       Version:  v3                      
  Resolution:  fixed        |      Keywords:                          
Dependencies:               |   Patchstatus:  patch has been committed
----------------------------+-----------------------------------------------
Changes (by uwe):

  * status:  new => closed
  * patchstatus:  there is no patch => patch has been committed
  * resolution:  => fixed
  * version:  v2 => v3

Comment:

 Fixed in r332 in LinuxBIOSv3.

-- 
Ticket URL: <http://tracker.linuxbios.org/trac/LinuxBIOS/ticket/40#comment:2>
LinuxBIOS <http://www.linuxbios.org/>