Re: [coreboot] [v3] r1162 - coreboot-v3/northbridge/intel/i440bxemulation

[Carl-Daniel Hailfinger]

On 24.03.2009 00:55, [e-mail] wrote:
> Author: rminnich
> Date: 2009-03-24 00:55:58 +0100 (Tue, 24 Mar 2009)
> New Revision: 1162
>
> Modified:
>    coreboot-v3/northbridge/intel/i440bxemulation/i440bx.c
> Log:
> This is an emergency fix for building for qemu.
>
> With this fix, FILO works.

This was already fixed with a weak function since r1161.

Changelog was:

Emergency fixup for the missing is_coldboot().

Note that the weak is_coldboot() returns always 1.
The i945 is_coldboot() returns 1 for a warm boot?

Regards,
Carl-Daniel

[v3] r1162 - coreboot-v3/northbridge/intel/i440bxemulation

[ron minnich]

On Tue, Mar 24, 2009 at 6:06 AM, Carl-Daniel Hailfinger
 wrote:
> Emergency fixup for the missing is_coldboot().

overusing weak functions is a danger, I think. Every chipset or cpu
should have a way to tell if the CPU is doing a coldboot. It is a bit
dangerous for us to become too reliant on weak symbols.
> Note that the weak is_coldboot() returns always 1.
> The i945 is_coldboot() returns 1 for a warm boot?

well, that's a mistake if so.

ron

[v3] r1162 - coreboot-v3/northbridge/intel/i440bxemulation

[Mart Raudsepp]

Ühel kenal päeval, T, 2009-03-24 kell 07:22, kirjutas ron minnich:
> On Tue, Mar 24, 2009 at 6:06 AM, Carl-Daniel Hailfinger
>  wrote:
> > Emergency fixup for the missing is_coldboot().
>
> overusing weak functions is a danger, I think. Every chipset or cpu
> should have a way to tell if the CPU is doing a coldboot. It is a bit
> dangerous for us to become too reliant on weak symbols.

Many CPU's don't need to do anything different on a coldboot vs hotboot
it seems like. Requiring all CPU's to start adding is_coldboot functions
that return a completely fake return value (as if it would always
coldboot, which surely isn't the case in reality) is not so good of an
idea either.

What's sure is that qemu is not special here to get an is_coldboot()
function while other boards don't and therefore rely on the weak symbol.

So r1162 should be reverted or r1161 reverted after addition of
is_coldboot() to all of the many necessary places.
I definitely prefer the former.
> > Note that the weak is_coldboot() returns always 1.
> > The i945 is_coldboot() returns 1 for a warm boot?
>
> well, that's a mistake if so.

Lets fix it then? :)

Regards,
Mart Raudsepp

[v3] r1162 - coreboot-v3/northbridge/intel/i440bxemulation

[ron minnich]

On Thu, Apr 2, 2009 at 2:42 AM, Mart Raudsepp
 wrote:
> So r1162 should be reverted or r1161 reverted after addition of
> is_coldboot() to all of the many necessary places.
> I definitely prefer the former.

Go ahead and do that in a way that works for you, I'll ack it.

thanks

ron