[LinuxBIOS] [BUILDROM] Some fixes

[Jordan Crouse]

A few fixes before my v3 patch - this cleans up the menuconfig to be
a little bit more clear, and fixes a spurious variable that I removed
behind Ward's back.

Jordan

[Ward Vandewege]

On Thu, Dec 06, 2007 at 03:34:53PM -0700, Jordan Crouse wrote:
> A few fixes before my v3 patch - this cleans up the menuconfig to be
> a little bit more clear, and fixes a spurious variable that I removed
> behind Ward's back.

Heh :) I saw that warning late last night but hadn't looked into it yet.
> Remove a spurious variable from the GPXE stuff, rearrange the menu
> a little bit, and switch the Make jobs to an integer to make it
> easier to understand and use.

Wouldn't it be more standard to just allow the use of -jX on the command
line?
> Signed-off-by: Jordan Crouse

Acked-by: Ward Vandewege

Thanks,
Ward.

[LinuxBIOS] Some fixes

[Jordan Crouse]

On 06/12/07 17:40 -0500, Ward Vandewege wrote:
> On Thu, Dec 06, 2007 at 03:34:53PM -0700, Jordan Crouse wrote:
> > A few fixes before my v3 patch - this cleans up the menuconfig to be
> > a little bit more clear, and fixes a spurious variable that I removed
> > behind Ward's back.

Gah - I never committed this, because I had been meaning to comment:
> Wouldn't it be more standard to just allow the use of -jX on the command
> line?

Sort of - the problem is that -jX doesn't really make any sense for
buildrom itself (maybe a little for the LAB folks), and not all of the
sub projects can handle it.  So I think its better if buildrom handles
this smartly for those projects that can understand it.

Jordan
> > Signed-off-by: Jordan Crouse
>
> Acked-by: Ward Vandewege

r82.  Is there anything else I've left on the floor?

Jordan

[Myles Watson]

> [BUILDROM] Some fixes
>
> Remove a spurious variable from the GPXE stuff, rearrange the menu
> a little bit, and switch the Make jobs to an integer to make it
> easier to understand and use.
>
> Signed-off-by: Jordan Crouse

It works for me.
Acked-by: Myles Watson

[Paul Menzel]

Am Donnerstag, den 06.12.2007, 15:34 -0700 schrieb Jordan Crouse:
> +menu "Build Options"
>
> +config VERBOSE
>   bool "See the build output on stdout"
>   default n
>   help
>     See the entire build output on stdout. Otherwise, it will
>     be saved off in a series of logs

Could you add a dot at the end of the line?
> +config MAKE_JOBS
>   int "Number of make jobs to run simultaneously (experimental)"
>   default 1
>   help
>     This can speed the build if you have more than one core that you

s/speed/speed up/ ?
>     would like to allow make to use.  If you have a single processor, use
>     the default (1) otherwise, you can specify the number of cores you
>     have plus 1 (for example, specify 5 if you have 4 cores).
>     This option is currently used for the kernel and uClibc packages.
>
> +endmenu

Thanks,

Paul