Unused files

[Stefan Reinauer]

These include files are unused, they are never included

src/cpu/amd/model_10xxx/mc_patch_01000020.h
src/cpu/amd/model_10xxx/mc_patch_01000083.h
src/cpu/amd/model_10xxx/mc_patch_01000084.h
src/cpu/intel/model_f1x/multiplier.h
src/cpu/intel/model_f0x/multiplier.h
src/southbridge/amd/cs5536/smbus2.h

I vote for dropping them.

Stefan

[Marc Jones]

On Wed, Jan 12, 2011 at 12:39 PM, Stefan Reinauer  wrote:
> These include files are unused, they are never included
>
> src/cpu/amd/model_10xxx/mc_patch_01000020.h
> src/cpu/amd/model_10xxx/mc_patch_01000083.h
> src/cpu/amd/model_10xxx/mc_patch_01000084.h
> src/cpu/intel/model_f1x/multiplier.h
> src/cpu/intel/model_f0x/multiplier.h
> src/southbridge/amd/cs5536/smbus2.h
>
> I vote for dropping them.
>
> Stefan

I agree, the patch files have been replaced by newer version.

Marc

[Scott Duplichan]

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On Behalf Of Marc Jones
Sent: Wednesday, January 12, 2011 02:08 PM
To: Stefan Reinauer
Cc: [e-mail]
Subject: Re: [coreboot] Unused files

On Wed, Jan 12, 2011 at 12:39 PM, Stefan Reinauer  wrote:
> These include files are unused, they are never included
>
> src/cpu/amd/model_10xxx/mc_patch_01000020.h
> src/cpu/amd/model_10xxx/mc_patch_01000083.h
> src/cpu/amd/model_10xxx/mc_patch_01000084.h
> src/cpu/intel/model_f1x/multiplier.h
> src/cpu/intel/model_f0x/multiplier.h
> src/southbridge/amd/cs5536/smbus2.h
>
> I vote for dropping them.
>
> Stefan

]I agree, the patch files have been replaced by newer version.
]
]Marc
]-- 
]http://se-eng.com

All the AMD family 10h patches are quite old. The first 4 bytes show dates of:
mc_patch_010000B6   07/31/2009
mc_patch_0100009F   12/17/2008
mc_patch_01000086   05/01/2008
mc_patch_01000095   11/04/2008
mc_patch_01000096   11/05/2008

The AMI BIOS in my Asustek m3A78 family 10h motherboard has 2010 patches.

Thanks,
Scott

[Stefan Reinauer]

* Scott Duplichan  [110112 23:35]:
> On Wed, Jan 12, 2011 at 12:39 PM, Stefan Reinauer  wrote:
> > These include files are unused, they are never included
> >
> > src/cpu/amd/model_10xxx/mc_patch_01000020.h
> > src/cpu/amd/model_10xxx/mc_patch_01000083.h
> > src/cpu/amd/model_10xxx/mc_patch_01000084.h
> > src/cpu/intel/model_f1x/multiplier.h
> > src/cpu/intel/model_f0x/multiplier.h
> > src/southbridge/amd/cs5536/smbus2.h
> >
> > I vote for dropping them.
> >
> > Stefan
>
> ]I agree, the patch files have been replaced by newer version.
> ]
> ]Marc
> ]-- 
> ]http://se-eng.com
>
> All the AMD family 10h patches are quite old. The first 4 bytes show dates of:
> mc_patch_010000B6   07/31/2009
> mc_patch_0100009F   12/17/2008
> mc_patch_01000086   05/01/2008
> mc_patch_01000095   11/04/2008
> mc_patch_01000096   11/05/2008
>
> The AMI BIOS in my Asustek m3A78 family 10h motherboard has 2010 patches.

Where can we get newer microcode patches from? AMD anyone?

Stefan

[Scott Duplichan]

]* Scott Duplichan  [110112 23:35]:
]> On Wed, Jan 12, 2011 at 12:39 PM, Stefan Reinauer  wrote:
]> > These include files are unused, they are never included
]> >
]> > src/cpu/amd/model_10xxx/mc_patch_01000020.h
]> > src/cpu/amd/model_10xxx/mc_patch_01000083.h
]> > src/cpu/amd/model_10xxx/mc_patch_01000084.h
]> > src/cpu/intel/model_f1x/multiplier.h
]> > src/cpu/intel/model_f0x/multiplier.h
]> > src/southbridge/amd/cs5536/smbus2.h
]> >
]> > I vote for dropping them.
]> >
]> > Stefan
]> 
]> ]I agree, the patch files have been replaced by newer version.
]> ]
]> ]Marc
]> ]-- 
]> ]http://se-eng.com
]> 
]> All the AMD family 10h patches are quite old. The first 4 bytes show dates of:
]> mc_patch_010000B6   07/31/2009
]> mc_patch_0100009F   12/17/2008
]> mc_patch_01000086   05/01/2008
]> mc_patch_01000095   11/04/2008
]> mc_patch_01000096   11/05/2008
]> 
]> The AMI BIOS in my Asustek m3A78 family 10h motherboard has 2010 patches.
] 
]Where can we get newer microcode patches from? AMD anyone?
]
]Stefan

Today's patch from AMD contains these family 10h patches:

01000085
010000c6
010000c7
010000c8
010000c4
010000c5
010000bf

Thanks,
Scott

[Peter Stuge]

Stefan Reinauer wrote:
> These include files are unused, they are never included
>
> src/cpu/amd/model_10xxx/mc_patch_01000020.h
> src/cpu/amd/model_10xxx/mc_patch_01000083.h
> src/cpu/amd/model_10xxx/mc_patch_01000084.h
> src/cpu/intel/model_f1x/multiplier.h
> src/cpu/intel/model_f0x/multiplier.h
> src/southbridge/amd/cs5536/smbus2.h
>
> I vote for dropping them.

Acked-by: Peter Stuge