Re: [coreboot] New patch to review for coreboot: 617edf7 Revert "Fix multipleVGA cards resource conflict on Windows"

[She Kairui]

Hi Marc,
> From: Marc Jones 
> Date: Wed, 22 Feb 2012 01:46:33 +0100
> Subject: [coreboot] New patch to review for coreboot: 617edf7 Revert
> "Fix multipleVGA cards resource conflict on Windows"
> To: [e-mail]
>
> Marc Jones ([e-mail]) just uploaded a new patch set to
> gerrit, which you can find at http://review.coreboot.org/671
>
> -gerrit
>
> commit 617edf7e746df87616e4ada8a40decabe1231341
> Author: Marc Jones 
> Date:   Tue Feb 21 17:44:35 2012 +0100
> Revert "Fix multipleVGA cards resource conflict on Windows"
>
> This reverts commit 8660a1aa56caeb31bfaf15464285ca650638515e
>
> This commit has been found to cause problems with vbios and option rom
>
> init
>     in seabios. It has been found by several people and requires more
> analysis
>     before being recommitted.

http://review.coreboot.org/#change,489  Patch Set 4
is another way to resolve the multiVGA problem in windows.
does your platform booting with this patch set?
Thanks

Kerry
> Change-Id: Ie5f54e417e7a0d8bd8ca4c0a573976afeaa9e230
> Signed-off-by: Marc Jones <[e-mail]>
>
> src/devices/device.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/devices/device.c b/src/devices/device.c
> index 8ad9787..a2619bf 100644
> --- a/src/devices/device.c
> +++ b/src/devices/device.c
> @@ -932,6 +932,10 @@ void dev_configure(void)
>    struct device *root;
>    struct device *child;
>
> +#if CONFIG_VGA_BRIDGE_SETUP == 1
> set_vga_bridge_bits();
>
> +#endif
>
> printk(BIOS_INFO, "Allocating resources...\n");
>
> root = &dev_root;
>
> @@ -1024,10 +1028,6 @@ void dev_configure(void)
>    printk(BIOS_INFO, "Done setting resources.\n");
>    print_resource_tree(root, BIOS_SPEW, "After assigning values.");
>
> -#if CONFIG_VGA_BRIDGE_SETUP == 1
> set_vga_bridge_bits();
>
> -#endif
> printk(BIOS_INFO, "Done allocating resources.\n");
>
> }