Re: [coreboot] build fails when CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT is set

[Julius Werner]

+Dave for visibility, was a simple oversight in the refactoring

On Fri, Sep 4, 2015 at 5:12 AM, Iru Cai  wrote:
> Hi,
>
> I was trying to build coreboot with the latest git code and build failed
> when CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT is set. Some of the error message
> is:
>
> $ make
>     CREATE     build/mainboard/lenovo/x220/cbfs-file.c7KD3B.out (from
> src/mainboard/lenovo/x220/cmos.default)
> Created CBFS (capacity = 1046552 bytes)
> E: Input file size (68464) greater than page size (65536).
>     GEN        generated/romstage.ld
>     LINK       cbfs/fallback/romstage.debug
>     OBJCOPY    cbfs/fallback/romstage.elf
>     CBFS       coreboot.pre
>     CC
> northbridge/intel/sandybridge/gma_sandybridge_lvds.ramstage.o
> src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c: In function
> 'i915lightup_sandy':
> src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c:195:21: error:
> 'struct edid' has no member named 'hborder'
>   right_border = edid.hborder;
>                      ^
>
> After I searched the git log, I found this commit cause the error:
> commit 7dbf9c6747ccdfa8b993d3843a22722742957611
> Author: David Hendricks 
> Date:   Thu Jul 30 18:49:48 2015 -0700
> edid: Use edid_mode struct to reduce redundancy
>
> This replaces various timing mode parameters parameters with
> an edid_mode struct within the edid struct.
>
> I hope someone will fix the error soon.
>
> Iru Cai