Re: [coreboot] [v2] r4735 - in trunk/coreboot-v2/src/mainboard: amd/serengeti_cheetah intel/xe7501devkit msi/ms7135 msi/ms9185 newisys/khepri sunw/ultra40 supermicro/h8dme tyan/s2881 tyan/s2891 tyan/s2892 tyan/s2895 via/epia-n

[Peter Stuge]

[e-mail] wrote:
> +++ trunk/coreboot-v2/src/mainboard/tyan/s2891/Kconfig	2009-10-07 16:29:12 UTC (rev 4735)

..
> @@ -120,6 +112,7 @@
>    default n
>    depends on BOARD_TYAN_S2891
>
> +# TODO: Should be "select". And not user-visible.
>  config HAVE_ACPI_TABLES
>    bool "Generate ACPI tables"
>    default y

Why leave this?
> +++ trunk/coreboot-v2/src/mainboard/tyan/s2892/Kconfig	2009-10-07 16:29:12 UTC (rev 4735)
> @@ -120,6 +112,7 @@
>    default n
>    depends on BOARD_TYAN_S2892
>
> +# TODO
>  config HAVE_ACPI_TABLES
>    bool "Generate ACPI tables"
>    default y

?

//Peter

[v2] r4735 - in trunk/coreboot-v2/src/mainboard: amd/serengeti_cheetah intel/xe7501devkit msi/ms7135 msi/ms9185 newisys/khepri sunw/ultra40 supermicro/h8dme tyan/s2881 tyan/s2891 tyan/s2892 tyan/s2895 via/epia-n

[Uwe Hermann]

On Wed, Oct 07, 2009 at 08:04:33PM +0200, Peter Stuge wrote:
> [e-mail] wrote:
> > +++ trunk/coreboot-v2/src/mainboard/tyan/s2891/Kconfig	2009-10-07 16:29:12 UTC (rev 4735)
>
> ..
> > @@ -120,6 +112,7 @@
> >    default n
> >    depends on BOARD_TYAN_S2891
> >
> > +# TODO: Should be "select". And not user-visible.
> >  config HAVE_ACPI_TABLES
> >    bool "Generate ACPI tables"
> >    default y
>
> Why leave this?

Wanted to check if "select HAVE_ACPI_TABLES" also works if it's a
user-visible option (it appears in menuconfig). All other "select"
options we did so far are no visible in menuconfig.
> > +++ trunk/coreboot-v2/src/mainboard/tyan/s2892/Kconfig	2009-10-07 16:29:12 UTC (rev 4735)
> > @@ -120,6 +112,7 @@
> >    default n
> >    depends on BOARD_TYAN_S2892
> >
> > +# TODO
> >  config HAVE_ACPI_TABLES
> >    bool "Generate ACPI tables"
> >    default y
>
> ?

Same as above.

Uwe.