Re: [coreboot] [RFC] Error out on implicit declarations

[Bao, Zheng]

Carl-Daniel,
Can you acked-by these patches for implicit declaration?

Zheng

-----Original Message-----
From: [e-mail]
[mailto:[e-mail]] On Behalf Of Bao, Zheng
Sent: Monday, December 22, 2008 10:15 AM
To: Coreboot
Cc: Li, Maggie
Subject: [coreboot] FW: [RFC] Error out on implicit declarations

I have modified the patch. The changes are limited to board and
southbridge code.

Zheng

Signed-off-by: Maggie Li [e-mail]
Reviewed-by: Zheng bao

[RFC] Error out on implicit declarations

[Carl-Daniel Hailfinger]

Hi Zheng,

sorry for the delayed response.

On 23.12.2008 03:02, Bao, Zheng wrote:
> Carl-Daniel,
> Can you acked-by these patches for implicit declaration?

The SB600 patch is

Acked-by: Carl-Daniel Hailfinger 
and committed in revision 3837.

I think we can make the DBM690T patch shorter. What do you think?

Fix implicit declarations in the AMD DBM690T target by using the right
header files.

Signed-off-by: Carl-Daniel Hailfinger

Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c	(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c	(Arbeitskopie)
@@ -25,6 +25,8 @@
 #include <console/console.h>
 #include <arch/acpi.h>
 #include <arch/io.h>
+#include <device/device.h>
+#include <../southbridge/amd/sb600/sb600.h>

/*extern*/ u16 pm_base = 0x800;
 /* pm_base should be set in sb acpi */
Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c	(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c	(Arbeitskopie)
@@ -25,6 +25,7 @@
 #include <cpu/x86/msr.h>
 #include <cpu/amd/mtrr.h>
 #include <device/pci_def.h>
+#include <../southbridge/amd/sb600/sb600.h>
 #include "chip.h"

#define ADT7461_ADDRESS 0x4C
@@ -34,6 +35,8 @@
 extern int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32 address);
 extern int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address,
    		       u8 val);
+extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, 
+				uint64_t start, uint64_t size);
 #define ADT7461_read_byte(address) \
    do_smbus_read_byte(SMBUS_IO_BASE, ADT7461_ADDRESS, address)
 #define ARA_read_byte(address) \

[RFC] Error out on implicit declarations

[Bao, Zheng]

My patch about acpi_tables.c has nothing to do with implicit
declaration. But it also output warnings and should be fixed. I agree
with other improvement you made.

--- coreboot-v2-org/src/mainboard/amd/dbm690t/acpi_tables.c
2008-12-02 02:56:38.000000000 +0800
+++ ../coreboot-v2/src/mainboard/amd/dbm690t/acpi_tables.c
2008-12-19 15:35:29.000000000 +0800
@@ -133,12 +133,12 @@
    u32 *v;
    struct cpuid_result cpuid1;

-	typedef struct power_limit_encoding {
+	typedef struct _power_limit_encoding {
    	u8 socket_type;
    	u8 cmp_cap;
    	u8 pwr_lmt;
    	u32 power_limit;
-	};
+	} power_limit_encoding;
    u8 Max_fid, Max_vid, Start_fid, Start_vid, Min_fid, Min_vid;
    u16 Max_feq;
    u8 Pstate_fid[10];
@@ -167,7 +167,7 @@
    u32 new_package_length;
    u8 sum, checksum;
    u32 fid_multiplier;
-	static struct power_limit_encoding TDP[20] = {
+	static power_limit_encoding TDP[20] = {
    	{0x11, 0x0, 0x8, 62},
    	{0x11, 0x1, 0x8, 89},
    	{0x11, 0x1, 0xa, 103},

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Tuesday, December 23, 2008 10:31 AM
To: Bao, Zheng
Cc: [e-mail]
Subject: Re: [coreboot] [RFC] Error out on implicit declarations

Hi Zheng,

sorry for the delayed response.

On 23.12.2008 03:02, Bao, Zheng wrote:
> Carl-Daniel,
> Can you acked-by these patches for implicit declaration?

The SB600 patch is

Acked-by: Carl-Daniel Hailfinger 
and committed in revision 3837.

I think we can make the DBM690T patch shorter. What do you think?

Fix implicit declarations in the AMD DBM690T target by using the right
header files.

Signed-off-by: Carl-Daniel Hailfinger

Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
(Arbeitskopie)
@@ -25,6 +25,8 @@
 #include <console/console.h>
 #include <arch/acpi.h>
 #include <arch/io.h>
+#include <device/device.h>
+#include <../southbridge/amd/sb600/sb600.h>

/*extern*/ u16 pm_base = 0x800;
 /* pm_base should be set in sb acpi */
Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
(Arbeitskopie)
@@ -25,6 +25,7 @@
 #include <cpu/x86/msr.h>
 #include <cpu/amd/mtrr.h>
 #include <device/pci_def.h>
+#include <../southbridge/amd/sb600/sb600.h>
 #include "chip.h"

#define ADT7461_ADDRESS 0x4C
@@ -34,6 +35,8 @@
 extern int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32
address);
 extern int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32
address,
    		       u8 val);
+extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, 
+				uint64_t start, uint64_t size);
 #define ADT7461_read_byte(address) \
    do_smbus_read_byte(SMBUS_IO_BASE, ADT7461_ADDRESS, address)
 #define ARA_read_byte(address) \

[RFC] Error out on implicit declarations

[Bao, Zheng]

Acked-by: Zheng Bao

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Tuesday, December 23, 2008 10:31 AM
To: Bao, Zheng
Cc: [e-mail]
Subject: Re: [coreboot] [RFC] Error out on implicit declarations

Hi Zheng,

sorry for the delayed response.

On 23.12.2008 03:02, Bao, Zheng wrote:
> Carl-Daniel,
> Can you acked-by these patches for implicit declaration?

The SB600 patch is

Acked-by: Carl-Daniel Hailfinger 
and committed in revision 3837.

I think we can make the DBM690T patch shorter. What do you think?

Fix implicit declarations in the AMD DBM690T target by using the right
header files.

Signed-off-by: Carl-Daniel Hailfinger

Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
(Arbeitskopie)
@@ -25,6 +25,8 @@
 #include <console/console.h>
 #include <arch/acpi.h>
 #include <arch/io.h>
+#include <device/device.h>
+#include <../southbridge/amd/sb600/sb600.h>

/*extern*/ u16 pm_base = 0x800;
 /* pm_base should be set in sb acpi */
Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
(Arbeitskopie)
@@ -25,6 +25,7 @@
 #include <cpu/x86/msr.h>
 #include <cpu/amd/mtrr.h>
 #include <device/pci_def.h>
+#include <../southbridge/amd/sb600/sb600.h>
 #include "chip.h"

#define ADT7461_ADDRESS 0x4C
@@ -34,6 +35,8 @@
 extern int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32
address);
 extern int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32
address,
    		       u8 val);
+extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, 
+				uint64_t start, uint64_t size);
 #define ADT7461_read_byte(address) \
    do_smbus_read_byte(SMBUS_IO_BASE, ADT7461_ADDRESS, address)
 #define ARA_read_byte(address) \

[RFC] Error out on implicit declarations

[Carl-Daniel Hailfinger]

On 24.12.2008 03:27, Bao, Zheng wrote:
> Acked-by: Zheng Bao
>
> -----Original Message-----
> From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
> Sent: Tuesday, December 23, 2008 10:31 AM
> To: Bao, Zheng
> Cc: [e-mail]
> Subject: Re: [coreboot] [RFC] Error out on implicit declarations
>
> Hi Zheng,
>
> sorry for the delayed response.
>
> On 23.12.2008 03:02, Bao, Zheng wrote:
> > Carl-Daniel,
> > Can you acked-by these patches for implicit declaration?
>
> The SB600 patch is
>
> Acked-by: Carl-Daniel Hailfinger 
> and committed in revision 3837.
>
> I think we can make the DBM690T patch shorter. What do you think?
>
> Fix implicit declarations in the AMD DBM690T target by using the right
> header files.
>
> Signed-off-by: Carl-Daniel Hailfinger

Thanks, committed in r3843.

Regards,
Carl-Daniel

[RFC] Error out on implicit declarations

[Bao, Zheng]

Hi, Carl-Daniel,
I deleted trailing white spaces in your dbm690t patch. I think the style
of pistachio should be match with dbm690t. Do you think?

Zheng

Signed-off-by: Zheng Bao

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Tuesday, December 23, 2008 10:31 AM
To: Bao, Zheng
Cc: [e-mail]
Subject: Re: [coreboot] [RFC] Error out on implicit declarations

Hi Zheng,

sorry for the delayed response.

On 23.12.2008 03:02, Bao, Zheng wrote:
> Carl-Daniel,
> Can you acked-by these patches for implicit declaration?

The SB600 patch is

Acked-by: Carl-Daniel Hailfinger 
and committed in revision 3837.

I think we can make the DBM690T patch shorter. What do you think?

Fix implicit declarations in the AMD DBM690T target by using the right
header files.

Signed-off-by: Carl-Daniel Hailfinger

Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
(Arbeitskopie)
@@ -25,6 +25,8 @@
 #include <console/console.h>
 #include <arch/acpi.h>
 #include <arch/io.h>
+#include <device/device.h>
+#include <../southbridge/amd/sb600/sb600.h>

/*extern*/ u16 pm_base = 0x800;
 /* pm_base should be set in sb acpi */
Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
(Arbeitskopie)
@@ -25,6 +25,7 @@
 #include <cpu/x86/msr.h>
 #include <cpu/amd/mtrr.h>
 #include <device/pci_def.h>
+#include <../southbridge/amd/sb600/sb600.h>
 #include "chip.h"

#define ADT7461_ADDRESS 0x4C
@@ -34,6 +35,8 @@
 extern int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32
address);
 extern int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32
address,
    		       u8 val);
+extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, 
+				uint64_t start, uint64_t size);
 #define ADT7461_read_byte(address) \
    do_smbus_read_byte(SMBUS_IO_BASE, ADT7461_ADDRESS, address)
 #define ARA_read_byte(address) \

[RFC] Error out on implicit declarations

[Carl-Daniel Hailfinger]

Hi Zheng,

thanks for that patch.

On 24.12.2008 04:59, Bao, Zheng wrote:
> Hi, Carl-Daniel,
> I deleted trailing white spaces in your dbm690t patch. I think the style
> of pistachio should be match with dbm690t. Do you think?
>
> Zheng
>
> Signed-off-by: Zheng Bao

Acked-by: Carl-Daniel Hailfinger

and committed in revision 3844.

Regards,
Carl-Daniel

[RFC] Error out on implicit declarations

[Carl-Daniel Hailfinger]

Hi Zheng,

I have found a shorter way to fix the power_limit_encoding warnings.
What do you think?

Regards,
Carl-Daniel

Remove a unneccessary typedef from acpi_tables.c in the AMD Pistachio
and DBM690T targets.

Signed-off-by: Carl-Daniel Hailfinger

--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/pistachio/acpi_tables.c	(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/pistachio/acpi_tables.c	(Arbeitskopie)
@@ -133,7 +133,7 @@
    u32 *v;
    struct cpuid_result cpuid1;

-	typedef struct power_limit_encoding {
+	struct power_limit_encoding {
    	u8 socket_type;
    	u8 cmp_cap;
    	u8 pwr_lmt;
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/acpi_tables.c	(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/acpi_tables.c	(Arbeitskopie)
@@ -133,7 +133,7 @@
    u32 *v;
    struct cpuid_result cpuid1;

-	typedef struct power_limit_encoding {
+	struct power_limit_encoding {
    	u8 socket_type;
    	u8 cmp_cap;
    	u8 pwr_lmt;

[RFC] Error out on implicit declarations

[Bao, Zheng]

Agree.

I sent last 2 duplicated mails before I saw your mail.

Zheng

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Tuesday, December 23, 2008 10:50 AM
To: Bao, Zheng
Cc: [e-mail]
Subject: Re: [coreboot] [RFC] Error out on implicit declarations

Hi Zheng,

I have found a shorter way to fix the power_limit_encoding warnings.
What do you think?

Regards,
Carl-Daniel

Remove a unneccessary typedef from acpi_tables.c in the AMD Pistachio
and DBM690T targets.

Signed-off-by: Carl-Daniel Hailfinger

--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/pistachio/acpi_tables.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/pistachio/acpi_tables.c
(Arbeitskopie)
@@ -133,7 +133,7 @@
    u32 *v;
    struct cpuid_result cpuid1;

-	typedef struct power_limit_encoding {
+	struct power_limit_encoding {
    	u8 socket_type;
    	u8 cmp_cap;
    	u8 pwr_lmt;
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/acpi_tables.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/acpi_tables.c
(Arbeitskopie)
@@ -133,7 +133,7 @@
    u32 *v;
    struct cpuid_result cpuid1;

-	typedef struct power_limit_encoding {
+	struct power_limit_encoding {
    	u8 socket_type;
    	u8 cmp_cap;
    	u8 pwr_lmt;

[RFC] Error out on implicit declarations

[Paul Menzel]

Dear Zheng,

Am Dienstag, den 23.12.2008, 10:53 +0800 schrieb Bao, Zheng:
> Agree.

Thanks for all your efforts.

Could you please add a Acked-by-line as required by the development
guidelines [1] (Sign-off Procedure). Otherwise Carl-Daniel is not
allowed to check the patches in.

Cheers,

Paul

[1] http://www.coreboot.org/Development_Guidelines

[RFC] Error out on implicit declarations

[Paul Menzel]

Dear Zheng,

Am Dienstag, den 23.12.2008, 08:49 +0100 schrieb Paul Menzel:
> Am Dienstag, den 23.12.2008, 10:53 +0800 schrieb Bao, Zheng:
> Could you please add a Acked-by-line as required by the development
> guidelines [1] (Sign-off Procedure). Otherwise Carl-Daniel is not
> allowed to check the patches in.

Never mind. I just read, that you know about this in another message¹.

Thanks,

Paul

¹ That happens when one reads the list after the FIFO-principal.

[RFC] Error out on implicit declarations

[Bao, Zheng]

Acked-by: Zheng Bao

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Tuesday, December 23, 2008 10:50 AM
To: Bao, Zheng
Cc: [e-mail]
Subject: Re: [coreboot] [RFC] Error out on implicit declarations

Hi Zheng,

I have found a shorter way to fix the power_limit_encoding warnings.
What do you think?

Regards,
Carl-Daniel

Remove a unneccessary typedef from acpi_tables.c in the AMD Pistachio
and DBM690T targets.

Signed-off-by: Carl-Daniel Hailfinger

--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/pistachio/acpi_tables.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/pistachio/acpi_tables.c
(Arbeitskopie)
@@ -133,7 +133,7 @@
    u32 *v;
    struct cpuid_result cpuid1;

-	typedef struct power_limit_encoding {
+	struct power_limit_encoding {
    	u8 socket_type;
    	u8 cmp_cap;
    	u8 pwr_lmt;
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/acpi_tables.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/acpi_tables.c
(Arbeitskopie)
@@ -133,7 +133,7 @@
    u32 *v;
    struct cpuid_result cpuid1;

-	typedef struct power_limit_encoding {
+	struct power_limit_encoding {
    	u8 socket_type;
    	u8 cmp_cap;
    	u8 pwr_lmt;