Re: [coreboot] r3356 - trunk/util/flashrom

[Mart Raudsepp]

> Author: stuge
> Date: 2008-05-27 22:54:09 +0200 (Tue, 27 May 2008)
> New Revision: 3356
>
> Modified:
>    trunk/util/flashrom/flashchips.c
> Log:
> flashrom: MX25L4005, S25FL016A, W39V040B, W39V080A, SST49LF008A tests.
>
> I have tested MX25L4005, S25FL016A and W39V080A myself.
>
> Thanks also to the following testers:
> SST49LF008A Bernhard M. Wiedemann
> W39V040B Dan Lenski
>
> Signed-off-by: Peter Stuge 
> Acked-by: Peter Stuge
> Modified: trunk/util/flashrom/flashchips.c
>
> --- trunk/util/flashrom/flashchips.c	2008-05-27 20:07:47 UTC (rev 3355)
> +++ trunk/util/flashrom/flashchips.c	2008-05-27 20:54:09 UTC (rev 3356)
> @@ -51,7 +51,7 @@

...
> {"SST",		"SST49LF008A",		SST_ID,		SST_49LF008A,		1024,	64 *
>
> 1024,	TEST_UNTESTED,	probe_sst_fwhub,	erase_sst_fwhub,		write_sst_fwhub},
> {"SST",		"SST49LF008A",		SST_ID,		SST_49LF008A,		1024,	64 *
>
> 1024,	TEST_OK_PR,	probe_sst_fwhub,	erase_sst_fwhub,		write_sst_fwhub},

Did you try compiling this TEST_OK_PR? :)
Fixed in r3357

r3356 - trunk/util/flashrom

[Carl-Daniel Hailfinger]

On 28.05.2008 00:22, Mart Raudsepp wrote:
> > Author: stuge
> > Date: 2008-05-27 22:54:09 +0200 (Tue, 27 May 2008)
> > New Revision: 3356
> >
> > Modified:
> >    trunk/util/flashrom/flashchips.c
> > Log:
> > flashrom: MX25L4005, S25FL016A, W39V040B, W39V080A, SST49LF008A tests.
> >
> > I have tested MX25L4005, S25FL016A and W39V080A myself.
> >
> > Thanks also to the following testers:
> > SST49LF008A Bernhard M. Wiedemann
> > W39V040B Dan Lenski
> >
> > Signed-off-by: Peter Stuge 
> > Acked-by: Peter Stuge
> > Modified: trunk/util/flashrom/flashchips.c
> >
> > --- trunk/util/flashrom/flashchips.c	2008-05-27 20:07:47 UTC (rev 3355)
> > +++ trunk/util/flashrom/flashchips.c	2008-05-27 20:54:09 UTC (rev 3356)
> > @@ -51,7 +51,7 @@
>
> ...
> > {"SST",		"SST49LF008A",		SST_ID,		SST_49LF008A,		1024,	64 *
> >
> > 1024,	TEST_UNTESTED,	probe_sst_fwhub,	erase_sst_fwhub,		write_sst_fwhub},
> > {"SST",		"SST49LF008A",		SST_ID,		SST_49LF008A,		1024,	64 *
> >
> > 1024,	TEST_OK_PR,	probe_sst_fwhub,	erase_sst_fwhub,		write_sst_fwhub},
>
> Did you try compiling this TEST_OK_PR? :)
> Fixed in r3357

Please revert and add a TEST_OK_PR definition. Only PR had been tested
for that chip.

Regards,
Carl-Daniel