Patch set updated for coreboot: b0cd5ca Add AMD Family 10h PH-EO support

[QingPei Wang]

QingPei Wang ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/202

-gerrit

commit b0cd5ca9e6a0d7d46caab6fedf491e00f70dc532
Author: QingPei Wang 
Date:   Tue Sep 13 18:04:22 2011 +0800

Add AMD Family 10h PH-EO support

the patch file comes from
    src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x10/RevE
    /F10MicrocodePatch010000bf.c

Change-Id: If701c8a908edf1c486665d3ce4df65da0f65c802
    Signed-off-by: QingPei Wang 
---
 src/cpu/amd/model_10xxx/mc_patch_010000bf.h |  165 +++++++++++++++++++++++++++
 1 files changed, 165 insertions(+), 0 deletions(-)

diff --git a/src/cpu/amd/model_10xxx/mc_patch_010000bf.h b/src/cpu/amd/model_10xxx/mc_patch_010000bf.h
new file mode 100644
index 0000000..ea971bc
--- /dev/null
+++ b/src/cpu/amd/model_10xxx/mc_patch_010000bf.h
@@ -0,0 +1,165 @@
+/*
+ ============================================================
+ Copyright (c) Advanced Micro Devices, Inc., 2004-2008
+ Copyright QingPei Wang 
+
+ The  enclosed microcode  is intended  to be  used  with AMD
+ Microprocessors.  You  may   copy,  view  and  install  the
+ enclosed microcode  only for development  and deployment of
+ firmware,  BIOS,  or  operating  system code  for  computer
+ systems   that  contain  AMD   processors.   You   are  not
+ authorized  to use  the  enclosed microcode  for any  other
+ purpose.
+
+ THE  MICROCODE IS PROVIDED  "AS IS"  WITHOUT ANY  EXPRESS OR
+ IMPLIED WARRANTY  OF ANY KIND, INCLUDING BUT  NOT LIMITED TO
+ WARRANTIES    OF    MERCHANTABILITY,   NON-    INFRINGEMENT,
+ TITLE,FITNESS  FOR  ANY  PARTICULAR PURPOSE,  OR  WARRANTIES
+ ARISING FROM CONDUCT, COURSE  OF DEALING, OR USAGE OF TRADE.
+ AMD does not assume  any responsibility for any errors which
+ may  appear   in  this   microcode  or  any   other  related
+ information provided  to you by  AMD, or result from  use of
+ this microcode.   AMD is not obligated  to furnish, support,
+ or  make   any  further  information,   software,  technical
+ information, know-how, or show-how available related to this
+ microcode.
+
+ The  microcode is provided  with "RESTRICTED  RIGHTS."  Use,
+ duplication, or disclosure by the U.S. Government is subject
+ to  the  restrictions as  set  forth  in  FAR 52.227-14  and
+ DFAR252.227-7013,  et seq.,  or its  successor.  Use  of the
+ microcode    by    the    U.S.     Government    constitutes
+ acknowledgement  of   AMD's  proprietary  rights   in  them.
+ ============================================================
+*/
+
+
+0x10, 0x20, 0x17, 0x02, 0xbf, 0x00, 0x00, 0x01, 0x00, 0x80, 0x20, 0x00,
+0x42, 0x82, 0x02, 0x39, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+0xa0, 0x10, 0x00, 0x00, 0x00, 0xaa, 0xaa, 0xaa, 0x74, 0x0f, 0x00, 0x00,
+0xbe, 0x01, 0x00, 0x00, 0x33, 0x0e, 0x00, 0x00, 0xa9, 0x01, 0x00, 0x00,
+0x75, 0x00, 0x00, 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+0xff, 0xff, 0xff, 0xff, 0xa0, 0xfd, 0xff, 0x28, 0xc3, 0x3f, 0xc0, 0xcf,
+0xff, 0x07, 0xe2, 0x01, 0x0f, 0xde, 0x50, 0xfe, 0xf2, 0xdf, 0xff, 0x0f,
+0x3b, 0xfc, 0x01, 0xc5, 0x40, 0x03, 0xd4, 0x00, 0x80, 0xff, 0xfe, 0x7f,
+0xfe, 0xe1, 0x1b, 0xc8, 0x5b, 0xf6, 0xff, 0xff, 0x7b, 0x87, 0x5f, 0xad,
+0x6b, 0xf9, 0x6f, 0xfe, 0xfa, 0x1f, 0xfe, 0xb5, 0x00, 0x40, 0x11, 0x6a,
+0x0e, 0xc0, 0x9b, 0x56, 0xe8, 0x75, 0xe0, 0x0f, 0x38, 0x00, 0xcf, 0xcc,
+0xa0, 0xd7, 0x83, 0x3f, 0xff, 0x7b, 0xfc, 0xbf, 0x00, 0x3f, 0x0f, 0xff,
+0x35, 0x00, 0x80, 0xd0, 0x18, 0x07, 0x60, 0x19, 0x07, 0xf4, 0x7a, 0xf0,
+0xa6, 0x1c, 0x00, 0x38, 0x1f, 0xc0, 0xe7, 0xa0, 0xff, 0xff, 0x51, 0x9e,
+0x7f, 0x80, 0x9f, 0x87, 0x80, 0x0a, 0x00, 0x60, 0xd3, 0xe0, 0x4f, 0x10,
+0xfc, 0x32, 0xd8, 0x3a, 0x49, 0xff, 0x7f, 0xcb, 0xf0, 0x0f, 0xf0, 0xf3,
+0x8c, 0xff, 0xff, 0x00, 0xc3, 0x31, 0x17, 0xfd, 0x2c, 0x47, 0x0d, 0x00,
+0xd0, 0x32, 0xf0, 0x27, 0x1d, 0x7e, 0x19, 0x6c, 0x60, 0xf1, 0xff, 0x1f,
+0x7f, 0x38, 0xe6, 0xa2, 0x16, 0x35, 0xff, 0xff, 0xe7, 0xe1, 0x1f, 0xe0,
+0x00, 0xfe, 0xbf, 0x07, 0xbb, 0x9c, 0xf4, 0xff, 0x3f, 0x0f, 0xff, 0x00,
+0x07, 0xf8, 0xdf, 0x8d, 0x0b, 0x3e, 0x78, 0x73, 0x3f, 0x8b, 0xff, 0xff,
+0x70, 0xe5, 0xf0, 0x0b, 0x03, 0x00, 0x0f, 0x50, 0xff, 0x52, 0xfe, 0xbb,
+0xaf, 0xfa, 0x87, 0x7f, 0xff, 0x07, 0xc0, 0xff, 0xa5, 0x14, 0x1f, 0xbe,
+0xff, 0x9f, 0xc5, 0xff, 0xc4, 0xaa, 0x72, 0xf8, 0xef, 0x01, 0x80, 0xff,
+0xeb, 0xff, 0x00, 0x43, 0x37, 0x96, 0xfd, 0xc3, 0xf6, 0xff, 0xab, 0x80,
+0xff, 0x00, 0x3f, 0x0f, 0xff, 0xff, 0x8f, 0xe2, 0xfc, 0x02, 0x54, 0x39,
+0xda, 0xd5, 0x00, 0x80, 0xff, 0x68, 0x3c, 0xe0, 0xc1, 0x9b, 0xca, 0xfe,
+0xe4, 0xff, 0xff, 0x09, 0x87, 0x5f, 0x06, 0x5b, 0xfe, 0x0f, 0xc4, 0x03,
+0x1e, 0xfa, 0xa9, 0x7c, 0xe0, 0xff, 0x7b, 0x00, 0xc0, 0x7f, 0xe0, 0x1f,
+0xdf, 0xf0, 0x0f, 0xe0, 0x00, 0xff, 0x81, 0x7f, 0x7f, 0xc3, 0x3f, 0x80,
+0x01, 0xfc, 0x07, 0xfe, 0xfe, 0x0d, 0xff, 0x00, 0x00, 0xf0, 0xff, 0x3d,
+0x0f, 0xe0, 0x3f, 0xf0, 0xf0, 0x6f, 0xf8, 0x07, 0x3f, 0x80, 0xff, 0xc0,
+0xc0, 0xbf, 0xe1, 0x1f, 0xff, 0x00, 0xfe, 0x03, 0x00, 0xff, 0x86, 0x7f,
+0x1e, 0x00, 0xf8, 0xff, 0xf8, 0x07, 0xf0, 0x1f, 0x03, 0xf8, 0x37, 0xfc,
+0xe0, 0x1f, 0xc0, 0x7f, 0x0f, 0xe0, 0xdf, 0xf0, 0x81, 0x7f, 0x00, 0xff,
+0x3f, 0x80, 0x7f, 0xc3, 0x7f, 0x0f, 0x00, 0xfc, 0x0f, 0xfc, 0x03, 0xf8,
+0xfe, 0x01, 0xfc, 0x1b, 0x3f, 0xf0, 0x0f, 0xe0, 0xf8, 0x07, 0xf0, 0x6f,
+0xff, 0xc0, 0x3f, 0x80, 0xe1, 0x1f, 0xc0, 0xbf, 0xfe, 0xbf, 0x07, 0x00,
+0xfc, 0x07, 0xfe, 0x01, 0x0d, 0xff, 0x00, 0xfe, 0xf0, 0x1f, 0xf8, 0x07,
+0x37, 0xfc, 0x03, 0xf8, 0xc0, 0x7f, 0xe0, 0x1f, 0xdf, 0xf0, 0x0f, 0xe0,
+0x00, 0xff, 0xdf, 0x03, 0x00, 0xfe, 0x03, 0xff, 0xff, 0x86, 0x7f, 0x00,
+0x03, 0xf8, 0x0f, 0xfc, 0xfc, 0x1b, 0xfe, 0x01, 0x0f, 0xe0, 0x3f, 0xf0,
+0xf0, 0x6f, 0xf8, 0x07, 0x01, 0x80, 0xff, 0xef, 0x7f, 0xbf, 0xff, 0x81,
+0xdf, 0x95, 0xc1, 0xaf, 0xff, 0x91, 0xfc, 0x2f, 0x48, 0x57, 0x06, 0xbf,
+0xff, 0x4f, 0xb0, 0xff, 0x32, 0xd8, 0x3a, 0xfc, 0xd7, 0x00, 0x40, 0x95,
+0x81, 0xff, 0x94, 0x01, 0x1f, 0xe0, 0xe7, 0xe1, 0xff, 0xff, 0x53, 0xce,
+0x7f, 0xa9, 0xeb, 0x83, 0xff, 0xef, 0x4b, 0xfd, 0xfc, 0xbd, 0xbd, 0x0e,
+0xff, 0x7b, 0x00, 0xe0, 0x9c, 0x56, 0x0e, 0x00, 0xd0, 0x0f, 0xe0, 0x73,
+0xff, 0x81, 0x7f, 0x00, 0xc3, 0x3f, 0x80, 0x7f, 0xfc, 0x07, 0xfe, 0x01,
+0x0d, 0xff, 0x00, 0xfe, 0xe0, 0xfd, 0x35, 0x00, 0xe0, 0x0d, 0x2b, 0x07,
+0x3a, 0xf0, 0x07, 0xf4, 0x96, 0xff, 0xed, 0x3f, 0xff, 0xe1, 0x1f, 0xab,
+0x5b, 0x02, 0x00, 0xfe, 0xfb, 0x87, 0x7f, 0xac, 0x00, 0xa8, 0xcd, 0x1a,
+0x6f, 0x72, 0xc0, 0xff, 0xfc, 0x3c, 0xfc, 0x03, 0x1f, 0xc0, 0x7f, 0xe0,
+0xe0, 0xdf, 0xf0, 0x0f, 0x7f, 0x00, 0xff, 0x81, 0x80, 0x7f, 0xc3, 0x3f,
+0x0f, 0x00, 0xfc, 0x7f, 0xff, 0x7f, 0x79, 0xfc, 0x01, 0x7e, 0x1e, 0xfe,
+0x2b, 0x07, 0xe0, 0xfe, 0x07, 0xf0, 0x39, 0xe8, 0xc0, 0x3f, 0x80, 0xff,
+0x1f, 0xc0, 0xbf, 0xe1, 0xb9, 0x06, 0x00, 0x78, 0xf6, 0xff, 0xbf, 0x80,
+0xff, 0x00, 0x3f, 0x0f, 0xff, 0xff, 0x8f, 0xe2, 0xfc, 0x03, 0xfc, 0x3c,
+0x7f, 0x34, 0x1e, 0xf0, 0xd0, 0xef, 0xe5, 0xf3, 0xff, 0xdf, 0x03, 0x00,
+0xee, 0xa3, 0x72, 0x00, 0x83, 0x7e, 0x00, 0x9f, 0xf8, 0xfd, 0xff, 0x07,
+0x1f, 0xbe, 0xb1, 0xec, 0x65, 0x97, 0xff, 0x1f, 0x79, 0xf8, 0x07, 0xf8,
+0x80, 0xc4, 0x97, 0x01, 0x00, 0xff, 0x81, 0x7f, 0x7f, 0xc3, 0x3f, 0x80,
+0x01, 0xfc, 0x07, 0xfe, 0xfe, 0x0d, 0xff, 0x00, 0x07, 0xf0, 0x1f, 0xf8,
+0xf8, 0x37, 0xfc, 0x03, 0x00, 0xc0, 0xff, 0xf7, 0x3f, 0x80, 0xff, 0xc0,
+0xc0, 0xbf, 0xe1, 0x1f, 0xff, 0x00, 0xfe, 0x03, 0x00, 0xff, 0x86, 0x7f,
+0xfc, 0x03, 0xf8, 0x0f, 0x01, 0xfc, 0x1b, 0xfe, 0x7b, 0x00, 0xe0, 0xff,
+0xe0, 0x1f, 0xc0, 0x7f, 0x0f, 0xe0, 0xdf, 0xf0, 0x81, 0x7f, 0x00, 0xff,
+0x3f, 0x80, 0x7f, 0xc3, 0x07, 0xfe, 0x01, 0xfc, 0xff, 0x00, 0xfe, 0x0d,
+0xff, 0x3d, 0x00, 0xf0, 0x3f, 0xf0, 0x0f, 0xe0, 0xf8, 0x07, 0xf0, 0x6f,
+0xff, 0xc0, 0x3f, 0x80, 0xe1, 0x1f, 0xc0, 0xbf, 0xfe, 0x03, 0xff, 0x00,
+0x86, 0x7f, 0x00, 0xff, 0xf8, 0xff, 0x1e, 0x00, 0xf0, 0x1f, 0xf8, 0x07,
+0x37, 0xfc, 0x03, 0xf8, 0xc0, 0x7f, 0xe0, 0x1f, 0xdf, 0xf0, 0x0f, 0xe0,
+0x00, 0xff, 0x81, 0x7f, 0x7f, 0xc3, 0x3f, 0x80, 0x00, 0xfc, 0x7f, 0x0f,
+0x03, 0xf8, 0x0f, 0xfc, 0xfc, 0x1b, 0xfe, 0x01, 0x0f, 0xe0, 0x3f, 0xf0,
+0xf0, 0x6f, 0xf8, 0x07, 0x3f, 0x80, 0xff, 0xc0, 0xc0, 0xbf, 0xe1, 0x1f,
+0x07, 0x00, 0xfe, 0xbf, 0xfe, 0x01, 0xfc, 0x07, 0x00, 0xfe, 0x0d, 0xff,
+0xf8, 0x07, 0xf0, 0x1f, 0x03, 0xf8, 0x37, 0xfc, 0xe0, 0x1f, 0xc0, 0x7f,
+0x0f, 0xe0, 0xdf, 0xf0, 0xdf, 0x03, 0x00, 0xff, 0x03, 0xff, 0x00, 0xfe,
+0x7f, 0x00, 0xff, 0x86, 0x0f, 0xfc, 0x03, 0xf8, 0xfe, 0x01, 0xfc, 0x1b,
+0x3f, 0xf0, 0x0f, 0xe0, 0xf8, 0x07, 0xf0, 0x6f, 0xff, 0xef, 0x01, 0x80,
+
+
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

Patch set updated for coreboot: b0cd5ca Add AMD Family 10h PH-EO support

[Paul Menzel]

Dear QuingPei,

thank you for updating the patches.

Am Dienstag, den 13.09.2011, 12:05 +0200 schrieb QingPei Wang:
> QingPei Wang ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/202
>
> -gerrit
>
> commit b0cd5ca9e6a0d7d46caab6fedf491e00f70dc532
> Author: QingPei Wang 
> Date:   Tue Sep 13 18:04:22 2011 +0800
> Add AMD Family 10h PH-EO support
>
> the patch file comes from

1. Could you start sentences in the commit message body with a capital
letter please?
> src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x10/RevE
> /F10MicrocodePatch010000bf.c

2. I do not understand the commit message. What do you mean with patch
file? In this patch you are only adding a header file.
> Change-Id: If701c8a908edf1c486665d3ce4df65da0f65c802
> Signed-off-by: QingPei Wang <[e-mail]>
>
> src/cpu/amd/model_10xxx/mc_patch_010000bf.h |  165 +++++++++++++++++++++++++++
>  1 files changed, 165 insertions(+), 0 deletions(-)

[…]

Thanks,

Paul

Patch set updated for coreboot: b0cd5ca Add AMD Family 10h PH-EO support

[xdrudis]

On Tue, Sep 13, 2011 at 12:18:24PM +0200, Paul Menzel wrote:
> > src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x10/RevE
> > /F10MicrocodePatch010000bf.c
> I do not understand the commit message. What do you mean with patch
>
> file? In this patch you are only adding a header file.

It is adding microcode patches to a header file.

The lines added contain binary patches for a binary
"interpreter/program/something" stored in the CPU that is called
microcode. Roughly, there's some kind of EPROM (or ROM+shadow RAM or
some form of memory) in the CPU that gets indexed by x86 opcodes and
other inputs and outputs control signals to drive the CPU circuitry in
a way consistent with the instruction set semantics and CPU
specification. The information in this EPROM is the microcode.  The
content in the altered "source" file is not a new copy of the
microcode but just parts of it presumably with some control
information about which version it is or which it should replace and
where to apply the code portions, or whatever. That's why the original
file had MicrocodePatch in its name.

I don't know many more details, since neither the microcode source,
the language it is written in or the CPU design are public at all, but
I think it is enough to understand why QingPei Wang called it "patch
file". You can't say "I add microcode for revision E Fam 10 CPUs"
because the file does not contain the whole microcode of the CPU, just
some (small?) modifications to the microcode contained in the CPU as
shipped from factory. "patch file" is not talking of a patch to the
coreboot code, but of a patch to the microcode, the whole binary patch
will be contained in the coreboot image if you so compile it. Call the
patch set sent "metapatch" if you like.

I agree that initial capital case is clearer, although I don't see it
so important as to raise it.

The only reason I can imagine for not taking the patch set (updated
later) is lack of extensive tests or license compatibility, but both
would apply to microcode already in coreboot so my guess is it'll be
merged.

Thanks for reviewing contributions. And thanks to contributors.

Patch set updated for coreboot: b0cd5ca Add AMD Family 10h PH-EO support

[QingPei Wang]

the content of 010000bf.c comes from

src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x10/RevE/F10MicrocodePatch010000bf.c

but F10MicrocodePatch010000bf.c is used by amd agesa, could not be used
directly. i
port the code. just mentioned in the commit message that where is comes from

Best wishes
QingPei Wang
Phone: 86+018930528086

On Tue, Sep 13, 2011 at 6:18 PM, Paul Menzel <
[e-mail]> wrote:
> Dear QuingPei,
>
> thank you for updating the patches.
>
> Am Dienstag, den 13.09.2011, 12:05 +0200 schrieb QingPei Wang:
> > QingPei Wang ([e-mail]) just uploaded a new patch set to
>
> gerrit, which you can find at http://review.coreboot.org/202
> > -gerrit
> >
> > commit b0cd5ca9e6a0d7d46caab6fedf491e00f70dc532
> > Author: QingPei Wang 
> > Date:   Tue Sep 13 18:04:22 2011 +0800
> > Add AMD Family 10h PH-EO support
> >
> > the patch file comes from
> Could you start sentences in the commit message body with a capital
>
> letter please?
> > src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x10/RevE
> > /F10MicrocodePatch010000bf.c
> I do not understand the commit message. What do you mean with patch
>
> file? In this patch you are only adding a header file.
> > Change-Id: If701c8a908edf1c486665d3ce4df65da0f65c802
> > Signed-off-by: QingPei Wang <[e-mail]>
> >
> > src/cpu/amd/model_10xxx/mc_patch_010000bf.h |  165
>
> +++++++++++++++++++++++++++
> > 1 files changed, 165 insertions(+), 0 deletions(-)
>
> […]
>
> Thanks,
>
> Paul