Re: [LinuxBIOS] Broken build for kexec-boot-loader in buildrom x86_64?

[Myles Watson]

Did the patch work for anyone else?  Any concerns?

Thanks,
Myles

On Dec 7, 2007 10:45 AM, Myles Watson  wrote:
> On Dec 3, 2007 10:23 AM, Myles Watson  wrote:
> > > buildrom gives me still an error when building kexec-boot-loader
> > > (x86_64) for the m57sli:
> > >
> > > gcc --32    -c -o kexec/x86-setup-32.o kexec/x86-setup-32.S
> > > cc1: error: unrecognized command line option "-f32"
> > >
> > > This has been reported for the tyan_s2891 before:
> > >
> > > http://www.linuxbios.org/pipermail/linuxbios/2007-November/026649.html
> > >
> > > Did I something wrong?
> >
> > You didn't do anything wrong.  Jordan's response to my email was:
> >
> > "It looks like it got the ASFLAGS when it wanted the CFLAGS."
> >
> > I haven't looked at it more, but I hope that helps.
>
> The attached patch fixes the build for me.  I've included it
> separately (cross_compile.patch), and as a patch to buildrom
> (kbl_compile.patch).
>
> It looks like a case where make was too smart, so it used the
> assembler for the .S files, and the build environment hadn't
> overwritten the assembler flags.
>
> Myles
>
> Signed-off-by: Myles Watson

[LinuxBIOS] Broken build for kexec-boot-loader in buildrom x86_64?

[Andreas B. Mundt]

On Thu, Dec 13, 2007 at 08:56:22AM -0700, Myles Watson wrote:
> Did the patch work for anyone else?  Any concerns?

Hi Myles,

sorry for my late answer, I was away for a few days. Your patch works
for me (GA_M57SLI_S4, 32BIT-LAB, debian lenny amd64).

Thanks!

Andi
> On Dec 7, 2007 10:45 AM, Myles Watson  wrote:
> > On Dec 3, 2007 10:23 AM, Myles Watson  wrote:
> > > > buildrom gives me still an error when building kexec-boot-loader
> > > > (x86_64) for the m57sli:
> > > >
> > > > gcc --32    -c -o kexec/x86-setup-32.o kexec/x86-setup-32.S
> > > > cc1: error: unrecognized command line option "-f32"
> > > >
> > > > This has been reported for the tyan_s2891 before:
> > > >
> > > > http://www.linuxbios.org/pipermail/linuxbios/2007-November/026649.html
> > > >
> > > > Did I something wrong?
> > >
> > > You didn't do anything wrong.  Jordan's response to my email was:
> > >
> > > "It looks like it got the ASFLAGS when it wanted the CFLAGS."
> > >
> > > I haven't looked at it more, but I hope that helps.
> >
> > The attached patch fixes the build for me.  I've included it
> > separately (cross_compile.patch), and as a patch to buildrom
> > (kbl_compile.patch).
> >
> > It looks like a case where make was too smart, so it used the
> > assembler for the .S files, and the build environment hadn't
> > overwritten the assembler flags.
> >
> > Myles
> >
> > Signed-off-by: Myles Watson

[LinuxBIOS] Broken build for kexec-boot-loader inbuildrom x86_64?

[Myles Watson]

> On Thu, Dec 13, 2007 at 08:56:22AM -0700, Myles Watson wrote:
> > Did the patch work for anyone else?  Any concerns?
>
> Hi Myles,
>
> sorry for my late answer, I was away for a few days. Your patch works
> for me (GA_M57SLI_S4, 32BIT-LAB, debian lenny amd64).
>
> Thanks!
>
> Andi

If you give me an "Acked-by:" line I'll commit it.

Myles
> > > The attached patch fixes the build for me.  I've included it
> > > separately (cross_compile.patch), and as a patch to buildrom
> > > (kbl_compile.patch).
> > >
> > > It looks like a case where make was too smart, so it used the
> > > assembler for the .S files, and the build environment hadn't
> > > overwritten the assembler flags.
> > >
> > > Myles
> > >
> > > Signed-off-by: Myles Watson

[LinuxBIOS] Broken build for kexec-boot-loader inbuildrom x86_64?

[Andreas B. Mundt]

On Wed, Dec 19, 2007 at 12:13:31PM -0700, Myles Watson wrote:
> > On Thu, Dec 13, 2007 at 08:56:22AM -0700, Myles Watson wrote:
> > > Did the patch work for anyone else?  Any concerns?
> >
> > Hi Myles,
> >
> > sorry for my late answer, I was away for a few days. Your patch works
> > for me (GA_M57SLI_S4, 32BIT-LAB, debian lenny amd64).
> >
> > Thanks!
> >
> > Andi
>
> If you give me an "Acked-by:" line I'll commit it.
>
> Myles

Acked-by: Andreas Mundt <andi.mundt at web.de>
> > > > The attached patch fixes the build for me.  I've included it
> > > > separately (cross_compile.patch), and as a patch to buildrom
> > > > (kbl_compile.patch).
> > > >
> > > > It looks like a case where make was too smart, so it used the
> > > > assembler for the .S files, and the build environment hadn't
> > > > overwritten the assembler flags.
> > > >
> > > > Myles
> > > >
> > > > Signed-off-by: Myles Watson

[LinuxBIOS] Broken build for kexec-boot-loader inbuildrom x86_64?

[Myles Watson]

> Acked-by: Andreas Mundt <andi.mundt at web.de>
> > > > > The attached patch fixes the build for me.  I've included it
> > > > > separately (cross_compile.patch), and as a patch to buildrom
> > > > > (kbl_compile.patch).
> > > > >
> > > > > It looks like a case where make was too smart, so it used the
> > > > > assembler for the .S files, and the build environment hadn't
> > > > > overwritten the assembler flags.
> > > > >
> > > > > Myles
> > > > >
> > > > > Signed-off-by: Myles Watson

Revision 86
Thanks,
Myles