[PATCH] buildrom: Add support for the ASUS A8N-E

[Uwe Hermann]

See patch.

Doesn't seem to build with LZMA enabled, only if you disable it. The
same seems to happen to all boards which don't have a Config-lab.lb
which should probably be fixed. IIRC LZMA should work regardless of
whether you have LAB as payload or not(?)

Uwe.

buildrom: Add support for the ASUS A8N-E

[Jordan Crouse]

On 01/10/08 23:33 +0200, Uwe Hermann wrote:
> See patch.
>
> Doesn't seem to build with LZMA enabled, only if you disable it. The
> same seems to happen to all boards which don't have a Config-lab.lb
> which should probably be fixed. IIRC LZMA should work regardless of
> whether you have LAB as payload or not(?)

LZMA in v2 needs options set in the Config.lb that happen to
be set in Config-lab.lb, so we sort of made the arbitrary decision to
just use that .lb if LZMA is enabled.  I dislike this solution immensely,
but I can't think of a good way to work around it unless we generate the
Config.lb at runtime, which has its own bug-a-bears.  Yet another
situation where v3 will save us all... :(

If you want to rename Config-lab.lb to something more descriptive, then
be my guest. You have my ack for that.

Jordan
> Add buildrom support for the ASUS A8N-E.
>
> Signed-off-by: Uwe Hermann

Acked-by: Jordan Crouse

buildrom: Add support for the ASUS A8N-E

[Uwe Hermann]

On Wed, Oct 01, 2008 at 03:58:59PM -0600, Jordan Crouse wrote:
> > Doesn't seem to build with LZMA enabled, only if you disable it. The
> > same seems to happen to all boards which don't have a Config-lab.lb
> > which should probably be fixed. IIRC LZMA should work regardless of
> > whether you have LAB as payload or not(?)
>
> LZMA in v2 needs options set in the Config.lb that happen to
> be set in Config-lab.lb, so we sort of made the arbitrary decision to
> just use that .lb if LZMA is enabled.  I dislike this solution immensely,
> but I can't think of a good way to work around it unless we generate the
> Config.lb at runtime, which has its own bug-a-bears.  Yet another
> situation where v3 will save us all... :(
>
> If you want to rename Config-lab.lb to something more descriptive, then
> be my guest. You have my ack for that.

Maybe Config-lzma.lb then. I might send a patch for that.
> > Signed-off-by: Uwe Hermann
>
> Acked-by: Jordan Crouse

Thanks, r243.

Uwe.

buildrom: Add support for the ASUS A8N-E

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Uwe Hermann
> Sent: Thursday, October 02, 2008 9:52 AM
> To: Jordan Crouse
> Cc: [e-mail]
> Subject: Re: [coreboot] buildrom: Add support for the ASUS A8N-E
>
> On Wed, Oct 01, 2008 at 03:58:59PM -0600, Jordan Crouse wrote:
> > > Doesn't seem to build with LZMA enabled, only if you disable it. The
> > > same seems to happen to all boards which don't have a Config-lab.lb
> > > which should probably be fixed. IIRC LZMA should work regardless of
> > > whether you have LAB as payload or not(?)
> >
> > LZMA in v2 needs options set in the Config.lb that happen to
> > be set in Config-lab.lb, so we sort of made the arbitrary decision to
> > just use that .lb if LZMA is enabled.  I dislike this solution
>
> immensely,
> > but I can't think of a good way to work around it unless we generate the
> > Config.lb at runtime, which has its own bug-a-bears.  Yet another
> > situation where v3 will save us all... :(

The original reason it was named Config-lab.lb was that some times it uses a
larger chip than is default on the board.  It also is generally
fallback-only to allow for the larger payload.
> > If you want to rename Config-lab.lb to something more descriptive, then
> > be my guest. You have my ack for that.
>
> Maybe Config-lzma.lb then. I might send a patch for that.

Definitely a better name.

Myles