[LinuxBIOS] [PATCH] Add includes to it8712f/superio.c

[Philipp Degler]

Hi,

we've tested the it8712f code, too. We see serial output on our ASUS a8ne. It 
is equiped with a ck804 SB  and 1GB of RAM and a Athlon64 CPU.

But we needed to set the clock to 24MHz in order to see valid serial output.

Index: src/superio/ite/it8712f/it8712f_early_serial.c
===================================================================
--- src/superio/ite/it8712f/it8712f_early_serial.c      (Revision 2507)
+++ src/superio/ite/it8712f/it8712f_early_serial.c      (Arbeitskopie)
@@ -78,7 +78,7 @@
        it8712f_sio_write(IT8712F_IR,   0x30, 0x1); /* Consumer IR */

/* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
-       /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); */
+       it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01);

/* Clear software suspend mode (clear bit 0). TODO: Needed? */
        /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */

Phil

On 11/26/06, Uwe Hermann <uwe <at> hermann-uwe.de> wrote:
> Hi,
>
> sorry for the delay.
>
> On Mon, Nov 20, 2006 at 05:17:25PM -0500, Jon Dufresne wrote:
> > Added two includes to it8712f/superio.c, the file will not compile without
> > them
> > Signed-off-by: Jon Dufresne <jon.dufresne <at> gmail.com>
> > Index: src/superio/ite/it8712f/superio.c
> >
> > --- src/superio/ite/it8712f/superio.c (revision 2498)
> > +++ src/superio/ite/it8712f/superio.c (working copy)
> >  <at>  <at>  -18,6 +18,8  <at>  <at>
> > Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301

USA
> > */
> >
> > +#include <device/device.h>
> > +#include <device/pnp.h>
> >  #include <uart8250.h>
> >  #include <pc80/keyboard.h>
> >  #include "chip.h"
>
> All other ITE Super I/Os will have the same problem, I guess. I probably
> didn't notice this as the #includes are drawn in in some other file,
> too, on the mainboard code I used.
>
> Can you crate a patch which fixes all of the ITEs, adding all required
> #includes to all files (mostly superio.c and chip.h)?
>
> Please also note, that I didn't test any of the ITE chips other than
> IT8671F, so they may or may not work. If you could test serial output, that
> would be very nice. Anything other than serial output (floppy, keyboard,
> whatever) I haven't tested _at all_, and partly there's not even any
> code written for that, yet (but it's not too hard)...
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (GNU/Linux)
>
> iD8DBQFFaczrXdVoV3jWIbQRApD3AJ9/8cF0a1X7d/RHvKLgc4cT9VSXKgCgiDiK
> 8kAUYJMb5GdXuxsjWpONTmE=
> =eSfo
> -----END PGP SIGNATURE-----

[Jon Dufresne]

Thanks for that tip/patch. I was wondering why my console had an
unpredictable baud rate. This fixed it.

Jon

On 11/29/06, Philipp Degler  wrote:
> Hi,
>
> we've tested the it8712f code, too. We see serial output on our ASUS a8ne. It
> is equiped with a ck804 SB  and 1GB of RAM and a Athlon64 CPU.
>
> But we needed to set the clock to 24MHz in order to see valid serial output.
> Index: src/superio/ite/it8712f/it8712f_early_serial.c
>
> --- src/superio/ite/it8712f/it8712f_early_serial.c      (Revision 2507)
> +++ src/superio/ite/it8712f/it8712f_early_serial.c      (Arbeitskopie)
> @@ -78,7 +78,7 @@
>         it8712f_sio_write(IT8712F_IR,   0x30, 0x1); /* Consumer IR */
>     /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
>   /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); */
>   it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01);
>
>   /* Clear software suspend mode (clear bit 0). TODO: Needed? */
>   /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */
>
>
> Phil
>
> On 11/26/06, Uwe Hermann <uwe <at> hermann-uwe.de> wrote:
> > Hi,
> >
> > sorry for the delay.
> >
> > On Mon, Nov 20, 2006 at 05:17:25PM -0500, Jon Dufresne wrote:
> > > Added two includes to it8712f/superio.c, the file will not compile without
> > > them
> > > Signed-off-by: Jon Dufresne <jon.dufresne <at> gmail.com>
> > > Index: src/superio/ite/it8712f/superio.c
> > >
> > > --- src/superio/ite/it8712f/superio.c (revision 2498)
> > > +++ src/superio/ite/it8712f/superio.c (working copy)
> > >  <at>  <at>  -18,6 +18,8  <at>  <at>
> > > Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301
>
> USA
> > > */
> > >
> > > +#include <device/device.h>
> > > +#include <device/pnp.h>
> > >  #include <uart8250.h>
> > >  #include <pc80/keyboard.h>
> > >  #include "chip.h"
> >
> > All other ITE Super I/Os will have the same problem, I guess. I probably
> > didn't notice this as the #includes are drawn in in some other file,
> > too, on the mainboard code I used.
> >
> > Can you crate a patch which fixes all of the ITEs, adding all required
> > #includes to all files (mostly superio.c and chip.h)?
> >
> > Please also note, that I didn't test any of the ITE chips other than
> > IT8671F, so they may or may not work. If you could test serial output, that
> > would be very nice. Anything other than serial output (floppy, keyboard,
> > whatever) I haven't tested _at all_, and partly there's not even any
> > code written for that, yet (but it's not too hard)...
> > Uwe.
> >
> > http://www.hermann-uwe.de  | http://www.holsham-traders.de
> > http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.5 (GNU/Linux)
> >
> > iD8DBQFFaczrXdVoV3jWIbQRApD3AJ9/8cF0a1X7d/RHvKLgc4cT9VSXKgCgiDiK
> > 8kAUYJMb5GdXuxsjWpONTmE=
> > =eSfo
> > -----END PGP SIGNATURE-----

[ron minnich]

On 11/29/06, Jon Dufresne  wrote:
> Thanks for that tip/patch. I was wondering why my console had an
> unpredictable baud rate. This fixed it.

Hi, ,just checking, this got comitted right?

thanks

ron

[LinuxBIOS] [PATCH] Set CLKIN to 24 MHz for ITE Super I/Os

[Uwe Hermann]

Explicitly set the CLKIN to 24 MHz on all ITE Super I/Os, otherwise
serial output might not always work (correctly).
Thanks Philipp Degler  for testing and
reporting this issue.

Signed-off-by: Uwe Hermann

---

On Wed, Nov 29, 2006 at 01:51:27PM +0100, Philipp Degler wrote:
> we've tested the it8712f code, too. We see serial output on our ASUS a8ne. It 
> is equiped with a ck804 SB  and 1GB of RAM and a Athlon64 CPU.
>
> But we needed to set the clock to 24MHz in order to see valid serial output.
> Index: src/superio/ite/it8712f/it8712f_early_serial.c
>
> --- src/superio/ite/it8712f/it8712f_early_serial.c      (Revision 2507)
> +++ src/superio/ite/it8712f/it8712f_early_serial.c      (Arbeitskopie)
> @@ -78,7 +78,7 @@
>         it8712f_sio_write(IT8712F_IR,   0x30, 0x1); /* Consumer IR */
>     /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
>   /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); */
>   it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01);
>
>   /* Clear software suspend mode (clear bit 0). TODO: Needed? */
>   /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */

Thanks a lot!

For the next patch please add a sign-off line, otherwise we cannot
commit your patch. See also
http://www.linuxbios.org/Development_Guidelines

Cheers, Uwe.