Re: [coreboot] [v2] r4863 - trunk/coreboot-v2/src/arch/i386/lib

[Myles Watson]

On Mon, Oct 26, 2009 at 11:17 AM,  wrote:
> Author: stepan
> Date: 2009-10-26 18:17:37 +0100 (Mon, 26 Oct 2009)
> New Revision: 4863
>
> Modified:
>   trunk/coreboot-v2/src/arch/i386/lib/cbfs_and_run.c
> Log:
> reasonable output in cbfs loading (part 2)
> run hlt in endless loop, be friendly to the cpu
>
> Signed-off-by: Stefan Reinauer 
> Acked-by: Stefan Reinauer
>   print_debug("Jumping to image.\n");
>  __asm__ volatile (
>           "movl %%eax, %%ebp\n\t"
>           "cli\n\t"

I didn't see this mentioned in the commit message.

Thanks,
Myles
>           "jmp     *%%edi\n\t"
>           "movl %%eax, %%ebp\n"
>           "jmp  *%%edi\n"
>          :: "a"(ebp), "D"(dst)
>  );
>
> }

[v2] r4863 - trunk/coreboot-v2/src/arch/i386/lib

[Stefan Reinauer]

Myles Watson wrote:
> On Mon, Oct 26, 2009 at 11:17 AM, <[e-mail]
> > wrote:
> Author: stepan
> Date: 2009-10-26 18:17:37 +0100 (Mon, 26 Oct 2009)
> New Revision: 4863
>
> Modified:
>   trunk/coreboot-v2/src/arch/i386/lib/cbfs_and_run.c
> Log:
> reasonable output in cbfs loading (part 2)
> run hlt in endless loop, be friendly to the cpu
>
> Signed-off-by: Stefan Reinauer <[e-mail]
> <mailto:[e-mail]>>
> Acked-by: Stefan Reinauer <[e-mail]
> <mailto:[e-mail]>>
>
>
>
>
> +       print_debug("Jumping to image.\n");
>        __asm__ volatile (
> -               "movl %%eax, %%ebp\n\t"
>
>
>
> -               "cli\n\t"
>
> I didn't see this mentioned in the commit message.

Sorry, missed it... cli is not needed here. We called cli before, and
never call sti (on purpose)
Anyways, if cli were necessary, that function would not be the place for
it to go.

Stefan

[v2] r4863 - trunk/coreboot-v2/src/arch/i386/lib

[Myles Watson]

> > -               "cli\n\t"
> >
> > I didn't see this mentioned in the commit message.
>
> Sorry, missed it... cli is not needed here. We called cli before, and
> never call sti (on purpose)
> Anyways, if cli were necessary, that function would not be the place for
> it to go.

No problem.  Thanks for the explanation.

Myles