[PATCH] Dump some more registers for Winbond W83627DHG

[Prakash Punnoor]

Hi,

I noticed some registers of Winbond W83627DHG, which the datasheet mentions, 
were not dumped by superiotool. This patch adds those registers to the dump.

Signed-off-by: Prakash Punnoor

[PATCH] Dump some more registers for Winbond W83627DHG

[Prakash Punnoor]

So nobody is interested in the patch?

On Friday 11 March 2011 11:28:54 Prakash Punnoor wrote:
> Hi,
>
> I noticed some registers of Winbond W83627DHG, which the datasheet
> mentions, were not dumped by superiotool. This patch adds those registers
> to the dump.
>
> Signed-off-by: Prakash Punnoor

[PATCH] Dump some more registers for Winbond W83627DHG

[Marc Jones]

On Fri, Mar 25, 2011 at 4:24 AM, Prakash Punnoor  wrote:
> So nobody is interested in the patch?
>
> On Friday 11 March 2011 11:28:54 Prakash Punnoor wrote:
> > Hi,
> >
> > I noticed some registers of Winbond W83627DHG, which the datasheet
> > mentions, were not dumped by superiotool. This patch adds those registers
> > to the dump.
> >
> > Signed-off-by: Prakash Punnoor

Thanks for the contribution and for the reminder.

Acked-by: Marc Jones

r6460

[Uwe Hermann]

Hi,

On Fri, Mar 25, 2011 at 10:55:21AM -0600, Marc Jones wrote:
> > > Signed-off-by: Prakash Punnoor
>
> Thanks for the contribution and for the reminder.
>
> Acked-by: Marc Jones

Yup, thanks! However, the patch is not quite correct, I think.

The last datasheet (from Winbond) for the "W83627DHG" doesn't mention
those registers, the superiotool list was correct.

However, you likely looked at the new "W83627DHG-P/-PT" datasheet from
Nuvoton (which now owns the Winbond Super I/O stuff):

http://www.nuvoton.com/NuvotonMOSS/Community/ProductInfo.aspx?tp_GUID=0516ba...

But, this is a different chip from the "W83627DHG". The original
Winbond W83627DHG has the ID bytes 0xa0 / 0x2y (y is the revision).
The Nuvoton W83627DHG-P/-PT has the IDs 0xb0 / 0x7y (y is the revision).
Thus, these are two different chips.

Prakash, let us know if you want to work on a patch which reverts your
last changes and adds a new entry for the Nuvoton W83627DHG-P/-PT instead.
Otherwise I might do it when I have some spare time.

But please carefully check all registers and their default values. While
many may be similar to the old W83627DHG there may also be various other
differences in the W83627DHG-P/-PT. You have to check each value.

Thanks, Uwe.

[PATCH] Dump some more registers for Winbond W83627DHG

[Prakash Punnoor]

Hi,

On Monday 28 March 2011 19:46:08 Uwe Hermann wrote:
> Hi,
>
> On Fri, Mar 25, 2011 at 10:55:21AM -0600, Marc Jones wrote:
> > > > Signed-off-by: Prakash Punnoor
> >
> > Thanks for the contribution and for the reminder.
> >
> > Acked-by: Marc Jones
>
> Yup, thanks! However, the patch is not quite correct, I think.
>
> The last datasheet (from Winbond) for the "W83627DHG" doesn't mention
> those registers, the superiotool list was correct.
>
> However, you likely looked at the new "W83627DHG-P/-PT" datasheet from
> Nuvoton (which now owns the Winbond Super I/O stuff):
>
> http://www.nuvoton.com/NuvotonMOSS/Community/ProductInfo.aspx?tp_GUID=0516b
> a91-bd6d-436c-9378-a371cd463afb

Ouch, yes, well observed. I missed that little difference. I indeed had the 
latter datasheet. I'll try to cook up a new patch.

@Marc

Please revert my patch in the meantime. Sorry for the confusion.

bye,

Prakash

[PATCH] Dump some more registers for Winbond W83627DHG

[Prakash Punnoor]

Hi,

On Monday 28 March 2011 21:08:54 Prakash Punnoor wrote:
> @Marc
>
> Please revert my patch in the meantime. Sorry for the confusion.

So, here's the patch. I did following: I checked both datasheets side by side 
and added the differences to a copy of the original values. In fact - except 
the id registers - there are no differences, only additions. But I noticed I 
missed some in my original patch...

This patch adds support for dumping registers of Nuvoton W83627DHG-P/-PT.

Signed-off-by: Prakash Punnoor

[Uwe Hermann]

On Mon, Mar 28, 2011 at 09:48:43PM +0200, Prakash Punnoor wrote:
> This patch adds support for dumping registers of Nuvoton W83627DHG-P/-PT.
>
> Signed-off-by: Prakash Punnoor

Thanks, committed as r6468, including the revert of the last patch.

I cross-checked against the datasheets too, noticed one small change
that's needed, but that is a problem in W83627DHG too, will fix that
in a separate commit.

Uwe.

[PATCH] Dump some more registers for Winbond W83627DHG

[Marc Jones]

On Tue, Mar 29, 2011 at 6:03 AM, Uwe Hermann  wrote:
> On Mon, Mar 28, 2011 at 09:48:43PM +0200, Prakash Punnoor wrote:
> > This patch adds support for dumping registers of Nuvoton W83627DHG-P/-PT.
> >
> > Signed-off-by: Prakash Punnoor
>
> Thanks, committed as r6468, including the revert of the last patch.
>
> I cross-checked against the datasheets too, noticed one small change
> that's needed, but that is a problem in W83627DHG too, will fix that
> in a separate commit.

Thanks Uwe.