[LinuxBIOS] License header for src/cpu/amd/model_lx/cpubug.c

[Jordan Crouse]

This patch adds the common license header to src/cpu/amd/model_lx/cpubug.c.
The original authors are CCed, I would appreciate it if they would respond
to this email with their agreement.

Jordan

[LinuxBIOS] License header for src/cpu/amd/model_lx/cpureginit.c

[Jordan Crouse]

This patch adds the common license header to
src/cpu/amd/model_lx/cpureginit.c
The original authors are CCed, I would appreciate it if they would respond
to this email with their agreement.

[LinuxBIOS] License header for src/cpu/amd/model_lx/cpureginit.c

[ron minnich]

I am fine with this. I think I am the original author, as it came from
the model_gx port.

You can change it to Ronald G. Minnich

thanks

ron

On 5/1/07, Jordan Crouse  wrote:
> This patch adds the common license header to
> src/cpu/amd/model_lx/cpureginit.c
> The original authors are CCed, I would appreciate it if they would respond
> to this email with their agreement.
> Index: LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c
>
> --- LinuxBIOSv2.orig/src/cpu/amd/model_lx/cpureginit.c  2007-05-01 18:13:54.000000000 -0600
> +++ LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c       2007-05-01 18:14:00.000000000 -0600
> @@ -1,3 +1,25 @@
> +/*
> This file is part of the LinuxBIOS project.
> Indrek Kruusa, [e-mail]
> Ronald Minnich
> Copyright (C) 2007, Advanced Micro Devices, Inc.
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> /* ***************************************************************************/
>  /* **/
>  /* *   BIST */

[Uwe Hermann]

Hi Jordan!

On Tue, May 01, 2007 at 06:05:03PM -0600, Jordan Crouse wrote:
> This patch adds the common license header to src/cpu/amd/model_lx/cpubug.c.
> The original authors are CCed, I would appreciate it if they would respond
> to this email with their agreement.

Thanks for posting these! Please use the common header format, though.

I.e., email-addresses and names as "John Doe ", add the
"Copyright (C) xxxx" for all entries. The year(s) must be recorded in
all entries -- you might have to dig in the svn history to get them...

Also, it would be nice to list one or more "real" persons from AMD as
contributors of the code (they may not own the copyright -- AMD does -- but
it would still be good to have the real author of the code listed
with email address so we know who to ask questions etc.).

So, something like this:
> Copyright (C) xxxx Indrek Kruusa
> Copyright (C) xxxx Ronald G. Minnich
> Copyright (C) 2007 Advanced Micro Devices, Inc.
> (Written by Janet Doe  for AMD)

(you can post a single patch with all the changes btw; no need to split this
up in multiple patches)

Cheers, Uwe.

[Jordan Crouse]

On 02/05/07 02:48 +0200, Uwe Hermann wrote:
> Hi Jordan!
>
> On Tue, May 01, 2007 at 06:05:03PM -0600, Jordan Crouse wrote:
> > This patch adds the common license header to src/cpu/amd/model_lx/cpubug.c.
> > The original authors are CCed, I would appreciate it if they would respond
> > to this email with their agreement.
>
> Thanks for posting these! Please use the common header format, though.
>
> I.e., email-addresses and names as "John Doe ", add the
> "Copyright (C) xxxx" for all entries. The year(s) must be recorded in
> all entries -- you might have to dig in the svn history to get them...

I put as much as I could glean from the svn history.  Again, I can't
really assign copyright automatically for somebody.  I will add 
copyright information for any of the original authors if they ask me
to, though.
> Also, it would be nice to list one or more "real" persons from AMD as
> contributors of the code (they may not own the copyright -- AMD does -- but
> it would still be good to have the real author of the code listed
> with email address so we know who to ask questions etc.).

Most of this code was derived from our internal code base, with dozens of
authors - it wouldn't be really fair to single anybody out.  We would
prefer that everybody use the mailing list for questions - the current LB
developers for AMD will always be there.

Jordan

[ron minnich]

Let's leave the copyright AMD (i.e. no people), then, and I approve the header.

If we don't hear from Indrek in a few days, I will approve for him as
this code originally came from our olpc port.

I would also like to thank AMD for this fine work. I think Marc Jones
and Jordan have raised the bar for LinuxBIOS ports. I will be using
this code as a benchmark implementation for V3. Study this code,
folks, and study the POST codes that Marc put in. It's a very, very
professional piece of work, and I'm learning a lot. I am porting this
code to another board and it "just works".

Please, let's get this code in ASAP. This was many, many months of
work at AMD. AMD has made a huge contribution here to LinuxBIOS, let's
make sure we support them in every way we can! Let's help them get
this code in.

Also, note, this code uses Cache As Ram!

thanks

ron

[Indrek Kruusa]

Ühel kenal päeval (kolmapäev 02 mai 2007 7:41 pm) kirjutas ron minnich:
> Let's leave the copyright AMD (i.e. no people), then, and I approve the
> header.

Agreed, for this header and for others too.

thanks,
Indrek

[Uwe Hermann]

On Tue, May 01, 2007 at 07:10:20PM -0600, Jordan Crouse wrote:
> > Also, it would be nice to list one or more "real" persons from AMD as
> > contributors of the code (they may not own the copyright -- AMD does -- but
> > it would still be good to have the real author of the code listed
> > with email address so we know who to ask questions etc.).
>
> Most of this code was derived from our internal code base, with dozens of
> authors - it wouldn't be really fair to single anybody out.  We would
> prefer that everybody use the mailing list for questions - the current LB
> developers for AMD will always be there.

Of, course! I didn't mean we should pester AMD developers with private
support mails all the time ;) Any LinuxBIOS-related discussion should
take place on this list, of course.

Uwe.