#98: Eliminate false positive "unknown .. SPI chip" matches ----------------------------------+----------------------------------------- Reporter: stuge | Owner: somebody Type: defect | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Keywords: spi probe | Dependencies: #97 Patchstatus: patch needs review | ----------------------------------+-----------------------------------------
#98: Eliminate false positive "unknown .. SPI chip" matches -------------------------+-------------------------------------------------- Reporter: stuge | Owner: somebody Type: defect | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: spi probe Dependencies: #97 | Patchstatus: patch needs review -------------------------+--------------------------------------------------
Comment(by hailfinger):
Can you match on the probing function instead? That would introduce less regressions.
#98: Eliminate false positive "unknown .. SPI chip" matches -------------------------+-------------------------------------------------- Reporter: stuge | Owner: somebody Type: defect | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: spi probe Dependencies: #97 | Patchstatus: patch needs review -------------------------+--------------------------------------------------
Comment(by stepan):
Acked-by: Stefan Reinauer stepan@coresystems.de
#98: Eliminate false positive "unknown .. SPI chip" matches -------------------------+-------------------------------------------------- Reporter: stuge | Owner: stuge Type: defect | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: spi probe Dependencies: #97 | Patchstatus: patch is ready to be committed -------------------------+-------------------------------------------------- Changes (by stepan):
* owner: somebody => stuge * patchstatus: patch needs review => patch is ready to be committed
#98: Eliminate false positive "unknown .. SPI chip" matches -------------------------+-------------------------------------------------- Reporter: stuge | Owner: stuge Type: defect | Status: closed Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: fixed | Keywords: spi probe Dependencies: #97 | Patchstatus: patch has been committed -------------------------+-------------------------------------------------- Changes (by stuge):
* status: new => closed * patchstatus: patch is ready to be committed => patch has been committed * resolution: => fixed
Comment:
Thanks! Committed in r3562.
-
coreboot