[PATCH]i82830 custom vga driver

[Joseph Smith]

This patch allows a custom vga driver that will give the flexibility to run
code after vga is initialized for tv-out. It is one of many patches to
come, including code to manipulate the graphics mmio registers, enable the
graphics i2c data lines, and tv encoder drivers.

Signed-off-by: Joseph Smith

[Myles Watson]

On Thu, Apr 30, 2009 at 9:52 PM, Joseph Smith  wrote:
> This patch allows a custom vga driver that will give the flexibility to run
> code after vga is initialized for tv-out. It is one of many patches to
> come, including code to manipulate the graphics mmio registers, enable the
> graphics i2c data lines, and tv encoder drivers.

Should it be conditionally included via a config option?  Are there
other boards with the same chipset that won't want to use this TV-out
initialization?

Acked-by: Myles Watson

Thanks,
Myles

[ron minnich]

I don't know enough about boards that use this chip. But I do think
you might want to at least check Myle's suggestion that there be a
conditonal in the Config.lb.

OTOH, how many targets actively use this part (meaning are those
boards in use today or ...)

ron

[Joseph Smith]

On Thu, 30 Apr 2009 22:06:26 -0600, Myles Watson  wrote:
> On Thu, Apr 30, 2009 at 9:52 PM, Joseph Smith

wrote:
> > This patch allows a custom vga driver that will give the flexibility to
>
> run
> > code after vga is initialized for tv-out. It is one of many patches to
> > come, including code to manipulate the graphics mmio registers, enable
>
> the
> > graphics i2c data lines, and tv encoder drivers.
>
> Should it be conditionally included via a config option?  Are there
> other boards with the same chipset that won't want to use this TV-out
> initialization?

Yup there will be, I hopefully I am going to try to make the code generic
enough so it can be used with other Intel 8xx and 9xx chipsets (alot of the
mmio registers are the same) and put it in a common locattion. Also the
tv-out drivers will open the door for other tv encoder chips, and LVDS
chips for laptops (this means things like blacklight control), etc. Anyways
the idea is to have a global config option for the tv chip, that way it
will know which code to run and if global config option is not defined it
will run just as the patch is now, the default vga init.

[Joseph Smith]

On Thu, 30 Apr 2009 22:06:26 -0600, Myles Watson  wrote:
> On Thu, Apr 30, 2009 at 9:52 PM, Joseph Smith

wrote:
> > This patch allows a custom vga driver that will give the flexibility to
>
> run
> > code after vga is initialized for tv-out. It is one of many patches to
> > come, including code to manipulate the graphics mmio registers, enable
>
> the
> > graphics i2c data lines, and tv encoder drivers.
>
> Should it be conditionally included via a config option?  Are there
> other boards with the same chipset that won't want to use this TV-out
> initialization?
>
> Acked-by: Myles Watson

Thanks r4244

[Joseph Smith]

On Thu, 30 Apr 2009 21:17:26 -0700, ron minnich  wrote:
> I don't know enough about boards that use this chip. But I do think
> you might want to at least check Myle's suggestion that there be a
> conditonal in the Config.lb.
>
> OTOH, how many targets actively use this part (meaning are those
> boards in use today or ...)

Just the IP1000 and RM4100 so far...

[Stefan Reinauer]

On 01.05.2009 6:06 Uhr, Myles Watson wrote:
> On Thu, Apr 30, 2009 at 9:52 PM, Joseph Smith  wrote:
> > This patch allows a custom vga driver that will give the flexibility to run
> > code after vga is initialized for tv-out. It is one of many patches to
> > come, including code to manipulate the graphics mmio registers, enable the
> > graphics i2c data lines, and tv encoder drivers.
>
> Should it be conditionally included via a config option?  Are there
> other boards with the same chipset that won't want to use this TV-out
> initialization?

Please, no more CONFIG flags.

- If it's a property of the board / northbridge, it should be a variable
in the chip's config structure

- there's no real code in that function, so there's not much sense to
make anything conditional yet.

Stefan

[Joseph Smith]

On Fri, 01 May 2009 11:22:24 +0200, Stefan Reinauer 
wrote:
> On 01.05.2009 6:06 Uhr, Myles Watson wrote:
> > On Thu, Apr 30, 2009 at 9:52 PM, Joseph Smith
>
> wrote:
> > > This patch allows a custom vga driver that will give the flexibility to
>
> run
> > > code after vga is initialized for tv-out. It is one of many patches to
> > > come, including code to manipulate the graphics mmio registers, enable
>
> the
> > > graphics i2c data lines, and tv encoder drivers.
> >
> > Should it be conditionally included via a config option?  Are there
> > other boards with the same chipset that won't want to use this TV-out
> > initialization?
>
> Please, no more CONFIG flags.
> If it's a property of the board / northbridge, it should be a variable
>
> in the chip's config structure

Ok that sound better.
> there's no real code in that function, so there's not much sense to
>
> make anything conditional yet.

Right, it doesn't do anything extra yet, I am just setting the stage for
what is to come, because vga.c is going to be where all the code is called
from, kind of like a sub main() if you will.

[ron minnich]

What's the problem with doing this?

if CONFIG_CONSOLE_VGA
        driver vga.o
end