[LinuxBIOS] r2513 - in trunk/LinuxBIOSv2/src/superio/ite: it8673f it8705f it8712f it8716f it8718f

Author: uwe
Date: 2006-12-01 14:14:55 +0100 (Fri, 01 Dec 2006)
New Revision: 2513

Modified:
   trunk/LinuxBIOSv2/src/superio/ite/it8673f/it8673f_early_serial.c
   trunk/LinuxBIOSv2/src/superio/ite/it8705f/it8705f_early_serial.c
   trunk/LinuxBIOSv2/src/superio/ite/it8712f/it8712f_early_serial.c
   trunk/LinuxBIOSv2/src/superio/ite/it8716f/it8716f_early_serial.c
   trunk/LinuxBIOSv2/src/superio/ite/it8718f/it8718f_early_serial.c
Log:
Explicitly set the CLKIN to 24 MHz on all ITE Super I/Os, otherwise
serial output might not always work correctly (trivial).

Thanks Philipp Degler <[e-mail]> for testing and
reporting this issue.

Signed-off-by: Uwe Hermann <[e-mail]>
Acked-by: Uwe Hermann <[e-mail]>



Modified: trunk/LinuxBIOSv2/src/superio/ite/it8673f/it8673f_early_serial.c
===================================================================
--- trunk/LinuxBIOSv2/src/superio/ite/it8673f/it8673f_early_serial.c	2006-12-01 09:41:11 UTC (rev 2512)
+++ trunk/LinuxBIOSv2/src/superio/ite/it8673f/it8673f_early_serial.c	2006-12-01 13:14:55 UTC (rev 2513)
@@ -86,7 +86,7 @@
 	it8673f_sio_write(IT8673F_KBCK, 0x30, 0x1); /* Keyboard */
 	it8673f_sio_write(IT8673F_KBCM, 0x30, 0x1); /* Mouse */
 
-	/* Select 24MHz CLKIN (clear bit 0). TODO: is this really needed? */
+	/* Select 24MHz CLKIN (clear bit 0). */
 	it8673f_sio_write(0x00, IT8673F_CONFIG_REG_CLOCKSEL, 0x00);
 
 	/* Clear software suspend mode (clear bit 0). */

Modified: trunk/LinuxBIOSv2/src/superio/ite/it8705f/it8705f_early_serial.c
===================================================================
--- trunk/LinuxBIOSv2/src/superio/ite/it8705f/it8705f_early_serial.c	2006-12-01 09:41:11 UTC (rev 2512)
+++ trunk/LinuxBIOSv2/src/superio/ite/it8705f/it8705f_early_serial.c	2006-12-01 13:14:55 UTC (rev 2513)
@@ -78,8 +78,8 @@
 	it8705f_sio_write(IT8705F_IR,   0x30, 0x1); /* Consumer IR */
 	it8705f_sio_write(IT8705F_MIDI, 0x30, 0x1); /* MIDI port */
 
-	/* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
-	/* it8705f_sio_write(0x00, IT8705F_CONFIG_REG_CLOCKSEL, 0x01); */
+	/* Select 24MHz CLKIN (set bit 0). */
+	it8705f_sio_write(0x00, IT8705F_CONFIG_REG_CLOCKSEL, 0x01);
 
 	/* Clear software suspend mode (clear bit 0). TODO: Needed? */
 	/* it8705f_sio_write(0x00, IT8705F_CONFIG_REG_SWSUSP, 0x00); */

Modified: trunk/LinuxBIOSv2/src/superio/ite/it8712f/it8712f_early_serial.c
===================================================================
--- trunk/LinuxBIOSv2/src/superio/ite/it8712f/it8712f_early_serial.c	2006-12-01 09:41:11 UTC (rev 2512)
+++ trunk/LinuxBIOSv2/src/superio/ite/it8712f/it8712f_early_serial.c	2006-12-01 13:14:55 UTC (rev 2513)
@@ -78,8 +78,8 @@
 	it8712f_sio_write(IT8712F_GAME, 0x30, 0x1); /* GAME port */
 	it8712f_sio_write(IT8712F_IR,   0x30, 0x1); /* Consumer IR */
 
-	/* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
-	/* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); */
+	/* Select 24MHz CLKIN (set bit 0). */
+	it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01);
 
 	/* Clear software suspend mode (clear bit 0). TODO: Needed? */
 	/* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */

Modified: trunk/LinuxBIOSv2/src/superio/ite/it8716f/it8716f_early_serial.c
===================================================================
--- trunk/LinuxBIOSv2/src/superio/ite/it8716f/it8716f_early_serial.c	2006-12-01 09:41:11 UTC (rev 2512)
+++ trunk/LinuxBIOSv2/src/superio/ite/it8716f/it8716f_early_serial.c	2006-12-01 13:14:55 UTC (rev 2513)
@@ -78,8 +78,8 @@
 	it8716f_sio_write(IT8716F_GAME, 0x30, 0x1); /* GAME port */
 	it8716f_sio_write(IT8716F_IR,   0x30, 0x1); /* Consumer IR */
 
-	/* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
-	/* it8716f_sio_write(0x00, IT8716F_CONFIG_REG_CLOCKSEL, 0x01); */
+	/* Select 24MHz CLKIN (set bit 0). */
+	it8716f_sio_write(0x00, IT8716F_CONFIG_REG_CLOCKSEL, 0x01);
 
 	/* Clear software suspend mode (clear bit 0). TODO: Needed? */
 	/* it8716f_sio_write(0x00, IT8716F_CONFIG_REG_SWSUSP, 0x00); */

Modified: trunk/LinuxBIOSv2/src/superio/ite/it8718f/it8718f_early_serial.c
===================================================================
--- trunk/LinuxBIOSv2/src/superio/ite/it8718f/it8718f_early_serial.c	2006-12-01 09:41:11 UTC (rev 2512)
+++ trunk/LinuxBIOSv2/src/superio/ite/it8718f/it8718f_early_serial.c	2006-12-01 13:14:55 UTC (rev 2513)
@@ -76,8 +76,8 @@
 	it8718f_sio_write(IT8718F_KBCM, 0x30, 0x1); /* Mouse */
 	it8718f_sio_write(IT8718F_IR,   0x30, 0x1); /* Consumer IR */
 
-	/* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
-	/* it8718f_sio_write(0x00, IT8718F_CONFIG_REG_CLOCKSEL, 0x01); */
+	/* Select 24MHz CLKIN (set bit 0). */
+	it8718f_sio_write(0x00, IT8718F_CONFIG_REG_CLOCKSEL, 0x01);
 
 	/* Clear software suspend mode (clear bit 0). TODO: Needed? */
 	/* it8718f_sio_write(0x00, IT8718F_CONFIG_REG_SWSUSP, 0x00); */