[PATCH] The PC buzzer for TIM-5690.

[Libra Li]

Hi,

This information mean initially with control PC speaker through AMD
SB600.
    Please reference appendent file.
    Thanks.

Signed-off-by: Libra Li

[Bao, Zheng]

Should the spkr.c be in the folder sb600, or more public folders like
pc80?

Zheng

________________________________

From: [e-mail]
[mailto:[e-mail]] On Behalf Of Libra Li
Sent: Monday, November 23, 2009 11:26 AM
To: coreboot
Subject: [coreboot] [PATCH] The PC buzzer for TIM-5690.

Hi,

This information mean initially with control PC speaker through AMD
SB600.
    Please reference appendent file.
    Thanks.

Signed-off-by: Libra Li <libra.li http://libra.li/ @technexion.com
http://technexion.com/ >

[Libra Li]

Hi,
    This function is a early function. The pc80 is after early function. Do
you think where does it need in?
    Thanks

2009/11/23 Bao, Zheng
> Should the spkr.c be in the folder sb600, or more public folders like
> pc80?
>
> Zheng
>
> *From:* [e-mail] [mailto:
> [e-mail]] *On Behalf Of *Libra Li
> *Sent:* Monday, November 23, 2009 11:26 AM
> *To:* coreboot
> *Subject:* [coreboot] [PATCH] The PC buzzer for TIM-5690.
>
> Hi,
> This information mean initially with control PC speaker through AMD
>
> SB600.
>     Please reference appendent file.
>     Thanks.
>
> Signed-off-by: Libra Li

[Libra Li]

Sorry, my English is bad.
I mean ... It should be placed there?

2009/11/23 Libra Li
> Hi,
>     This function is a early function. The pc80 is after early function. Do
> you think where does it need in?
>     Thanks
>
> 2009/11/23 Bao, Zheng
>
> Should the spkr.c be in the folder sb600, or more public folders like
> > pc80?
> >
> > Zheng
> >
> > *From:* [e-mail] [mailto:
> > [e-mail]] *On Behalf Of *Libra Li
> > *Sent:* Monday, November 23, 2009 11:26 AM
> > *To:* coreboot
> > *Subject:* [coreboot] [PATCH] The PC buzzer for TIM-5690.
> >
> > Hi,
> > This information mean initially with control PC speaker through AMD
> >
> > SB600.
> >     Please reference appendent file.
> >     Thanks.
> >
> > Signed-off-by: Libra Li

[Bao, Zheng]

Since you need to call it in early stage, it is not good to put in pc80.

Could it run after early stage?

Zheng

________________________________

From: Libra Li [mailto:[e-mail]] 
Sent: Monday, November 23, 2009 6:05 PM
To: Bao, Zheng; coreboot
Subject: Re: [coreboot] [PATCH] The PC buzzer for TIM-5690.

Sorry, my English is bad.
I mean ... It should be placed there?

2009/11/23 Libra Li

Hi,
    This function is a early function. The pc80 is after early function.
Do you think where does it need in?
    Thanks

2009/11/23 Bao, Zheng

Should the spkr.c be in the folder sb600, or more public folders
like pc80?

Zheng

________________________________

From: [e-mail]
[mailto:[e-mail]] On Behalf Of Libra Li
    Sent: Monday, November 23, 2009 11:26 AM
    To: coreboot
    Subject: [coreboot] [PATCH] The PC buzzer for TIM-5690.

Hi,
    
        This information mean initially with control PC speaker
through AMD SB600.
        Please reference appendent file.
        Thanks.
    
    Signed-off-by: Libra Li <libra.li http://libra.li/
@technexion.com http://technexion.com/ >

[Stefan Reinauer]

On 11/23/09 11:08 AM, Bao, Zheng wrote:
> Since you need to call it in early stage, it is not good to put in pc80.

I don't think this is a problem... There is other code in src/pc80 that
runs in early stage, like mc4168rtc_early.c and usbdebug_direct_serial.c

src/pc80 seems like a better place than src/arch/i386, since the other
pc legacy stuff like rtc, isa-dma, serial, interrupt controller and
timer are there, too.

Stefan

[Uwe Hermann]

On Mon, Nov 23, 2009 at 12:01:26PM +0800, Bao, Zheng wrote:
> Should the spkr.c be in the folder sb600, or more public folders like
> pc80?

It looks generic to me, I'd put it into lib or src/arch/i386/lib as it
might be x86-specific.

I wrote a similar function for v3 a while ago, see attached file. Feel
free to use that one or merge the best parts of both.

svn co svn://coreboot.org/repository/coreboot-v3

File: arch/x86/speaker.c

However, in your file spkr.c (please rename to speaker.c for better
readability) there is no license header, so we cannot commit it.
Please add the usual GPL header and/or reuse my code (if it works,
don't remember how much of it was tested in v3). Thanks!

Uwe.

[Stefan Reinauer]

On 11/23/09 10:58 AM, Uwe Hermann wrote:
> On Mon, Nov 23, 2009 at 12:01:26PM +0800, Bao, Zheng wrote:
> > Should the spkr.c be in the folder sb600, or more public folders like
> > pc80?
>
> It looks generic to me, I'd put it into lib or src/arch/i386/lib as it
> might be x86-specific.
>
> I wrote a similar function for v3 a while ago, see attached file. Feel
> free to use that one or merge the best parts of both.
>
> svn co svn://coreboot.org/repository/coreboot-v3
>
> File: arch/x86/speaker.c
>
> However, in your file spkr.c (please rename to speaker.c for better
> readability) there is no license header, so we cannot commit it.
> Please add the usual GPL header and/or reuse my code (if it works,
> don't remember how much of it was tested in v3). Thanks!
>
> Uwe.

I like this code a lot, but we should have a policy that beeping with a
delay is only allowed in fatal situations or something... Booting slower
for noise is not good (unless we play some really awesome jingle)

Stefan