enabling expert mode -> build fails (warnings treated as errors) on fam10 boards

[Ward Vandewege]

Hi all,

If one enables expert mode in Kconfig and builds a fam10 board, this is what happens:

$ make clean && make
    ROMCC      mainboard/supermicro/h8qme_fam10/bootblock.inc
    GEN        bootblock/bootblock.S
    CC         mainboard/supermicro/h8qme_fam10/bootblock.s
    CC         mainboard/supermicro/h8qme_fam10/bootblock.o
    GEN        bootblock/ldscript.ld
    LINK       bootblock.elf
    OBJCOPY    coreboot.bootblock
    OPTION     option_table.h
    GEN        build.h
    CC         romstage.inc
cc1: warnings being treated as errors
In file included from src/northbridge/amd/amdht/ht_wrapper.c:52:0,
                 from src/cpu/amd/quadcore/quadcore.c:22,
                 from src/mainboard/supermicro/h8qme_fam10/romstage.c:72:
src/northbridge/amd/amdht/h3finit.c: In function 'selectOptimalWidthAndFrequency':
src/northbridge/amd/amdht/h3finit.c:1332:24: error: "CONFIG_LIMIT_HT_SPEED_300" is not defined
src/northbridge/amd/amdht/h3finit.c:1336:24: error: "CONFIG_LIMIT_HT_SPEED_500" is not defined
make: *** [build/mainboard/supermicro/h8qme_fam10/romstage.pre.inc] Error 1

I looked around a bit; those config variables do not appear to be used anywhere
but in the checks in h3finit.c.

What's the best way to fix this?

Thanks,
Ward.

[Stefan Reinauer]

* Ward Vandewege  [110112 23:12]:
> Hi all,
>
> If one enables expert mode in Kconfig and builds a fam10 board, this is what happens:
>
> $ make clean && make
>     ROMCC      mainboard/supermicro/h8qme_fam10/bootblock.inc
>     GEN        bootblock/bootblock.S
>     CC         mainboard/supermicro/h8qme_fam10/bootblock.s
>     CC         mainboard/supermicro/h8qme_fam10/bootblock.o
>     GEN        bootblock/ldscript.ld
>     LINK       bootblock.elf
>     OBJCOPY    coreboot.bootblock
>     OPTION     option_table.h
>     GEN        build.h
>     CC         romstage.inc
> cc1: warnings being treated as errors
> In file included from src/northbridge/amd/amdht/ht_wrapper.c:52:0,
>                  from src/cpu/amd/quadcore/quadcore.c:22,
>                  from src/mainboard/supermicro/h8qme_fam10/romstage.c:72:
> src/northbridge/amd/amdht/h3finit.c: In function 'selectOptimalWidthAndFrequency':
> src/northbridge/amd/amdht/h3finit.c:1332:24: error: "CONFIG_LIMIT_HT_SPEED_300" is not defined
> src/northbridge/amd/amdht/h3finit.c:1336:24: error: "CONFIG_LIMIT_HT_SPEED_500" is not defined
> make: *** [build/mainboard/supermicro/h8qme_fam10/romstage.pre.inc] Error 1
>
> I looked around a bit; those config variables do not appear to be used anywhere
> but in the checks in h3finit.c.
>
> What's the best way to fix this?
>
> Thanks,
> Ward.

Looks like a piece of Kconfig patch went missing?

[xdrudis]

On Wed, Jan 12, 2011 at 11:57:39PM +0100, Stefan Reinauer wrote:
> Looks like a piece of Kconfig patch went missing?

I don't know but I think I already saw this last august. I didn't
care because I didn't know what I wanted expert mode for, so I 
just disabled it. I was never sure whether it might be some local 
modification. I guess it wasn't.