The attached patch adds code required for initializing the ACPI/power management/SMBus subdevice of PIIX4.
This is required for properly placing the I/O ports for power management functionalities, which in turn will be required for future ACPI work. Speaking of which, I based these ports at 0xe400, after my P2B-LS board. This support is far from complete, but one step at a time.
One other change I should propose (but is not in this patch) is that the definition for SMBUS_IO_BASE be moved to i82371eb.h from i82371eb_early_smbus.c. Makes more sense for a definition that may be referenced from some other places.
I was thinking to ask if someone know where to set this I/O base address, and turns out no initialization whatsoever was being done. :-O
Enjoy.
Signed-off-by: Keith Hui buurin@gmail.com
ping...
On Sun, Mar 28, 2010 at 10:43 PM, Keith Hui buurin@gmail.com wrote:
The attached patch adds code required for initializing the ACPI/power management/SMBus subdevice of PIIX4.
This is required for properly placing the I/O ports for power management functionalities, which in turn will be required for future ACPI work. Speaking of which, I based these ports at 0xe400, after my P2B-LS board. This support is far from complete, but one step at a time.
I was thinking to ask if someone know where to set this I/O base address, and turns out no initialization whatsoever was being done. :-O
Enjoy.
Signed-off-by: Keith Hui buurin@gmail.com
On 3/29/10 4:43 AM, Keith Hui wrote:
This is required for properly placing the I/O ports for power management functionalities, which in turn will be required for future ACPI work. Speaking of which, I based these ports at 0xe400, after my P2B-LS board.
That is problematic. Can you put it below 0x1000? IO ports 0x1000 and above are maintained by the register allocator and thus there may be conflicts, depending on what PCI cards you plug into that system.
One other change I should propose (but is not in this patch) is that the definition for SMBUS_IO_BASE be moved to i82371eb.h from i82371eb_early_smbus.c. Makes more sense for a definition that may be referenced from some other places.
Yes, absolutely.
Stefan
On 3/29/10 4:43 AM, Keith Hui wrote:
This is required for properly placing the I/O ports for power management functionalities, which in turn will be required for future ACPI work. Speaking of which, I based these ports at 0xe400, after my P2B-LS board.
That is problematic. Can you put it below 0x1000? IO ports 0x1000 and above are maintained by the register allocator and thus there may be conflicts, depending on what PCI cards you plug into that system.
As long as they are fixed resources, it should just work, but nothing above 0xe400 will be available for the allocator. It doesn't seem like too much address space lost, though.
Thanks, Myles
-
Keith Hui -
Myles Watson -
Stefan Reinauer