v3 patch: include

[ron minnich]

attached.

ron

[Carl-Daniel Hailfinger]

On 12.08.2008 02:00, ron minnich wrote:
> Make some things (die, mem*, resourcemap code, option code) SHARED. 
> The option code is tricky as it is used by standalone code. If you include
> that file and you are standalone, you now have to define STANDALONE
> (is there a better way?)
>
> Change the cpuid to be a 24-byte string instead of 3 u32s.
>
> Make the CPUID usage PIC-safe by not using %ebx.
>
> Signed-off-by: Ronald G. Minnich

Please keep in mind that every shared function bloats the image.

I assume you have build tested this change on all targets. It has the
potential to blow up on Geode.

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

On 12.08.2008 04:10, Carl-Daniel Hailfinger wrote:
> On 12.08.2008 02:00, ron minnich wrote:
> > Make some things (die, mem*, resourcemap code, option code) SHARED. 
> > The option code is tricky as it is used by standalone code. If you include
> > that file and you are standalone, you now have to define STANDALONE
> > (is there a better way?)
> >
> > Change the cpuid to be a 24-byte string instead of 3 u32s.
> >
> > Make the CPUID usage PIC-safe by not using %ebx.
> >
> > Signed-off-by: Ronald G. Minnich
>
> Please keep in mind that every shared function bloats the image.
>
> I assume you have build tested this change on all targets. It has the
> potential to blow up on Geode.

I forgot the Ack. It's simply too late for me.
If it builds on all targets (except the K8 one)
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel