patch: k8north more fixes etc. for compilation

[ron minnich]

attached

[Carl-Daniel Hailfinger]

On 04.08.2008 00:18, ron minnich wrote:
> This is much closer to compiling. 
> Need to get spd in. 
> now use the new options stuff from LAR. 
> Added correct defines for nvidia. 
> mv macros.h to include/arch/x86
> Other basic cleanup to get things to build.
>
> Still need to resolve the struct device thing. Probably going to write a 
> small function that takes bus, dev, fn and creates an un-connected struct device
> for stage 1 use only. This will get us there; we need to get working, then we
> can see the beautician.
>
> Signed-off-by: Ronald G. Minnich

Same comment as before: Ugly base code, but the patch improves the
situation.

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[ron minnich]

On Sun, Aug 3, 2008 at 3:36 PM, Carl-Daniel Hailfinger
 wrote:
> On 04.08.2008 00:18, ron minnich wrote:
> > This is much closer to compiling.
> > Need to get spd in.
> > now use the new options stuff from LAR.
> > Added correct defines for nvidia.
> > mv macros.h to include/arch/x86
> > Other basic cleanup to get things to build.
> >
> > Still need to resolve the struct device thing. Probably going to write a
> > small function that takes bus, dev, fn and creates an un-connected struct device
> > for stage 1 use only. This will get us there; we need to get working, then we
> > can see the beautician.
> >
> > Signed-off-by: Ronald G. Minnich
>
> Same comment as before: Ugly base code, but the patch improves the
> situation.
>
> Acked-by: Carl-Daniel Hailfinger

I have no argument with your comments here. We'll fix it! ;-)

Committed revision 717.

[Carl-Daniel Hailfinger]

On 04.08.2008 00:43, ron minnich wrote:
> On Sun, Aug 3, 2008 at 3:36 PM, Carl-Daniel Hailfinger
>  wrote:
> > On 04.08.2008 00:18, ron minnich wrote:
> > > This is much closer to compiling.
> > > Need to get spd in.
> > > now use the new options stuff from LAR.
> > > Added correct defines for nvidia.
> > > mv macros.h to include/arch/x86
> > > Other basic cleanup to get things to build.
> > >
> > > Still need to resolve the struct device thing. Probably going to write a
> > > small function that takes bus, dev, fn and creates an un-connected struct device
> > > for stage 1 use only. This will get us there; we need to get working, then we
> > > can see the beautician.
> > >
> > > Signed-off-by: Ronald G. Minnich
> >
> > Same comment as before: Ugly base code, but the patch improves the
> > situation.
> >
> > Acked-by: Carl-Daniel Hailfinger
>
> I have no argument with your comments here. We'll fix it! ;-)

I'm confident we will.
> Committed revision 717.

You forgot to svn add macros.h at the new location (or use svn mv in the
first place).

Regards,
Carl-Daniel

[ron minnich]

weird. I used svn move.

In fact it showed up in my diff.

hmm.

ron

[Ward Vandewege]

On Sun, Aug 03, 2008 at 04:14:58PM -0700, ron minnich wrote:
> weird. I used svn move.
>
> In fact it showed up in my diff.
>
> hmm.

Can you fix it? v3 build is now broken:

$ make
  CP      build/config.h
  GEN     build/build.h
  BUILD   DUMMY VPD
  CC      build/lib/uart8250.o
  CC      build/lib/mem.o
  CC      build/lib/lar.o
  CC      build/lib/delay.o
  CC      build/lib/vtxprintf.o
  CC      build/lib/vsprintf.o
  CC      build/lib/console.o
  CC      build/lib/string.o
  CC      build/lib/lzma.o
  CC      build/arch/x86/stage1.o
  CC      build/arch/x86/serial.o
  CC      build/arch/x86/speaker.o
  CC      build/arch/x86/udelay_io.o
  CC      build/arch/x86/mc146818rtc.o
  CC      build/arch/x86/post_code.o
  CC      build/arch/x86/geodelx/stage1.o
  CC      build/arch/x86/../../northbridge/amd/geodelx/geodelxinit.o
  CC      build/arch/x86/geodelx/stage0.o
arch/x86/geodelx/stage0.S:28:23:
error: ../macros.h: No such file or directory
make: ***
[build/arch/x86/geodelx/stage0.o]
Error 1

Thanks,
Ward.

[ron minnich]

yes, I am self-acking this one as it is a trivial fix. Sorry for the problem.

Please test.Committed revision 719.

ron

[Ward Vandewege]

On Sun, Aug 03, 2008 at 05:40:14PM -0700, ron minnich wrote:
> yes, I am self-acking this one as it is a trivial fix. Sorry for the problem.
>
> Please test.Committed revision 719.

Yep, fixed, thanks.

Thanks,
Ward.